Why this code is not working??? java script

Question

gen_validatorv2.js
     JavaScript Form Validator
Version 2.0.2
     Copyright 2003 JavaScript-coder.com. All rights reserved.
     You use this script in your Web pages, provided these opening credit
lines are kept intact.
     The Form validation script is distributed free from JavaScript-Coder.com
     You may please add a link to JavaScript-Coder.com,
     making it easy for others to find this script.
     Checkout the Give a link and Get a link page:
     http://www.javascript-coder.com/links/how-to-link.php
You may not reprint or redistribute this code without permission from
JavaScript-Coder.com.
     JavaScript Coder
     It precisely codes what you imagine!
     Grab your copy here:
          http://www.javascript-coder.com/
function Validator(frmname)
this.formobj=document.forms[frmname];
     if(!this.formobj)
     alert("BUG: couldnot get Form object "+frmname);
          return;
     if(this.formobj.onsubmit)
     this.formobj.old_onsubmit = this.formobj.onsubmit;
     this.formobj.onsubmit=null;
     else
     this.formobj.old_onsubmit = null;
     this.formobj.onsubmit=form_submit_handler;
     this.addValidation = add_validation;
     this.setAddnlValidationFunction=set_addnl_vfunction;
     this.clearAllValidations = clear_all_validations;
function set_addnl_vfunction(functionname)
this.formobj.addnlvalidation = functionname;
function clear_all_validations()
     for(var itr=0;itr < this.formobj.elements.length;itr++)
          this.formobj.elements[itr].validationset = null;
function form_submit_handler()
     for(var itr=0;itr < this.elements.length;itr++)
          if(this.elements[itr].validationset &&
     !this.elements[itr].validationset.validate())
          return false;
     if(this.addnlvalidation)
     str =" var ret = "+this.addnlvalidation+"()";
     eval(str);
if(!ret) return ret;
     return true;
function add_validation(itemname,descriptor,errstr)
if(!this.formobj)
     alert("BUG: the form object is not set properly");
          return;
     }//if
     var itemobj = this.formobj[itemname];
if(!itemobj)
     alert("BUG: Couldnot get the input object named: "+itemname);
          return;
     if(!itemobj.validationset)
     itemobj.validationset = new ValidationSet(itemobj);
itemobj.validationset.add(descriptor,errstr);
function ValidationDesc(inputitem,desc,error)
this.desc=desc;
     this.error=error;
     this.itemobj = inputitem;
     this.validate=vdesc_validate;
function vdesc_validate()
if(!V2validateData(this.desc,this.itemobj,this.error))
this.itemobj.focus();
          return false;
return true;
function ValidationSet(inputitem)
this.vSet=new Array();
     this.add= add_validationdesc;
     this.validate= vset_validate;
     this.itemobj = inputitem;
function add_validationdesc(desc,error)
this.vSet[this.vSet.length]=
     new ValidationDesc(this.itemobj,desc,error);
function vset_validate()
for(var itr=0;itr<this.vSet.length;itr++)
     if(!this.vSet[itr].validate())
          return false;
     return true;
function validateEmailv2(email)
// a very simple email validation checking.
// you can add more complex email checking if it helps
if(email.length <= 0)
     return true;
var splitted = email.match("^(.+)@(.+)$");
if(splitted == null) return false;
if(splitted[1] != null )
var regexp_user=/^\"?[\w-_\.]*\"?$/;
if(splitted[1].match(regexp_user) == null) return false;
if(splitted[2] != null)
var regexp_domain=/^[\w-\.]*\.[A-Za-z]{2,4}$/;
if(splitted[2].match(regexp_domain) == null)
     var regexp_ip =/^\[\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\]$/;
     if(splitted[2].match(regexp_ip) == null) return false;
}// if
return true;
return false;
function V2validateData(strValidateStr,objValue,strError)
var epos = strValidateStr.search("=");
var command = "";
var cmdvalue = "";
if(epos >= 0)
command = strValidateStr.substring(0,epos);
cmdvalue = strValidateStr.substr(epos+1);
else
command = strValidateStr;
switch(command)
case "req":
case "required":
if(eval(objValue.value.length) == 0)
if(!strError || strError.length ==0)
strError = objValue.name + " : Required Field";
}//if
alert(strError);
return false;
}//if
break;
}//case required
case "maxlength":
case "maxlen":
if(eval(objValue.value.length) > eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : "+cmdvalue+" characters maximum ";
}//if
alert(strError + "\n[Current length = " + objValue.value.length + " ]");
return false;
}//if
break;
}//case maxlen
case "minlength":
case "minlen":
if(eval(objValue.value.length) < eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : " + cmdvalue + " characters minimum ";
}//if
alert(strError + "\n[Current length = " + objValue.value.length + " ]");
return false;
}//if
break;
}//case minlen
case "alnum":
case "alphanumeric":
var charpos = objValue.value.search("[^A-Za-z0-9]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": Only alpha-numeric characters allowed ";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
}//case alphanumeric
case "num":
case "numeric":
var charpos = objValue.value.search("[^0-9]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": Only digits allowed ";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
}//numeric
case "alphabetic":
case "alpha":
var charpos = objValue.value.search("[^A-Za-z]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": Only alphabetic characters allowed ";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
}//alpha
          case "alnumhyphen":
var charpos = objValue.value.search("[^A-Za-z0-9\-_]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": characters allowed are A-Z,a-z,0-9,- and _";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if                
               break;
case "email":
if(!validateEmailv2(objValue.value))
if(!strError || strError.length ==0)
strError = objValue.name+": Enter a valid Email address ";
}//if
alert(strError);
return false;
}//if
break;
}//case email
case "lt":
case "lessthan":
if(isNaN(objValue.value))
alert(objValue.name+": Should be a number ");
return false;
}//if
if(eval(objValue.value) >= eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : value should be less than "+ cmdvalue;
}//if
alert(strError);
return false;
}//if
break;
}//case lessthan
case "gt":
case "greaterthan":
if(isNaN(objValue.value))
alert(objValue.name+": Should be a number ");
return false;
}//if
if(eval(objValue.value) <= eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : value should be greater than "+ cmdvalue;
}//if
alert(strError);
return false;
}//if
break;
}//case greaterthan
case "regexp":
               if(objValue.value.length > 0)
     if(!objValue.value.match(cmdvalue))
     if(!strError || strError.length ==0)
     strError = objValue.name+": Invalid characters found ";
     }//if
     alert(strError);
     return false;
     }//if
break;
}//case regexp
case "dontselect":
if(objValue.selectedIndex == null)
alert("BUG: dontselect command for non-select Item");
return false;
if(objValue.selectedIndex == eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name+": Please Select one option ";
}//if
alert(strError);
return false;
break;
}//case dontselect
}//switch
return true;
     Copyright 2003 JavaScript-coder.com. All rights reserved.
example.html
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Example for Validator</title>
<script language="JavaScript" src="gen_validatorv2.js" type="text/javascript"></script>
</head>
<body>
<form action="" name="myform" >
<table cellspacing="2" cellpadding="2" border="0">
<tr>
<td align="right">First Name</td>
<td><input type="text" name="FirstName"></td>
</tr>
<tr>
<td align="right">Last Name</td>
<td><input type="text" name="LastName"></td>
</tr>
<tr>
<td align="right">EMail</td>
<td><input type="text" name="Email"></td>
</tr>
<tr>
<td align="right">Phone</td>
<td><input type="text" name="Phone"></td>
</tr>
<tr>
<td align="right">Address</td>
<td><textarea cols="20" rows="5" name="Address"></textarea></td>
</tr>
<tr>
<td align="right">Country</td>
<td>
     <SELECT name="Country">
          <option value="" selected>[choose yours]
          <option value="008">Albania
          <option value="012">Algeria
          <option value="016">American Samoa
          <option value="020">Andorra
          <option value="024">Angola
          <option value="660">Anguilla
          <option value="010">Antarctica
          <option value="028">Antigua And Barbuda
          <option value="032">Argentina
          <option value="051">Armenia
          <option value="533">Aruba     
     </SELECT>
     </td>
</tr>
<tr>
<td align="right"></td>
<td><input type="submit" value="Submit"></td>
</tr>
</table>
</form>
<script language="JavaScript" type="text/javascript">
//You should create the validator only after the definition of the HTML form
var frmvalidator = new Validator("myform");
frmvalidator.addValidation("FirstName","req","Please enter your First Name");
frmvalidator.addValidation("FirstName","maxlen=20",
     "Max length for FirstName is 20");
frmvalidator.addValidation("FirstName","alpha");
frmvalidator.addValidation("LastName","req");
frmvalidator.addValidation("LastName","maxlen=20");
frmvalidator.addValidation("Email","maxlen=50");
frmvalidator.addValidation("Email","req");
frmvalidator.addValidation("Email","email");
frmvalidator.addValidation("Phone","maxlen=50");
frmvalidator.addValidation("Phone","numeric");
frmvalidator.addValidation("Address","maxlen=50");
frmvalidator.addValidation("Country","dontselect=0");
</script>
</body>
</html>
documentation.html
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<head>
     <title>JavaScript Form Validator Documentation</title>
<Style>
BODY, P,TD{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 10pt }
H1{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 18pt; color : #000066}
H3{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 12pt; color : #000066 }
A{font-family: Arial,Verdana,Helvetica, sans-serif;}
B {     font-family : Arial, Helvetica, sans-serif;     font-size : 12px;     font-weight : bold;}
CODE {font-family : Courier,monospace;font-size: 10pt;color : #800000;}
CODE.htm {font-family : "Courier New", Courier, monospace;     font-size : x-small;     color : #000080;}
</Style>
</head>
<body>
<center>
<table cellspacing="2" cellpadding="2" border="0" width="600">
<tr><td>
     <h1>JavaScript Form Validations Made Easy!</h1>
     <h3>Documentation for JavaScript Form Validator</h3>
     <HR size=1>
     <P>
     The Form validation script is distributed free from JavaScript-Coder.com<br>
     You can use the script in your web pages for free.
     </P>
     <P>
     You may please add a link to JavaScript-Coder.com,
     making it easy for others to find this script.<br>
     Checkout the <A href="http://www.javascript-coder.com/links/how-to-link.php
     target="_blank">Give a Link & Get a Link!</A> page.
     </P>
     <P>
     <B>JavaScript Coder</B><br>
     It precisely codes what you imagine!<br>
     Grab your copy here: http://www.javascript-coder.com
     </P>
     <HR size=1>
     <P>
     Using client side JavaScript is an efficient way to validate the user input
     in web applications. When there are many fields in the form, the JavaScript
     validation becomes too complex.
     </P>
     <P>
The JavaScript class presented here makes the form validations many times easier.
     </P>
     <P>
     The idea is to create a set of "validation descriptors" associated with each element
     in a form. The "validation descriptor" is nothing but a string specifying the type of
     validation to be performed.
     </P>
     <P>
     Each field in the form can have 0, 1, or more validations. For example, the input should
     not be empty, should be less than 25 chars, should be alpha-numeric, etc
     </P>
     You can associate a set of validation descriptors for each input field in the form.
     <a name="3"></a>
     <h3>Using The Script</h3>
     1.Include gen_validatorv2.js in your html file just before closing the HEAD tag<br><br>
     <CODE>
     <script language="JavaScript" src="gen_validatorv2.js" type="text/javascript"></script><BR>
     </head><BR>
     </CODE><br>
     2. Just after defining your form,
     Create a form validator object passing the name of the form<br><br>
     <CODE class='htm'>
      <FORM name='myform' action=""><BR>
      <!----Your input fields go here --><BR>
      </FORM><BR>
     </CODE><CODE>
      <SCRIPT language="JavaScript"><BR>
      var frmvalidator  = new Validator("myform");<BR>
     </CODE>
     <br>
     <br>
     3. Now add the validations required<br><br>
     <CODE>
          frmvalidator.addValidation("FirstName","alpha");
     </CODE><br><br>
     the first argument is the name of the field and the second argument is the
     validation descriptor, which specifies the type of validation to be performed.<br>
     You can add any number of validations.The list of validation descriptors are provided
     at the end of the documentation.<br>
     The optional third argument is the error string to be displayed if the validation
     fails.<br>
     <br>
     <CODE>
          frmvalidator.addValidation("FirstName","alpha");<br>
          frmvalidator.addValidation("FirstName","req","Please enter your First Name");<br>
          frmvalidator.addValidation("FirstName","maxlen=20",<br>
               "Max length for FirstName is 20");          <br>
     </CODE>     <br>
     <br>
     4. Similarly, add validations for the fields where validation is required.<br>
     That's it! You are ready to go.
     <A name="3"></A>
     <h3>Example</h3>
     The example below will make the idea clearer<br>
     <CODE class="htm">
               <form action="" name="myform" ><BR>
               <table cellspacing="2" cellpadding="2" border="0"><BR>
               <tr><BR>
                 <td align="right">First Name</td><BR>
                 <td><input type="text" name="FirstName"></td><BR>
               </tr><BR>
               <tr><BR>
                 <td align="right">Last Name</td><BR>
                 <td><input type="text" name="LastName"></td><BR>
               </tr><BR>
               <tr><BR>
                 <td align="right">EMail</td><BR>
                 <td><input type="text" name="Email"></td><BR>
               </tr><BR>
               <tr><BR>
                 <td align="right">Phone</td><BR>
                 <td><input type="text" name="Phone"></td><BR>
               </tr><BR>
               <tr><BR>
                 <td align="right">Address</td><BR>
                 <td><textarea cols="20" rows="5" name="Address"></textarea></td><BR>
               </tr><BR>
               <tr><BR>
                 <td align="right">Country</td><BR>
                 <td><BR>
                      <SELECT name="Country"><BR>
                         <option value="" selected>[choose yours]<BR>
                         <option value="008">Albania<BR>
                         <option value="012">Algeria<BR>
                         <option value="016">American Samoa<BR>
                         <option value="020">Andorra<BR>
                         <option value="024">Angola<BR>
                         <option value="660">Anguilla<BR>
                         <option value="010">Antarctica<BR>
                         <option value="028">Antigua And Barbuda<BR>
                         <option value="032">Argentina<BR>
                         <option value="051">Armenia<BR>
                         <option value="533">Aruba     <BR>
                     </SELECT><BR>
                    </td><BR>
               </tr><BR>
               <tr><BR>
                 <td align="right"></td><BR>
                 <td><input type="submit" value="Submit"></td><BR>
               </tr><BR>
               </table><BR>
               </form><BR>
               </CODE><CODE>
               <script language="JavaScript" type="text/javascript"><BR>
                var frmvalidator = new Validator("myform");<BR>
                frmvalidator.addValidation("FirstName","req","Please enter your First Name");<BR>
                frmvalidator.addValidation("FirstName","maxlen=20",<BR>
                    "Max length for FirstName is 20");<BR>
                frmvalidator.addValidation("FirstName","alpha");<BR>
                <BR>
                frmvalidator.addValidation("LastName","req");<BR>
                frmvalidator.addValidation("LastName","maxlen=20");<BR>
                <BR>
                frmvalidator.addValidation("Email","maxlen=50");<BR>
                frmvalidator.addValidation("Email","req");<BR>
                frmvalidator.addValidation("Email","email");<BR>
                <BR>
                frmvalidator.addValidation("Phone","maxlen=50");<BR>
                frmvalidator.addValidation("Phone","numeric");<BR>
                <BR>
                frmvalidator.addValidation("Address","maxlen=50");<BR>
                frmvalidator.addValidation("Country","dontselect=0");<BR>
               </script><BR>     
     </CODE>
     <A name="4"></A>
     <h3>Some Additional Notes</h3>
     <LI type="disc">The form validators should be created only after defining the HTML form
     (only after the </form> tag. )<br>
     <LI type="disc">Your form should have a distinguished name.
     If there are more than one form
     in the same page, you can add validators for each of them. The names of the
     forms and the validators should not clash.
     <LI type="disc">You can't use the javascript onsubmit event of the form if it you are
     using this validator script. It is because the validator script automatically overrides the
     onsubmit event. If you want to add a custom validation, see the section below
     </LI>
     <A name="5"></A>
     <h3>Adding Custom Validation</h3>
     If you want to add a custom validation, which is not provided by the validation descriptors,
     you can do so. Here are the steps:
     <LI type="disc">Create a javascript function which returns true or false depending on the validation.<br>
     <CODE>
          function DoCustomValidation()<BR>
          {<BR>
            var frm = document.forms["myform"];<BR>
            if(frm.pwd1.value != frm.pwd2.value)<BR>
            {<BR>
              alert('The Password and verified password does not match!');<BR>
              return false;<BR>
            }<BR>
            else<BR>
            {<BR>
              return true;<BR>
            }<BR>
          }<BR>
     </CODE><br>
     <LI type="disc">Associate the validation function with the validator object.<br>
     <CODE>
     frmvalidator.setAddnlValidationFunction("DoCustomValidation");
     </CODE><br>
     </LI>
     <P>
     The custom validation function will be called automatically after other validations.
     </P>
     <P>
     If you want to do more than one custom validations, you can do all those
     validations in the same function.
     </P>
     <CODE>
          function DoCustomValidation()<BR>
          {<BR>
            var frm = document.forms["myform"];<BR>
            if(false == DoMyValidationOne())<BR>
            {<BR>
              alert('Validation One Failed!');<BR>
              return false;<BR>
            }<BR>
            else<BR>
            if(false == DoMyValidationTwo())<BR>
            {<BR>
              alert('Validation Two Failed!');<BR>
              return false;<BR>
            }<BR>
            else<BR>
            {<BR>
              return true;<BR>
            }<BR>
          }<BR>
     </CODE><br>
     where DoMyValidationOne() and DoMyValidationTwo() are custom functions for
     validation.
     <A name="6"></A>
     <h3>Clear All Validations</h3>
     In some dynamically programmed pages, it may be required to change the validations in the
     form at run time. For such cases, a function is included which clears all validations in the
     validator object.<br><br>
     <CODE>
     frmvalidator.clearAllValidations();
     </CODE><br>
     <br>
     this function call clears all validations you set.<br>
     You will not need this method in most cases.
     <a name="7"></a>
     <h3>Table of Validation Descriptors</h3>     
<table cellspacing="2" cellpadding="2" border="1" width="520px">
<tr>
<td><FONT face=Arial size=2>
     required<BR>
     req </FONT>
     </td>
<td><FONT face=Arial size=2>The field should not be
empty </FONT>
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>
     maxlen=???<BR>
     maxlength=???
     </td>
<td><FONT face=Arial size=2>checks the length entered data to the maximum. For
example, if the maximum size permitted is 25, give the validation descriptor as "maxlen=25"
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>
     minlen=???<BR>
     minlength=???
     </td>
<td><FONT face=Arial size=2>checks the length of the entered string to the
required minimum. example "minlen=5"
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>
     alphanumeric /<BR>
     alnum </FONT>
     </td>
<td><FONT face=Arial size=2>Check the data if it
contains any other characters other than alphabetic or numeric characters
</FONT>
     </td>
</tr>     
<tr>
<td><FONT face=Arial size=2>num <BR>
     numeric </FONT>
     </td>
<td><FONT face=Arial size=2>Check numeric data
</FONT>
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>alpha <BR>
     alphabetic </FONT>
     </td>
<td><FONT face=Arial size=2>Check alphabetic data.
</FONT>
     </td>
</tr>     
<tr>
<td><FONT face=Arial size=2>email </FONT>
     </td>
<td><FONT face=Arial size=2>The field is an email
field and verify the validity of the data. </FONT>
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>lt=???<BR>
     lessthan=???
     </td>
<td><FONT face=Arial size=2>
     Verify the data to be less than the value passed.
     Valid only for numeric fields. <BR>
     example: if the
value should be less than 1000 give validation description as "lt=1000"
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>gt=???<BR>
     greaterthan=???     </td>
<td><FONT face=Arial size=2>
     Verify the data to be greater than the value passed.
     Valid only for numeric fields. <BR>
     example: if the
value should be greater than 10 give validation description as "gt=10"
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>regexp=??? </FONT>
     </td>
<td><FONT face=Arial size=2>
     Check with a regular expression the value should match the regular expression.<BR>
     example: "regexp=^[A-Za-z]{1,20}$" allow up to 20 alphabetic
     characters.
     </td>
</tr>
<tr>
<td><FONT face=Arial size=2>dontselect=?? </FONT>
     </td>
<td><FONT face=Arial size=2>This
validation descriptor is valid only for select input items (lists)
Normally, the select list boxes will have one item saying 'Select One' or
some thing like that. The user should select an option other than this
option. If the index of this option is 0, the validation description
should be "dontselect=0"
     </td>
</tr>
</table>
     <P>
          <table cellspacing="2" cellpadding="2" border="1" width="520">
          <tr>
          <td>
               <B>NOTE:</B><br>
               The HTML Form Wizard included in JavaScript Coder contains still more
               number of validations
               (comparison validations, check box & radio button validations and more)<br>
               Using the wizard, you can add validations to your forms
               without writing a single line of code! <br>
               JavaScript Coder takes care of
               generating the code and inserting the code in to the HTML file.<br>
               <A href="http://www.javascript-coder.com/index.phtml
               target="_blank">Read more about JavaScript Coder</A>
               </td>
          </tr>
          </table>
     </P>
     <A name="8"></A>
     <h3>Example Page</h3>     
     See the <a href="example.html target="_blank"
     >JavaScript form validation example here</a>
</td>
</tr>
<tr><td align="center">
     <HR><br>
     Copyright &copy; 2003 JavaScript-Coder.com. All rights reserved.
</td></tr>
</table>     
</center>
</body>
</html>

Answer 1

The code is not working because you made a mistake somewhere, duh! So figure out what (hint: firefox javascript console, it's your friend) and fix it!
And next time when you post code: use the [ code ]  tags to pretty format your code, as it is now it's unreadable.
http://forum.java.sun.com/help.jspa?sec=formatting