Workshop 8.1 sp2 bug?

Question

The following codes works fine in sp1. But it failed because the
userManagerControl was null in sp2.
In order to get the code work again, I have to comment the
session.invalidate(); codes.
If a session exists there, it has to be invalidated to avoid the session
intruder, right? And I checked the session attributes after I comment out
these lines, I couldn't find any where this userManagerControl is stored.
* @common:control
private ca.verax.timesheet.service.UserManagerControl
userManagerControl;
* @jpf:action
* @jpf:forward redirect="true" name="login" path="/whatever/begin.do"
* @jpf:validation-error-forward return-to="currentPage" name="fail"
protected Forward login(LoginForm form)
try
// This section has to be commented out in sp2 so that userManagerControl is
not null.
HttpSession session = getSession();
if (session != null)
session.invalidate();
session = null;
//comment ends.
String userEmail = form.getUsername();
String userId = userManagerControl.getUserId(userEmail);
if (userId != null && userId.length() > 0)
if (userManagerControl.canUserLogin(userId))
login(userId, form.getPassword());
} else
form.setMessage("You are not authorized to login to the
system. Please contact System Administrator for help.");
return new Forward("fail");
} else
form.setMessage("Invalid Email Address");
return new Forward("fail");
} catch(LoginException e)
form.setMessage("Invalid Email Address or password");
return new Forward("fail");
Bob Li
Senior Consultant
[email protected]

Answer 1

The following codes works fine in sp1. But it failed because the
userManagerControl was null in sp2.
In order to get the code work again, I have to comment the
session.invalidate(); codes.
If a session exists there, it has to be invalidated to avoid the session
intruder, right? And I checked the session attributes after I comment out
these lines, I couldn't find any where this userManagerControl is stored.
* @common:control
private ca.verax.timesheet.service.UserManagerControl
userManagerControl;
* @jpf:action
* @jpf:forward redirect="true" name="login" path="/whatever/begin.do"
* @jpf:validation-error-forward return-to="currentPage" name="fail"
protected Forward login(LoginForm form)
try
// This section has to be commented out in sp2 so that userManagerControl is
not null.
HttpSession session = getSession();
if (session != null)
session.invalidate();
session = null;
//comment ends.
String userEmail = form.getUsername();
String userId = userManagerControl.getUserId(userEmail);
if (userId != null && userId.length() > 0)
if (userManagerControl.canUserLogin(userId))
login(userId, form.getPassword());
} else
form.setMessage("You are not authorized to login to the
system. Please contact System Administrator for help.");
return new Forward("fail");
} else
form.setMessage("Invalid Email Address");
return new Forward("fail");
} catch(LoginException e)
form.setMessage("Invalid Email Address or password");
return new Forward("fail");
Bob Li
Senior Consultant
[email protected]