ADF Toy Store : create row : problem scenario

Question

hi (Steve)
While experimenting with the ADF Toy Store Demo (*1) I tried this scenario:
(1) Use the "Sign In" icon to navigate to "Register as a New User".
(2) Without entering data into the input fields, click the "Register" button. You will get errors for the required fields.
(3) (You change your mind about registering.) Click on "Games".
(4) (You see a nice game, so you still want to register.) Use the "Sign In" icon to navigate to "Register as a New User".
(5) Be nice and fill out all the fields and click the "Register" button.
[!] This will result in errors for the required fields (although you filled out all of them).
My guess is these errors are related to the first "account row" that was created.
Could someone suggest a "best practice" approach to avoid problems like these?
thanks
Jan Vervecken
*1 : http://www.oracle.com/technology/products/jdev/collateral/papers/10g/adftoystore.html
* : using JDeveloper 10.1.2 and ADF Toy Store 9.0.5.2.31 (Built on 21-Jun-2004)

Answer 1

thanks for your reply Steve
(1st) I've updated ToyStoreServiceImpl like you suggested:
  public boolean validSignon(String username, String password) {
    System.out.println("validSignon() : begin");
    removeAnyInvalidNewAccounts();
    return getAccounts().findAccountByUsernamePassword(username, password);
  public void prepareToCreateNewAccount() {
    System.out.println("prepareToCreateNewAccount() : begin");
    removeAnyInvalidNewAccounts();
    ViewObject vo = getAccounts();
    vo.clearCache();
     * Mark the view object as insert only by setting
     * it's max fetch size to zero. Executing the query
     * when the max fetch size is zero won't actually
     * perform any query, but will mark the VO as
     * executed so the ADF binding layer will know it
     * doesn't need to re-execute it later.
    vo.setMaxFetchSize(0);
    vo.executeQuery();
    Row newRow = vo.createRow();
    vo.insertRow(newRow);
    newRow.setNewRowState(Row.STATUS_INITIALIZED);
    vo.setCurrentRow(newRow);
    System.out.println("newRow = " + newRow);
    System.out.println("prepareToCreateNewAccount() : end");
   * Purge any new but invalid AccountImpl (and associated SignInImpl) instances
   * from the Entity Cache. These could get into the system if the user visits
   * the "Register a New User" page, enters invalid data and submits, but
   * instead of fixing the invalid data, click on another link to sign-in
   * as another valid account instead.
  private void removeAnyInvalidNewAccounts() {
    System.out.println("removeAnyInvalidNewAccounts() : begin");
    EntityDefImpl def = AccountImpl.getDefinitionObject();
    com.sun.java.util.collections.Iterator iter = def.getAllEntityInstancesIterator(getDBTransaction());
    while (iter.hasNext()) {
      AccountImpl acct = (AccountImpl) iter.next();
      System.out.println("considering acct = " + acct);
      if (acct.isInvalid() && (acct.getEntityState() == Entity.STATUS_NEW)) {
        System.out.println("removing acct = " + acct);
        acct.remove();
        acct.getSignon().remove();
    System.out.println("removeAnyInvalidNewAccounts() : end");
  //...(2nd) I've followed the original problem scenario I described at the beginning of this thread:
(1) Use the "Sign In" icon to navigate to "Register as a New User".
(2) Without entering data into the input fields, click the "Register" button. You will get errors for the required fields.
(3) (You change your mind about registering.) Click on "Games".
(4) (You see a nice game, so you still want to register.) Use the "Sign In" icon to navigate to "Register as a New User".
(5) Be nice and fill out all the fields and click the "Register" button.
[!] This will result in errors for the required fields (although you filled out all of them).
(3rd) That results in this output:
prepareToCreateNewAccount() : begin
removeAnyInvalidNewAccounts() : begin
removeAnyInvalidNewAccounts() : end
newRow = toystore.model.dataaccess.AccountsRowImpl@1
prepareToCreateNewAccount() : end
prepareToCreateNewAccount() : begin
removeAnyInvalidNewAccounts() : begin
removeAnyInvalidNewAccounts() : end
newRow = toystore.model.dataaccess.AccountsRowImpl@18b
prepareToCreateNewAccount() : end
questions
(1) I never seem to enter the while loop of your removeAnyInvalidNewAccounts() method, how come?
(2) Although my scenario never signs in with another valid account, do you consider my scenario to be similar to the one you describe in your comment for the removeAnyInvalidNewAccounts() method?
(3) In general, if creating (and inserting) new rows should be accompanied with methods like removeAnyInvalidNewEntityXs(), what would be the "rule of thumb" to determine where to call these methods? It is my impression that such methods should be inserted in different places to account for all the scenarios (paths in the application) a user can follow (and you better forget none).
thanks
Jan