Af:foreach Question?

Question

I am not sure if I am using a foreach correctly as it seems to hit the bean once for each item in the list of items?
For instance
I have a list of menu Items that I get with a method (See code below) and I have a foreach that I want to loop and display each menu item
So far this works perfect except that I notice that my getMenuItems getter is beign hit one time for every menuItem in the list? I assume that this also means that
toplink is going to the database each time to get a new list of items???
This seems like it's going to be fairly slow if the number of menuitems is large?
Am I doing this correctly or am I missing something here?
Any help would be greatly appreciated.
thanks
J
<af:foreach items="#{MenuManagedBean.menuItems}" var"#{menuItem}">
<af:outputText value="#{menuItem.Text}"/>
</af:foreach>
public List<MenuItem> menuItems
public void getMenuItems()
FacesContext fc = FacesContext.getCurrentInstance();
ValueBinding vb = fc.getApplication().createValueBinding("#{data}");
BindingContext bctx = (BindingContext)vb.getValue(fc);
DCDataControl dc = bctx.findDataControl("MenuItemPublicFacadeDataControl");
MenuItemPublicFacade facade = (MenuItemPublicFacade)dc.getDataProvider();
return facade.findAllMenuItems();
public void setMenuItems(List<Menuitem> menuItems)
thisl.menuItems = menuItems;
}

Answer 1

Your method could look something like this:
    public List<MenuItem> getMenuItems(){
        if(FacesContext.getCurrentInstance().getExternalContext().getSessionMap().containsKey("menuItems")){
            return (List<MenuItem>)FacesContext.getCurrentInstance().getExternalContext().getSessionMap().get("menuItems");
        else{
            FacesContext fc = FacesContext.getCurrentInstance();
            ValueBinding vb = fc.getApplication().createValueBinding("#{data}");
            BindingContext bctx = (BindingContext)vb.getValue(fc);
            DCDataControl dc = bctx.findDataControl("MenuItemPublicFacadeDataControl");
            MenuItemPublicFacade facade = (MenuItemPublicFacade)dc.getDataProvider();
            menuItems =  facade.findAllMenuItems();
            FacesContext.getCurrentInstance().getExternalContext().getSessionMap().put("menuItems", menuItems);
            return menuItems;
{code}
From your code, I think you are using JDeveloper 10g and as far as I know viewScope is not yet available, so this code uses sessionScope. The value you store in sessionMap is there as long as user session is active, so you should implement something that will reset "menuItems" (if menuItems changes in run time).
Pedja