Best way to find a string contains a list of keywords

Question

Could anyone do any different or is this good enough?
@ String line Line to be tested
@ String keyline Line that contains comma delimited keywords
private boolean containsAll(final String line, final String keyline) {
        int count = 0;
        String[] keywords = keyline.split(",");
        for (String keyword : keywords) {
            if (line.indexOf(keyword.trim()) != -1) {
                count++;
        return count == keywords.length;
    }Is Regex faster?
Thanks.

Answer 1

geeflow wrote:
Well! It looks that in my context the method needs to return FALSE if test string does not have ALL the items in the key word line. In my context, if keyword line = "", I run into trouble. That's an example of new requirements making the solution not good enough. Here's a way to incorporate splitting the keyword into the method, that should also eliminate the need for calling trim():
private boolean containsAll(String line, String keyLine) {
    for (String keyword : keyLine.split("[, ]+")) {
        if (!line.contains(keyword)) return false;
    return true;
} If line is empty, this will return false; no problem there. If keyLine is empty, you'll get a false positive. And if either one is null, you'll get a NullPointerException; you should probably check for those conditions first so you can throw a more helpful exception. You also have a case issue: "Double" is not the same as "double". You can get around that problem by using indexOfIgnoreCase() instead of contains().
So I am still wondering if I can get away with not using a counter.Yes, you can--at least until the next time the requirements change. ;-)