Boiler Controller CLD Preparatio​n

Question

First I thank everybody for providing feedback on Sprinkler Controller Example I posted recently. I have attempted now Boiler Controller example and posting it now for your feedback. The only thing I know I haven't done this time is adding vi documentation for Main.vi. This is because I wanted to take exactly four hours and see how much I could finish. So my apologies and I will definitely be adding more documentation in future.
This time I am only struggling generating events at certain values of sliders and knobs. Consequently, failing to finish full functionality in allocated time. Will really appreciate comments!
Thx
Austin
Attachments:
Controller Software.zip ‏336 KB

Answer 1

Austin,  I attached the results of the vi analizer (the exam graders will run this too!)  Essentially you've got some issues and I'll walk through 1 sub vi with you. Lets Take Controller_File IO.vi
First the name- Decorating your names with scope is kind of silly when using projects "File IO.vi on Boiler Controller.lvproj" is sufficient wouldn't you say?
It looks like you tried to make an action engine- where is the USR? Personally I'd populate a USR with File Name in the initialize case (and since you'll call Initialize directly from Main- Pass in Main.vi's path- to meet the relative to main location requirement without all the stripping)
Error handleing- WWYT? pass error though with error in =error! that error you just through out might have been important
A couple things here- Check if File or Folder exists is right on the advanced file function pallate and may have been a better choice to drive your case selector.  Watch your wire bends and- if the file open worked you left the referance open! This is a memory leak.  Why did you unbundle the error status rather than driver the case with the cluster? (of course using Check if File or Folder exists would never return an error)
In the Write case you have some sloppy wiring too but What is with the clear errors vi that has no error in wired to it Now if you passed the error wired to the outside case into the guts you'ld have a much cleaner AE
The FP:  Chosing the Arial 12 pt font was unwise as you'll see when you load the VI Analizer results and read this "Some part of the display of the control labeled "Consumer Datatype" does not use a specified font.  If you are using a font other than Application, System, or Dialog font, this could cause problems when porting this VI to another system that does not have the proper font(s) installed."
Size your enums so that all selections display in the window I read "Initializ" in the Initialize case (1 too many i's by the way) and no-sir I don't think the decorations or labels on them aid the vi at all.
On the Plus side- your-VI documentation is clear and you mentioned you intend to come back to the FP obejects to add tips and discriptions.
Overall about a C-   Go back through LabVIEW design patterns and Ben's Nugget on AEs and learn to use the VI analizer ( it'll help improve your style and documentation points on the test)
Jeff
Attachments:
AnalyzerResults12-30-11-12-10-11.txt ‏36 KB