CallableStatement + setString()

Question

Hi,
I am calling an oracle function with the CallableStatement, following is the sample code
cstmt = conn.prepareCall(SQL_FN_FAC_SEARCH_DATA);
cstmt.setLong(2, stateId);
cstmt.setString(3, facilityName);
cstmt.registerOutParameter(1, OracleTypes.CURSOR);
cstmt.execute();
rs = (ResultSet)cstmt.getObject(1);
while (rs.next()) { }
This works fine but if the facilityName has apostrophe like "mike's workshop" - i get sql exception. How come setString is not encoding the apostrophe - am i missing something?
Appreciate your input on this!
ornov

Answer 1

Sorry I only provided snippet of my code to get the point across but here is the entire method
private static final String SQL_FN_FAC_SEARCH_DATA
= " begin ? := pkg_enoi_enoi_pt_search.fn_pt_ptplc_search_data(?,?,?); end; ";
public List getFacilityIdsByOrgIdStateAndName(String state, String facilityName,String orgId) throws DAOException
ArrayList list = new ArrayList();
Connection conn = null;
CallableStatement cstmt = null;
ResultSet rs = null;
long l_orgId = 0l;
try {
conn = getConnection();
cstmt = conn.prepareCall(SQL_FN_FAC_SEARCH_DATA);
if(state !=null && state.length()>0) {
long stateId=-1;
try{
LookupServices ls= new LookupServices();
stateId= ls.getLLID("V_GBL_LK_STATE",state);
}catch(LookupServicesException lse){
throw new DAOException(lse);
cstmt.setLong(2, stateId);
log.info("stateId"+stateId);
}else{
cstmt.setNull(2,Types.INTEGER);
log.info("I am here 1");
if(facilityName!=null && facilityName.length()>0){
cstmt.setString(3, facilityName);
log.info("facilityName"+facilityName);
}else{
cstmt.setNull(3,Types.VARCHAR);
log.info("I am here 12") ;
if(orgId!=null && orgId.length()>0){
l_orgId =Long.parseLong(orgId);
log.info("org Id value is"+l_orgId);
cstmt.setLong(4,l_orgId);
}else{
cstmt.setNull(4,Types.INTEGER);
log.info("I am here 13");
cstmt.registerOutParameter(1, OracleTypes.CURSOR);
cstmt.execute();
rs = (ResultSet)cstmt.getObject(1);
log.info("I am here2") ;
while (rs.next()) {       
log.info("I am here 3");
long facilityId = rs.getLong(3);
log.info("The organization Ids for given parametes"+orgId);
list.add(new Long(facilityId));
} catch (SQLException sqle) {
sqle.printStackTrace();
throw new DAOException(sqle);
} finally {
closeResources(conn, cstmt, rs);
return list;
So the following method returns result if facilityName doesnt have any aprostrophe. But if there is a apostrophe - i get the following sqlexception thrown
com.tetratech.enoi.exception.PermitServicesException: com.tetratech.enoi.exception.DAOException: java.sql.SQLException: ORA-20000: ORA-00907: missing right parenthesis
ORA-06512: at "ENOI_P2.PKG_ENOI_ENOI_PT_SEARCH", line 222
ORA-06512: at line 1
     at com.tetratech.enoi.services.PermitServices.getFacilityIdsByOrgIdStateAndName(PermitServices.java:672)
     at com.tetratech.enoi.action.OpInfoAction.next(OpInfoAction.java:132)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
     at java.lang.reflect.Method.invoke(Method.java:324)
     at org.apache.struts.actions.DispatchAction.dispatchMethod(DispatchAction.java:280)
     at org.apache.struts.actions.LookupDispatchAction.execute(LookupDispatchAction.java:252)
     at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:484)
     at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:274)
     at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1482)
     at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:525)
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:760)
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].server.http.ServletRequestDispatcher.invoke(ServletRequestDispatcher.java:810)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].server.http.ServletRequestDispatcher.forwardInternal(ServletRequestDispatcher.java:322)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].server.http.HttpRequestHandler.processRequest(HttpRequestHandler.java:790)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].server.http.AJPRequestHandler.run(AJPRequestHandler.java:208)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].server.http.AJPRequestHandler.run(AJPRequestHandler.java:125)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].util.ReleasableResourcePooledExecutor$MyWorker.run(ReleasableResourcePooledExecutor.java:192)
     at java.lang.Thread.run(Thread.java:534)
Caused by: com.tetratech.enoi.exception.DAOException: java.sql.SQLException: ORA-20000: ORA-00907: missing right parenthesis
ORA-06512: at "ENOI_P2.PKG_ENOI_ENOI_PT_SEARCH", line 222
ORA-06512: at line 1
     at com.tetratech.enoi.dao.SearchPermitServicesDAO.getFacilityIdsByOrgIdStateAndName(SearchPermitServicesDAO.java:744)
     at com.tetratech.enoi.services.PermitServices.getFacilityIdsByOrgIdStateAndName(PermitServices.java:668)
     ... 20 more
Caused by: java.sql.SQLException: ORA-20000: ORA-00907: missing right parenthesis
ORA-06512: at "ENOI_P2.PKG_ENOI_ENOI_PT_SEARCH", line 222
ORA-06512: at line 1
     at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:137)
     at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:304)
     at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:271)
     at oracle.jdbc.driver.T4C8Oall.receive(T4C8Oall.java:625)
     at oracle.jdbc.driver.T4CCallableStatement.doOall8(T4CCallableStatement.java:180)
     at oracle.jdbc.driver.T4CCallableStatement.execute_for_rows(T4CCallableStatement.java:790)
     at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1109)
     at oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:2901)
     at oracle.jdbc.driver.OraclePreparedStatement.execute(OraclePreparedStatement.java:2992)
     at oracle.jdbc.driver.OracleCallableStatement.execute(OracleCallableStatement.java:4124)
     at com.evermind[Oracle Application Server Containers for J2EE 10g (10.1.2.0.0)].sql.PreparedStatementBCELProxy.execute(PreparedStatementBCELProxy.java:363)
     at com.tetratech.enoi.dao.SearchPermitServicesDAO.getFacilityIdsByOrgIdStateAndName(SearchPermitServicesDAO.java:731)
     ... 21 more