Calling Function in Stored Procedure

Question

Hi all,
I've created table below,
CREATE TABLE TEST
  ID                  NUMBER(3)    NOT NULL,
  selectcode          VARCHAR2(10),
  value_use           VARCHAR2(10),
  bin_no              NUMBER(10),
  markup              VARCHAR2(40),
  descr               VARCHAR2(100),
  value_imp           VARCHAR2(90)
create sequence idseq;
insert into test values (idseq.nextval,'rel','C1',1,'master','test1');
insert into test values (idseq.nextval,'rel','C1',1,'masterdir','test2');
insert into test values (idseq.nextval,'rel','C1',2,'master','test3');
insert into test values (idseq.nextval,'rel','C2',2,'masterdir','test4');
insert into test values (idseq.nextval,'rel','C2',2,'master','test5');
insert into test values (idseq.nextval,'rel1','C2',1,'master','test6');
insert into test values (idseq.nextval,'rel1','C2',1,'masterdir','test7');
select * from test;
ID     SELECTCODE     VALUE_USE      BIN_NO     MARKUP                  DESCR
1         rel                C1              1     master                  test1
2         rel                C1              1     masterdir          test2
3         rel            C1              2     master                  test3
4         rel                C2            2     masterdir          test4
5         rel                C2              2     master                  test5
6         rel1        C2              1     master                   test6
7         rel1           C2              1     masterdir            test6There is an existing function called valcon which returns data for value_imp based on value_use and markup in the table.
SQL>select valcon ('C1','master',' ','VALUE',' ') output from dual;
OUTPUT
Value In County
I created a stored procedure, to insert values to this table using this function.. But I'm not sure how to pass the value inside the function..
CREATE OR REPLACE PROCEDURE test_sp
  ( in_selectcode    IN varchar2,
    in_valueuse      IN varchar2
AS
cursor val_cur is
    select *
    from test
    where ....;
TYPE val_typ IS TABLE OF val_cur%ROWTYPE;
val_arr  val_typ;
begin
open cursor..
fetch cursor into val_arr;
FOR ..
  LOOP
     insert into test (id, selectcode, value_use, selectval,value_imp)
     select  id_seq.nextval, in_selectcode, 'C1',  Nvl2(Trim(in_selectcode),'Y','N'),
     valcon ('val_arr.value_use','val_arr.markup',' ','VALUE',' ')
     from dual;
end loop;
close cursor;
end;
end test_sp
/ Since i'm using an array, can you please tell me how I can pass 'val_arr.value_use' as a string in the function? I researched a lot to find this, but I couldnt find how I can do this.
Thank you

Answer 1

I've used an update query to update test.bin_no in a sequence for the same selectcode and value_use. But I'm trying to see if I can do this within the insert query so I dont have to duplicate the work with one insert and one update.
The procedure below works with update query:
CREATE TABLE TEST
  ID                  NUMBER(3)    NOT NULL,
  selectcode          VARCHAR2(10),
  value_use           VARCHAR2(10),
  bin_no              NUMBER(10),
  markup              VARCHAR2(40),
  descr               VARCHAR2(100),
  value_imp           VARCHAR2(90)
create sequence idseq;
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel','C1',1,'Y');
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel','C1',1,'Y');
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel','C1',2,'Y');
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel','C2',2,'Y');
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel','C2',2,'Y');
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel1','C2',1,'Y');
insert into test (id,selectcode,value_use,bin_no,value_imp) values (idseq.nextval,'rel1','C2',1,'Y');
select * from test;
ID     SELECTCODE     VALUE_USE      BIN_NO     VALUE_IMP     
1         rel                C1              1     Y           
2         rel                C1              2     Y         
3         rel            C1              2     Y          
4         rel                C2            2     Y  
5         rel                C2              2     Y                
6         rel1        C2              1     Y            
7         rel1           C2              1     Y      
CREATE OR REPLACE PROCEDURE test_sp (in_selectcode   IN VARCHAR2,
                                     in_valueuse     IN VARCHAR2
                                    ) AS
  msg   VARCHAR2 (4000);
BEGIN
  INSERT INTO test (id, selectcode, value_use, bin_no, selectval, value_imp
    SELECT   id_seq.NEXTVAL,
             in_selectcode,
             'C1',
             bin_no,
             NVL2 (TRIM (in_selectcode), 'Y', 'N'),
             valcon (value_use, markup, ' ', 'VALUE', ' ')
    FROM     kn_job
    WHERE    scode= in_selectcode;
     update test t
     set t.bin_no = (select t1.r from
              (select rowid, ROW_NUMBER() OVER(PARTITION BY in_selectcode, in_valueuse ORDER BY id asc) r from test) t1
              where t.rowid=t1.rowid);
end test_sp
select * from test;
ID     SELECTCODE     VALUE_USE      BIN_NO     VALUE_IMP     
1         rel                C1              1     Y           
2         rel                C1              2     Y         
3         rel            C1              3     Y          
4         rel                C2            1     Y  
5         rel                C2              2     Y                
6         rel1        C2              1     Y            
7         rel1           C2              2     Y       But is it possible to do this without an update query? Updating bin_no in a sequence for selectcode,value_use?
Thanks