Can not insert

Question

Hi, all
I tried to transfer data from one table SAMPLE2951 to another table SAMPLE. SAMPLE2951 had 2951 records while SMAPLE was an empty one. I need the SAMPLE's PK be an automatic number.
My script was like:
CREATE TABLE "FLOWLIMS"."SAMPLE" (
"SAMPLEID" INTEGER NOT NULL,
"ID" INTEGER NOT NULL,
"CLASSIFICATION" VARCHAR2(50),
"DATEPROCESSED" DATE,
"DATEFAILURE" DATE,
"DATEFROZEN" DATE,
"DAYSOFTRAN" INTEGER,
"TUBEID" VARCHAR2(100),
"STUDYYEAR" INTEGER,
"VISITTIME" INTEGER,
"FORWHOM" VARCHAR2(100),
"CELLSPERML" VARCHAR2(100),
"VIALSFROZEN" INTEGER,
"NOTES" VARCHAR2(1000),
"TUBENUMBER" INTEGER,
"SAMPLETYPE" VARCHAR2(50),
PRIMARY KEY("SAMPLEID") VALIDATE,
FOREIGN KEY("ID") REFERENCES "FLOWLIMS"."LABDRAWN" ("ID") VALIDATE
CREATE SEQUENCE SAMPLE_SAMPLEID_SEQ;
CREATE OR REPLACE TRIGGER SAMPLE_TRG
BEFORE INSERT ON SAMPLE
FOR EACH ROW
BEGIN
SELECT SAMPLE_SAMPLEID_SEQ.NEXTVAL INTO :NEW.ID FROM DUAL;
END;
This part ran very well.
And then I tried to transfer data:
INSERT INTO SAMPLE (ID, CLASSIFICATION, DATEPROCESSED, DATEFROZEN, TUBEID, STUDYYEAR, VISITTIME, FORWHOM, NOTES) SELECT "ID", "CLASSIFICATION", "DATEPROCESSED", "DATEFROZEN", "TUBEID", "STUDYYEAR", "VISITTIME", "FORWHOM", "NOTES" FROM SAMPLE2951;
I used to transfer data like this, but this time the system reported an error:
ERROR at line 1:
ORA-01400: cannot insert NULL into ("FLOWLIMS"."SAMPLE"."SAMPLEID")
My SAMPLEID is supposed to generate automatically.
Is anything wrong?
Any advice is highly appreciated!
Qian

Answer 1

Perhaps you intended your trigger to select into :new.SampleID rather than :new.ID, which you're passing in as part of your INSERT statement...
Justin