Can't insert recors fetched by cursor in the table

Question

HI
i am fetching records from my table total_budget.All the fetched records are displayed in a tabular data block(data block name is forecast_result).Now i want to insert these record fetched by cursor in my table forecast_resul which is empty.how can i do it.I am sending the code if any one can help............
When i execute this code it give me error unable to insert(FRM-40508) .I have carefully checked table columns names and their data types.All r fine but i dont know y it is not working.Here is the code
DECLARE
cursor c1 IS
SELECT ministry_id,fiscal_year ,t_amount
FROM total_budget
WHERE ministry_id=:global.var11 AND (fiscal_year BETWEEN :syear and :eyear);
BEGIN
T_XSUMX := 0;
     OPEN C1;
     X:=1;
     SUMX := 0; SUMY := 0; SUMXY:=0; SUMX2 := 0;
     go_block('forecast_result');
     first_record;
     LOOP
          FETCH C1 INTO Y1,Y2,Y;
          EXIT WHEN C1%NOTFOUND;
          SUMY := SUMY +Y;
          XY := X*Y;
          X2 := X*X;
          SUMX := SUMX + X;
SUMXY := SUMXY + XY;
          SUMX2 := SUMX2 + X2;
               :forecast_result.ministry_id:=Y1;
               :forecast_result.fiscal_year:=Y2;
          :forecast_result.t_amount:=Y;
     NEXT_RECORD;
          X := X + 1;
     END LOOP;
     close C1;
z:=X-2;
     X_BAR := z;
     X := z+1;
     T_XSUMX := X * SUMX;
     T_SUMY := SUMY * SUMX;
     T_SUMX := SUMX * SUMX;
     T_SUMXY := SUMXY * X;
     T_SUMX2 := SUMX2 * X;
     R1 := T_SUMY - T_SUMXY;
     R2 := T_SUMX - T_SUMX2;
     B := ROUND(R1/R2,1);
     A := ROUND((T_SUMXY -(T_SUMX2*B))/T_XSUMX,1);
     Y_BAR := A+(B*X_BAR);
:forecast_result.ministry_id:=Y1;
:forecast_result.fiscal_year:=Y2;
:forecast_result.t_amount:=Y_BAR;
next_record;
     insert into forecast_result
     values(:forecast_result.ministry_id,:forecast_result.fiscal_year,:forecast_result.t_amount);
     commit;
END;
Can anyone tell me wat i am doing wrong
looking for instant reply
nida

Answer 1

Hi alma,
Plz u dnt wrt babytalk rr SMS-language -> mi! Becoz mi don lejk dat.
I suppose that your data block "forecast_result" are based on the table of the same name. Otherwise this may be the cause of some of your trouble.
Your code would properly work better like this:
DECLARE
  X NUMBER(38);
  SUMX NUMBER(38);
  SUMY NUMBER(38);
  Y NUMBER(38) ;
  Y1 varchar2(10);
  Y2 varchar2(10);
  X2 NUMBER(38);
  XY NUMBER(38);
  SUMXY NUMBER(38);
  SUMX2 NUMBER(38);
  X_BAR NUMBER(38);
  Y_BAR NUMBER(38);
  T_SUMY NUMBER(38);
  T_SUMX NUMBER(38);
  T_SUMXY NUMBER(38);
  T_SUMX2 NUMBER(38);
  T_XSUMX NUMBER(38);
  R1 NUMBER(38);
  R2 NUMBER(38);
  A NUMBER(38);
  z number(38);
  B NUMBER(38);
  final number(38);
  -- Just curious, where does :syear and :eyear come from ??
  cursor c1 IS
   SELECT ministry_id, fiscal_year, t_amount
    FROM total_budget
   WHERE ministry_id=:global.var11
     AND (fiscal_year BETWEEN :syear and :eyear);
BEGIN
  T_XSUMX := 0;
  X:=1;
  SUMX := 0;
  SUMY := 0;
  SUMXY:=0;
  SUMX2 := 0;
  go_block('forecast_result');
  -- If you're making this dynamically, then clear the block to start with.
  clear_block(NO_COMMIT);
  first_record;
  OPEN C1;
  LOOP
    FETCH C1 INTO Y1, Y2, Y;
    EXIT WHEN C1%NOTFOUND;
    SUMY := SUMY + Y;
    XY := X*Y;
    X2 := X*X;
    SUMX := SUMX + X;
    SUMXY := SUMXY + XY;
    SUMX2 := SUMX2 + X2;
    :forecast_result.ministry_id := Y1;
    :forecast_result.fiscal_year := Y2;
    :forecast_result.t_amount := Y;
    -- NO, this will not work. You have to CREATE the record. You only get the
    -- first record for "free". Next_Record moves to allready existing records.
    -- NEXT_RECORD;
    Create_Record;
    X := X + 1;
  END LOOP;
  close C1;
  z := X - 2;
  X_BAR := z;
  X := z + 1;
  T_XSUMX := X * SUMX;
  T_SUMY := SUMY * SUMX;
  T_SUMX := SUMX * SUMX;
  T_SUMXY := SUMXY * X;
  T_SUMX2 := SUMX2 * X;
  R1 := T_SUMY - T_SUMXY;
  R2 := T_SUMX - T_SUMX2;
  B := ROUND(R1/R2,1);
  A := ROUND((T_SUMXY -(T_SUMX2*B))/T_XSUMX,1);
  Y_BAR := A+(B*X_BAR);
  -- What are you doing here ?? This is weird. The population of the records are done in
  -- the loop ! You don't have to add anything here.
  -- :forecast_result.ministry_id:=Y1;
  -- :forecast_result.fiscal_year:=Y2;
  -- :forecast_result.t_amount:=Y_BAR;
  -- Since your data block (hopefully) are based on the table of the same name, you DON'T
  -- need to do this. You just have to press the commit button (or F10 or the floppy disk
  -- icon or what-ever).
  -- insert into forecast_result
  -- values(:forecast_result.ministry_id,:forecast_result.fiscal_year,:forecast_result.t_amount);
  -- commit;
END;