Can we Improve the code Further

Question

Hi All i 've the following code.
Can we improve the code further PROBABLY BY USING FORALL OR VARRAYS?
(MY ORACLE VERSION IS 10.2).
Thanks in Advance
CREATE OR REPLACE PROCEDURE PR_INS_TEM_EMP(M_USER_DEFINED_VALUE NUMBER,
P_ESAL NUMBER,
P_EDEPTNO NUMBER,
P_USER_ID VARCHAR2) IS
CURSOR C1 IS
SELECT ENO,ENAME FROM EMP WHERE ROWNUM <= M_USER_DEFINED_VALUE;
TYPE T_EMP IS TABLE OF C1%TYPE;
M_T_EMP T_EMP;
BEGIN
IF C1%ISOPEN THEN
CLOSE C1;
END IF;
OPEN C1;
FETCH C1 BULK COLLECT INTO M_T_EMP;
CLOSE C1;
FOR I IN 1..M_T_EMP.LAST LOOP
INSERT INTO TEMP_EMP(ENO,
ENAME,
ESAL,
EDEPT_NO,
USER_ID
(M_T_EMP(I).ENO,
M_T_EMP(I).ENAME,
P_ESAL,
P_EDEPTNO,
P_USER_ID
END LOOP;
END;

Answer 1

Hello, why use a cursor at all, why not:
CREATE OR REPLACE PROCEDURE PR_INS_TEM_EMP(M_USER_DEFINED_VALUE NUMBER) IS
BEGIN
  INSERT /*+ APPEND */ INTO TEMP_EMP(ENO,ENAME,ESAL,EDEPT_NO,USER_ID)
  SELECT ENO,ENAME
    FROM EMP
WHERE ROWNUM <= M_USER_DEFINED_VALUE;
END;And you are declaring but never using P_ESAL NUMBER,P_EDEPTNO NUMBER & P_USER_ID VARCHAR2. So why have them?
By the way, putting {noformat}{noformat} before and after your code will help the readability no end.