Causing duplicate records

Question

Hi,
generally we use the following api to insert records. but it is causing duplication of records. plz give me some guide lines.
/* Formatted on 2006/04/21 15:31 (Formatter Plus v4.5.2) */
CREATE OR REPLACE PACKAGE BODY cec_ipc_transactions_api
AS
PROCEDURE LOG (
p_transaction_type VARCHAR2,
p_order_number NUMBER,
p_header_id NUMBER,
p_order_id VARCHAR2,
p_original_order_id VARCHAR2,
p_version NUMBER,
p_cancel_flag VARCHAR2,
p_success OUT BOOLEAN,
p_error_message OUT VARCHAR2,
p_order_source IN VARCHAR2
DEFAULT 'MarketPlace Router Store',
p_business_entity IN VARCHAR2 DEFAULT 'UNK'
IS
x_header_id NUMBER;
x_order_number NUMBER;
x_statement_id NUMBER;
x_task_id NUMBER;
x_org_id NUMBER;
x_transaction_type VARCHAR2 (60);
x_transaction_type_old VARCHAR2 (60) := NULL;
x_error_message VARCHAR2 (2000);
x_coe_flag VARCHAR (1) := NULL;
-- Added on 10 FEB 2005
x_errcode VARCHAR2 (240);
x_errmsg VARCHAR2 (240);
v_procedure_name VARCHAR2 (80) := '<11i Procedure Name>';
v_tran_control_rec xxcca_iei_ne_util.cca_iei_tran_control_rec;
-- 5/16/99 -- add open_flag = 'Y' to preven DTS errors when cancelling orders
-- Everest Migration 10.7 to 11i ---Change Date '14 JUL 2004'
-- Get header id of respective order for update with nowait option from oe_order_headers_all
CURSOR lock_header (p_header_id NUMBER)
IS
SELECT ooha.header_id header_id
FROM oe_order_headers_all ooha,
xxcca_oe_order_headers_ext xoohe
WHERE ooha.header_id = p_header_id
AND ooha.header_id = xoohe.header_id
AND NVL (xoohe.cms_customer_version, -999) < p_version
AND ooha.open_flag
|| '' = 'Y'
FOR UPDATE OF xoohe.cms_customer_version NOWAIT;
BEGIN
cec_debug_pk.DEBUG ('Begin CEC_IPC_TRANSACTIONS_API.log');
CEC_DEBUG_PK.debug('EAH ord: ' || p_order_number
|| ' hdrid: ' || p_header_id
|| ' ordid: ' || p_order_id
|| ' origid: ' || p_original_order_id
|| ' vers: ' || p_version
|| ' src: ' || p_order_source
|| ' ent: ' || p_business_entity);
IF p_header_id IS NULL
THEN
BEGIN
x_statement_id := 10;
-- Everest Migration 10.7 to 11i ---Change Date '14 JUL 2004'
-- Get the header id, org id, order number of the respetive order from oe_order_headers_all
SELECT header_id, org_id, order_number
INTO x_header_id, x_org_id, x_order_number
FROM oe_order_headers_all
WHERE order_number = p_order_number;
EXCEPTION
WHEN NO_DATA_FOUND
THEN
NULL;
END;
ELSE
-- Everest Migration 10.7 to 11i ---Change Date '14 JUL 2004'
-- Get the org id, order number of the respective order from oe_order_headers_all
BEGIN
SELECT org_id, order_number
INTO x_org_id, x_order_number
FROM oe_order_headers_all
WHERE header_id = p_header_id;
EXCEPTION
--TD #38404 - Added exception handler
WHEN NO_DATA_FOUND
THEN
NULL;
END;
x_header_id := p_header_id;
END IF;
IF x_org_id IS NULL AND NVL (p_version, 1) = 1
THEN
BEGIN
SELECT org_id
INTO x_org_id
FROM cec_ipc_transactions
WHERE original_order_id = p_original_order_id
AND NVL (version, 1) = p_version
AND org_id > -1000
AND ROWNUM = 1;
EXCEPTION
WHEN NO_DATA_FOUND
THEN
NULL;
END;
END IF;
IF x_org_id IS NULL AND NVL (p_version, 1) = 1
THEN
BEGIN
SELECT TO_NUMBER (meaning)
INTO x_org_id
FROM cec_lookups
WHERE lookup_type = 'CEC_ORG_ID'
AND lookup_code = p_business_entity
AND ROWNUM = 1;
EXCEPTION
WHEN NO_DATA_FOUND
THEN
x_org_id := -1000;
END;
END IF;
x_transaction_type := p_transaction_type;
If the transaction type is a terminal transaction type,
then we try to update the version in xxcca_oe_order_headers_ext.
If the record is locked, set the transaction type to
COE_LOCKED.
IF x_transaction_type IN
(cec_globals_pk.coe_manual_rlse, cec_globals_pk.coe_ec_applied)
THEN
BEGIN
FOR c IN lock_header (x_header_id)
LOOP
-- Everest Migration 10.7 to 11i ---Change Date '14 JUL 2004'
-- Updae the cms customer version of the respective order in xxcca_oe_order_headers_ext table
UPDATE xxcca_oe_order_headers_ext
SET cms_customer_version = p_version
WHERE header_id = c.header_id;
END LOOP;
EXCEPTION
WHEN OTHERS
THEN
-- Handle locked record
IF SQLCODE = -54
THEN
x_transaction_type := cec_globals_pk.coe_locked;
-- if the record is locked, we want to save the
-- old trans type so we can later restore it
x_transaction_type_old := p_transaction_type;
END IF;
END;
END IF;
-- If the change is "done" either by automatic application or by
-- release of all IC change holds, we want to send out the
-- order acknowledgments
-- This is done by inserting into CCA_NOTIFY_CHANGES table
IF x_transaction_type IN (cec_globals_pk.coe_manual_rlse,
cec_globals_pk.coe_ec_applied
AND NVL (p_version, 1) > 1
THEN
-- Commented the insert and changed as follows on 10 FEB 2005
/*INSERT INTO cca_iei_tran_control
(source_system,
source_id,
control_id,
request_start_time,
tran_type,
tran_status,
tran_ack_q,
tran_code
VALUES ('IC_CHANGE',
cca_iei_tran_control_s1.NEXTVAL,
x_order_number,
SYSDATE,
'ORDER',
'NEW',
999,
'IC_CHANGE'
-- Added on 10 FEB 2005
SELECT cca_iei_tran_control_s1.NEXTVAL
INTO v_tran_control_rec.DATA.source_id
FROM DUAL;
v_tran_control_rec.DATA.control_id := x_order_number;
v_tran_control_rec.DATA.header_id := x_header_id;
v_tran_control_rec.DATA.tran_ack_q := 999;
v_tran_control_rec.DATA.tran_code := 'IC_CHANGE';
v_tran_control_rec.DATA.tran_status := 'NEW';
v_tran_control_rec.DATA.tran_type := 'ORDER';
v_tran_control_rec.DATA.request_start_time := SYSDATE;
v_tran_control_rec.DATA.source_system := 'IC_CHANGE';
v_tran_control_rec.DATA.attribute5 := v_procedure_name;
xxcca_iei_ne_util.insert_cca_iei_tran_control (
v_tran_control_rec,
x_errcode,
x_errmsg
END IF;
IF x_transaction_type = cec_globals_pk.coe_print_and_tear
AND (NVL (p_version, 1) > 1 AND x_header_id IS NULL)
THEN
x_transaction_type := cec_globals_pk.coe_ec_applied;
END IF;
/* Try to update existing record in CEC_IPC_TRANSACTIONS for this
header_id / version combination.
If none is found, then create a new one.
Usually, the Query will create the record and others will update
It is possible that another transaction type will result in the
creation of the CEC_IPC_TRANSACTIONS record if the order was not
imported yet or if ERP was down at the time of Query.
x_statement_id := 20;
x_coe_flag := NULL;
IF x_transaction_type = cec_globals_pk.coe_submitted
THEN
BEGIN
SELECT 'X'
INTO x_coe_flag
FROM cec_ipc_transactions
WHERE status_code
|| '' NOT IN (cec_globals_pk.coe_aborted,
cec_globals_pk.coe_queried,
cec_globals_pk.coe_expired,
cec_globals_pk.coe_locked,
cec_globals_pk.coe_wait,
cec_globals_pk.coe_wait_for_version,
cec_globals_pk.coe_wait_for_cust_data,
cec_globals_pk.coe_importing_cust_data
AND ( erp_header_id = x_header_id
OR ( original_order_id = p_original_order_id
AND order_source <> 'ALL'
AND NVL (version, 1) = NVL (p_version, 1);
EXCEPTION
WHEN OTHERS
THEN
x_coe_flag := NULL;
END;
END IF;
IF NVL (x_coe_flag, 'YY') != 'X'
THEN
UPDATE cec_ipc_transactions
SET status_code = x_transaction_type,
status_code_old = x_transaction_type_old,
operation_code = DECODE (
operation_code,
'CANCEL', operation_code,
DECODE (
p_version,
NULL, 'INSERT',
1, 'INSERT',
DECODE (
p_cancel_flag,
'Y', 'CANCEL',
'UPDATE'
change_query_date = DECODE (
x_transaction_type,
cec_globals_pk.coe_queried, SYSDATE,
change_query_date
change_submit_date =
NVL (
change_submit_date,
DECODE (
x_transaction_type,
cec_globals_pk.coe_submitted, SYSDATE,
cec_globals_pk.coe_print_and_tear, SYSDATE,
change_submit_date
change_complete_date =
DECODE (
x_transaction_type,
cec_globals_pk.coe_manual_rlse, SYSDATE,
cec_globals_pk.coe_aborted, SYSDATE,
cec_globals_pk.coe_expired, SYSDATE,
cec_globals_pk.coe_ec_applied, SYSDATE,
cec_globals_pk.coe_print_and_tear, NULL,
cec_globals_pk.coe_submitted, NULL,
change_complete_date
WHERE ( ( original_order_id = p_original_order_id
AND order_source <> 'ALL'
OR erp_header_id = x_header_id
AND NVL (version, 1) = NVL (p_version, 1);
-- If update failed, then insert
IF SQL%ROWCOUNT = 0
THEN
x_statement_id := 30;
INSERT INTO cec_ipc_transactions
(ec_header_id, version, status_code, operation_code,
load_code, change_query_date, change_submit_date,
change_complete_date, erp_header_id, error_message,
order_id, original_order_id, org_id, order_source,
creation_date)
SELECT cec_headers_s.NEXTVAL, p_version, x_transaction_type,
DECODE (
p_version,
NULL, 'INSERT',
1, 'INSERT',
DECODE (p_cancel_flag, 'Y', 'CANCEL', 'UPDATE')
'ELECTRONIC_COMMERCE',
DECODE (
x_transaction_type,
cec_globals_pk.coe_queried, SYSDATE,
NULL
DECODE (
x_transaction_type,
cec_globals_pk.coe_submitted, SYSDATE,
cec_globals_pk.coe_print_and_tear, SYSDATE,
NULL
DECODE (
x_transaction_type,
cec_globals_pk.coe_manual_rlse, SYSDATE,
cec_globals_pk.coe_aborted, SYSDATE,
cec_globals_pk.coe_expired, SYSDATE,
cec_globals_pk.coe_ec_applied, SYSDATE,
NULL
x_header_id, x_error_message, p_order_id,
p_original_order_id, x_org_id, p_order_source, SYSDATE
FROM DUAL;
-- Since we bump the version of the change hold, we want to send
-- all previous print and tear versions to manually released as well
ELSIF x_transaction_type = cec_globals_pk.coe_manual_rlse
THEN
UPDATE cec_ipc_transactions
SET status_code = x_transaction_type,
change_complete_date = SYSDATE
WHERE status_code
|| '' IN (cec_globals_pk.coe_print_and_tear,
cec_globals_pk.coe_queried
AND ( erp_header_id = x_header_id
OR original_order_id = p_original_order_id
AND NVL (version, 1) < NVL (p_version, 1);
-- Fix incident 3241
ELSIF x_transaction_type = cec_globals_pk.coe_aborted
THEN
UPDATE cec_ipc_transactions
SET status_code = x_transaction_type,
change_complete_date = SYSDATE
WHERE status_code
|| '' IN (cec_globals_pk.coe_queried)
AND ( erp_header_id = x_header_id
OR ( original_order_id = p_original_order_id
AND order_source <> 'ALL'
AND NVL (version, 1) < NVL (p_version, 1);
-- Fixed incident 2771
ELSIF x_transaction_type = cec_globals_pk.coe_submitted
THEN
UPDATE cec_ipc_transactions
SET status_code = cec_globals_pk.coe_expired,
change_complete_date = SYSDATE
WHERE status_code
|| '' IN (cec_globals_pk.coe_queried)
AND ( erp_header_id = x_header_id
OR ( original_order_id = p_original_order_id
AND order_source <> 'ALL'
AND NVL (version, 1) < NVL (p_version, 1);
END IF;
END IF;
p_success := TRUE;
p_error_message := x_error_message;
cec_debug_pk.DEBUG ('End CEC_IPC_TRANSACTIONS_API.log');
EXCEPTION
WHEN OTHERS
THEN
p_success := FALSE;
cec_debug_pk.get_error (
'GENERIC_SQL_ERROR',
x_error_message,
x_task_id
cec_debug_pk.set_token (
x_error_message,
'PROCEDURE_NAME',
'CEC_IPC_TRANSACTIONS_API.log'
cec_debug_pk.set_token (
x_error_message,
'STATEMENT_ID',
TO_CHAR (x_statement_id)
cec_debug_pk.set_token (x_error_message, 'SQLCODE', SQLCODE);
cec_debug_pk.set_token (x_error_message, 'SQLERRM', SQLERRM);
p_error_message := x_error_message;
END LOG;
END cec_ipc_transactions_api;
/

Answer 1

  CURSOR lock_header (p_header_id NUMBER) IS
    SELECT ooha.header_id header_id
      FROM oe_order_headers_all ooha, xxcca_oe_order_headers_ext xoohe
     WHERE ooha.header_id = p_header_id
       AND ooha.header_id = xoohe.header_id
       AND NVL (xoohe.cms_customer_version, -999) < p_version
       AND ooha.open_flag|| '' = 'Y'
    FOR UPDATE OF xoohe.cms_customer_version NOWAIT;i'm not sure why you had this predicate in your where clause of your cursor:
           AND ooha.open_flag|| '' = 'Y'when you can simply
           AND ooha.open_flag = 'Y'
or
           AND Nvl(ooha.open_flag,'X') = 'Y'also you only had one loop structures which is to update and not insert. could it be that the procedure log is being called out from other pl/sql within it's loop structure that cause duplication in inserts.