Comment on my use of try / catch / finally

Question

Below is a code fragment from an application I'm working on. I have a couple questions about it. Is the way that I'm using "finally" correct? It's supposed to make sure the Connection gets closed. Note that I have a separate class close the Connection.
(ConnectionFactory is a class I wrote so I don't have to write the DB connection code over and over.)
        Connection con = null;
        try
            con = ConnectionFactory.getPooledConnection(Constants.JNDI_DS_NAME_LOCAL);
            Statement stmt = con.createStatement();
            stmt.executeUpdate("DELETE FROM person WHERE ID='" + personFormBean.getID() + "'");
        } catch (SQLException e)
            System.out.println(e.getMessage());
            e.printStackTrace();
        } finally
            ConnectionFactory.close(con);
        }Here's how I close the Connection:
    public static void close(Connection con)
        try
            if (con != null && !con.isClosed())
                con.close();
        } catch (SQLException e)
            System.out.println(e.getMessage());
            e.printStackTrace();
    }My other question is about the code in the catch block. Is there anything different that should be done in the catch block?

Answer 1

Below is a code fragment from an application I'm
working on. I have a couple questions about it. Is
the way that I'm using "finally" correct? It's
supposed to make sure the Connection gets closed.
Note that I have a separate class close the
Connection.Excellent. I do this, too. (First person I had suggest it was jverd on this forum.)
>
(ConnectionFactory is a class I wrote so I don't have
to write the DB connection code over and over.)
        Connection con = null;
try
con =
con =
con =
ConnectionFactory.getPooledConnection(Constants.JNDI_D
S_NAME_LOCAL);
Statement stmt = con.createStatement();
stmt.executeUpdate("DELETE FROM person
FROM person WHERE ID='" + personFormBean.getID() +
} catch (SQLException e)
System.out.println(e.getMessage());
e.printStackTrace();
} finally
ConnectionFactory.close(con);
}Here's how I close the Connection:
    public static void close(Connection con)
try
if (con != null && !con.isClosed())
con.close();
} catch (SQLException e)
System.out.println(e.getMessage());
e.printStackTrace();
}My other question is about the code in the catch
block. Is there anything different that should be
done in the catch block?Looks fine. I'd recommend that you add methods to explicitly close Statement and ResultSet, too. Call the method to close statement in the finally block before you close the Connection.
I think logging the stack trace is the best thing to do. Printing the stack trace is okay, as long as someone can actually SEE the System.out stream. I think printing the message is a waste.
Do you want commit/rollback logic for the DELETE?
I'd pass the Connection into the method so it can participate in a unit of work. I don't have SQL methods get their own statement. Let the caller be responsible for obtaining and closing the Connection.
CRUD operations in DAO is a nice pattern. I commend it to you.
You do a lot right here, but I think it's possible to do better still.
%