Compilation error in procedure

Question

P_start_date and p_end_date is input to the procedure
it is giving execution error.
v_sql := 'SELECT
     as_no ,
     l_no ,
     dtc_no ,
     reg_date ,
     card_no ,
     last_name ,
     no_mail ,
     no_call      
FROM registration@' ||p_db_link || ' a
WHERE a.first_name IS NOT NULL
AND a.datestamp = (SELECT max(b.datestamp) FROM registration@' ||p_db_link || ' b
WHERE a.card_no = b.card_no)
AND TO_DATE(a.reg_date,''dd-mon-yy'') BETWEEN ' || p_start_date || ' AND ' || p_end_date ;
========= Here is the sql while executing...
SELECT
as_no ,
l_no ,
dtc_no
reg_date ,
card_no ,
last_name
first_name ,
zip_code ,
start_weight
goal_weight ,
mbrship_status ,
weeks_completed ,
height
previous_wt ,
previous_date ,
datestamp ,
notes
modified_date ,
old_style_reg_no ,
lifetime_no
miss_you_sent ,
miss_you_datestamp ,
address ,
city
state ,
phone ,
phone_type ,
email
memo ,
sex ,
birth_date
age_range ,
no_mail ,
no_call
FROM
registration@link_champ a
WHERE a.first_name IS NOT NULL
AND a.datestamp =
(SELECT max(b.datestamp) FROM registration@link_champ b
WHERE a.card_no = b.card_no)
AND TO_DATE(a.reg_date,'dd-mon-yy') BETWEEN
10-MAR-06 AND 11-MAR-06
ErrorORA-00904: "MAR": invalid identifier
ORA-Error in fetching the cursor values
PL/SQL procedure successfully completed.

Answer 1

they are date type
I modifed the query and it is working fine now, but it is still taking lots of time...
Here is what i changed the procedure....
I have used the bulk collect here, but still there is no big performance improvement..
CREATE OR REPLACE PACKAGE BODY pkg_merge_member_info IS
PROCEDURE p_merge_member_info(p_db_link in VARCHAR2, p_start_date in date, p_end_date in date) IS
generic_cv sys_refcursor;
generic_cv2 sys_refcursor;
generic_cv3 sys_refcursor;
v_rcw_card_no varchar2(20);
v_pmi_inactive_date date;
v_pmi_inactive_reason varchar2(50);
v_ccw_last_meeting date;
type     tbl_as_no           is table of      NUMBER(8)     INDEX BY BINARY_INTEGER;
type     tbl_l_no           is table of      NUMBER(8)     INDEX BY BINARY_INTEGER;
type     tbl_dtc_no           is table of      NUMBER(8)     INDEX BY BINARY_INTEGER;
type     tbl_reg_date           is table of      DATE     INDEX BY BINARY_INTEGER;
type     tbl_card_no           is table of      VARCHAR2(20)     INDEX BY BINARY_INTEGER;
type     tbl_last_name           is table of      VARCHAR2(32)     INDEX BY BINARY_INTEGER;
type     tbl_first_name           is table of      VARCHAR2(32)     INDEX BY BINARY_INTEGER;
type     tbl_zip_code           is table of      CHAR(5)     INDEX BY BINARY_INTEGER;
type     tbl_start_weight           is table of      NUMBER(8,2)     INDEX BY BINARY_INTEGER;
type     tbl_goal_weight           is table of      NUMBER(8,2)     INDEX BY BINARY_INTEGER;
type     tbl_mbrship_status           is table of      VARCHAR2(32)     INDEX BY BINARY_INTEGER;
type     tbl_weeks_completed           is table of      NUMBER(8)     INDEX BY BINARY_INTEGER;
type     tbl_height           is table of      NUMBER(8,2)     INDEX BY BINARY_INTEGER;
type     tbl_previous_wt           is table of      NUMBER(8,2)     INDEX BY BINARY_INTEGER;
type     tbl_previous_date           is table of      DATE     INDEX BY BINARY_INTEGER;
type     tbl_datestamp           is table of      DATE     INDEX BY BINARY_INTEGER;
type     tbl_notes           is table of      VARCHAR2(128)     INDEX BY BINARY_INTEGER;
type     tbl_modified_date           is table of      DATE     INDEX BY BINARY_INTEGER;
type     tbl_old_style_reg_no           is table of      VARCHAR2(32)     INDEX BY BINARY_INTEGER;
type     tbl_lifetime_no           is table of      VARCHAR2(32)     INDEX BY BINARY_INTEGER;
type     tbl_miss_you_sent           is table of      CHAR(1)     INDEX BY BINARY_INTEGER;
type     tbl_miss_you_datestamp           is table of      DATE     INDEX BY BINARY_INTEGER;
type     tbl_address           is table of      VARCHAR2(64)     INDEX BY BINARY_INTEGER;
type     tbl_city           is table of      VARCHAR2(32)     INDEX BY BINARY_INTEGER;
type     tbl_state           is table of      CHAR(2)     INDEX BY BINARY_INTEGER;
type     tbl_phone           is table of      VARCHAR2(16)     INDEX BY BINARY_INTEGER;
type     tbl_phone_type           is table of      VARCHAR2(4)     INDEX BY BINARY_INTEGER;
type     tbl_email           is table of      VARCHAR2(64)     INDEX BY BINARY_INTEGER;
type     tbl_memo           is table of      VARCHAR2(192)     INDEX BY BINARY_INTEGER;
type     tbl_sex           is table of      CHAR(1)     INDEX BY BINARY_INTEGER;
type     tbl_birth_date           is table of      DATE     INDEX BY BINARY_INTEGER;
type     tbl_age_range           is table of      VARCHAR2(8)     INDEX BY BINARY_INTEGER;
type     tbl_no_mail           is table of      CHAR(1)     INDEX BY BINARY_INTEGER;
type     tbl_no_call           is table of      CHAR(1)      INDEX BY BINARY_INTEGER;
v_AS_NO tbl_as_no      ;
v_L_NO tbl_l_no      ;
v_DTC_NO tbl_dtc_no      ;
v_REG_DATE tbl_reg_date      ;
v_CARD_NO tbl_card_no      ;
v_LAST_NAME tbl_last_name      ;
v_FIRST_NAME tbl_first_name      ;
v_ZIP_CODE tbl_zip_code ;      
v_START_WEIGHT tbl_start_weight ;      
v_GOAL_WEIGHT tbl_goal_weight ;     
v_MBRSHIP_STATUS tbl_mbrship_status ;     
v_WEEKS_COMPLETED tbl_weeks_completed ;     
v_HEIGHT tbl_height ;     
v_PREVIOUS_WT tbl_previous_wt ;     
v_PREVIOUS_DATE tbl_previous_date ;     
v_DATESTAMP tbl_datestamp ;     
v_NOTES tbl_notes ;     
v_MODIFIED_DATE tbl_modified_date ;     
v_OLD_STYLE_REG_NO tbl_old_style_reg_no ;     
v_LIFETIME_NO tbl_lifetime_no ;     
v_MISS_YOU_SENT tbl_miss_you_sent ;     
v_MISS_YOU_DATESTAMP tbl_miss_you_datestamp ;     
v_ADDRESS tbl_address ;     
v_CITY tbl_city ;     
v_STATE tbl_state ;     
v_PHONE tbl_phone ;     
v_PHONE_TYPE tbl_phone_type ;     
v_EMAIL tbl_email ;     
v_MEMO tbl_memo ;     
v_SEX tbl_sex ;     
v_BIRTH_DATE tbl_birth_date ;     
v_AGE_RANGE tbl_age_range ;     
v_NO_MAIL tbl_no_mail ;     
v_NO_CALL tbl_no_call ;     
o_error_Text VARCHAR2(1000);
v_sql_err VARCHAR2(4000);
tname VARCHAR2(32);
o_status VARCHAR2(10);
--v_schema_name                              VARCHAR2(100):=p_schema_name||'.';
v_last_upd_by VARCHAR2(20) :='Apollo Data Refresh';
v_created_by VARCHAR2(20) :='Apollo Data Refresh';
v_user_check_id NUMBER(10);
v_hire_date DATE;
v_fjc_no VARCHAR2(1);
v_sql VARCHAR2(4000);
v_emp_check NUMBER(1) := 0;
v_user_id NUMBER(10);
v_state_id NUMBER(10);
v_ejc_date_last_worked      DATE;
v_member_id NUMBER(10);
v_MEMBER_TYPE_ID NUMBER(10);
BEGIN
v_sql := 'SELECT
     as_no ,
     l_no ,
     dtc_no ,
     reg_date ,
     card_no ,
     last_name ,
     first_name ,
     zip_code ,
     start_weight ,
     goal_weight ,
     mbrship_status ,
     weeks_completed ,
     height ,
     previous_wt ,
     previous_date ,
     datestamp ,
     notes ,
     modified_date ,
     old_style_reg_no ,
     lifetime_no ,
     miss_you_sent ,
     miss_you_datestamp ,
     address ,
     city ,
     state ,
     phone ,
     phone_type ,
     email ,
     memo ,
     sex ,
     birth_date ,
     age_range ,
     no_mail ,
     no_call      
FROM registration@' ||p_db_link || ' a
WHERE a.first_name IS NOT NULL
AND a.datestamp = (SELECT max(b.datestamp) FROM registration@' ||p_db_link || ' b
WHERE a.card_no = b.card_no)
AND TO_DATE(a.reg_date,''dd-mon-yy'') BETWEEN ''' || p_start_date || ''' and ''' || p_end_date ||'''' ;
--AND  TO_DATE(a.reg_date,''dd-mon-yy'') BETWEEN   p_start_date and p_end_date  ' ;
--USING  p_start_date, p_end_date    ;
o_Error_Text := 'ORA-Error in fetching the cursor values ';
tname:= NULL;
dbms_output.put_line(v_sql);
execute immediate v_sql bulk collect into
     v_as_no ,
     v_l_no ,
     v_dtc_no ,
     v_reg_date ,
     v_card_no ,
     v_last_name ,      
     v_first_name ,
     v_zip_code ,
     v_start_weight ,
     v_goal_weight ,
     v_mbrship_status ,
     v_weeks_completed ,
     v_height ,
     v_previous_wt ,
     v_previous_date ,
     v_datestamp ,
     v_notes ,
     v_modified_date ,
     v_old_style_reg_no ,
     v_lifetime_no ,
     v_miss_you_sent ,
     v_miss_you_datestamp ,
     v_address ,
     v_city ,
     v_state ,
     v_phone ,
     v_phone_type ,
     v_email ,
     v_memo ,
     v_sex ,
     v_birth_date ,
     v_age_range ,
     v_no_mail ,
     v_no_call ;
FOR i IN v_card_no.FIRST..v_card_no.LAST
LOOP
o_Error_Text := 'ORA-Error in getting member id for the card no';
tname:= 'members';
     SELECT count(1) INTO v_emp_check
     FROM members
     WHERE champ_code=v_CARD_NO(i);
IF v_emp_check = 0 THEN
o_Error_Text := 'ORA-Error in executing sequence seq_user_id';
tname:= NULL;
SELECT user_id_seq.nextval INTO v_user_id FROM dual;
o_Error_Text := 'ORA-Error in INSERTing to users table';
tname:= 'Users';
     INSERT INTO users
     ( user_id ,
          user_type_id ,
          first_name ,
          last_name ,
          mid_name ,
          gender ,
          date_of_birth ,
          notes ,
          site_id ,
          created_date ,
          created_by ,
          last_upd_date ,
          last_upd_by
     VALUES
     ( v_user_id ,
          2 , -- Member type
          v_first_name(i),
          v_last_name(i) ,
          null , -- mid name
          v_sex(i) , -- gender
          v_birth_date(i) ,
          v_notes(i) ,
          1 , -- site id
          pkg_utilities.fn_sysdate(1) , -- Created Dt
          v_created_by , -- Created by
          pkg_utilities.fn_sysdate(1) , -- Modified Dt
          v_last_upd_by -- Modified by
end if;
dbms_output.put_line(i);
end loop;
EXCEPTION
WHEN OTHERS THEN
DBMS_OUTPUT.PUT_LINE('Error' ||sqlerrm);
DBMS_OUTPUT.PUT_LINE(o_error_text);
v_sql_err :=SQLERRM;
ROLLBACK;
pkg_champ_message_log.champ_message_log ('pkg_merge_employee_info.p_merge_employee_info', tname, null,'Apollo', v_sql_err,'Error',o_Error_Text,O_STATUS);
end;
END PKG_MERGE_member_INFO;
/