Cursor not working properly.. Gives every record last records' entry.

Question

hi all.
a simple one for someone I'm sure...
Ive just added the cursor:
-- Cursor to get Oracle_Loc_Code from SU CHRIS vs ORACLE Locations Table into a variable..
     CURSOR csr_ora_loc_code IS
     SELECT sil.ORACLE_LOC_CODE
     FROM SU_TEMPLOYEE_DETAILS std, SU_IEXP_LOCATIONS sil
     WHERE std.STD_LOCATION_ID = sil.CHRIS_LOC_code;
..to the script I'll paste below in order to populate every record with whats in sil.ORACLE_LOC_CODE field.
But, although it works fine when you have 1 record to run in, when several records are to be loaded in together, the script, although enters the records into ORACLE fine, populates every record with the same location code - whatevers in the last record (instead of treating each one individually). How can I fix this?
Thanks for looking..
The code..
/* Formatted on 2009/04/29 11:52 (Formatter Plus v4.8.7) */
SET serveroutput ON SIZE 1000000 FORMAT WRAPPED
SET verify OFF
SET feedback OFF
DECLARE
-- Debugging/error handling
-- Work variables
   ora_loc_code number                     := 0;
   p_emp_number                     VARCHAR2 (14);
   v_rec_cnt                        NUMBER                          := 0;
   insert_flag                      VARCHAR2 (8);
   err_num                          NUMBER;
   err_msg                          VARCHAR2 (150);
   err_line                         VARCHAR2 (350);
   err_seq                          NUMBER                          := 0;
   l_validate                       BOOLEAN                     DEFAULT FALSE;
   l_std_business_group_id          NUMBER                          := '0';
   l_default_code_comb_id           NUMBER                        := '217269';
   l_organization_id                NUMBER                          := '0';
   l_set_of_books_id                NUMBER                          := '1';
   l_job_id                         NUMBER                          := '10';
   l_obj                            NUMBER;
   l_datetrack_update_mode          VARCHAR2 (30)             := 'CORRECTION';
   l_assignment_sequence            NUMBER;
   l_name_combination_warning       BOOLEAN                         := FALSE;
   l_assign_payroll_warning         BOOLEAN                         := FALSE;
   l_org_now_no_manager_warning     BOOLEAN;
   l_other_manager_warning          BOOLEAN;
   l_spp_delete_warning             BOOLEAN;
   l_entries_changed_warning        VARCHAR2 (30);
   l_tax_district_changed_warning   BOOLEAN;
   l_person_id                      NUMBER;
   l_assignment_id                  NUMBER;
   l_special_ceiling_step_id        NUMBER;
   l_per_effective_end_date         DATE:= TO_DATE ('11-Jul-2049', 'DD-MON-YYYY');
   l_people_group_id                NUMBER;
   l_group_name                     VARCHAR2 (30);
   l_assignment_number              VARCHAR2 (35);
   l_effective_end_date             DATE := TO_DATE ('11-Jul-2049', 'DD-MON-YYYY');
   l_date                           DATE                           := SYSDATE;
   ip_p_address_id                  per_addresses.address_id%TYPE;
   ip_p_object_version_number       NUMBER;
   ip_p_party_id                    per_addresses.party_id%TYPE;
   l_per_object_version_number      NUMBER;
   l_asg_object_version_number      NUMBER;
   l_full_name                      VARCHAR2 (240);
   l_per_comment_id                 NUMBER;
   l_per_effective_start_date       DATE;
   l_concatenated_segments          VARCHAR2 (240);
   l_soft_coding_keyflex_id         NUMBER;
   l_comment_id                     NUMBER;
   l_no_managers_warning            BOOLEAN;
-- Get employee details info from work table
   CURSOR get_employee_details
   IS
      SELECT std_hire_date, std_last_name, std_sex, std_date_of_birth,
             std_email_address,
             LPAD (std_employee_number, 8, '0') std_employee_number,
             std_first_name, std_marital_status, std_middle_names,
             std_nationality, std_title, std_national_identifier,
             std_address_line1, std_address_line2, std_address_line3,
             std_address_line4, std_post_code, std_telephone_1, std_country,
             std_region, std_location_id, std_organization_id,
             std_supervisor_id, std_person_id, std_position_id
        FROM SU_TEMPLOYEE_DETAILS;
-- checks employee details info from PER_ALL_PEOPLE_F table
   CURSOR c_check_employee (p_emp_number VARCHAR2)
   IS
      SELECT per.person_id, per.business_group_id, per.last_name,
             per.start_date, per.date_of_birth, per.email_address,
             per.employee_number, per.first_name, per.marital_status,
             per.middle_names, per.nationality, per.national_identifier,
             per.sex, per.title, padd.address_id, padd.primary_flag,
             padd.address_line1, padd.address_line2, padd.address_line3,
             padd.town_or_city, padd.postal_code, padd.telephone_number_1,
             paas.assignment_number, paas.object_version_number
        --  padd.telephone_number_2, padd.telephone_number_3, paas.job_id, paas.location_id,
        --  paas.organization_id, paas.assignment_type, paas.supervisor_id,
        --  paas.default_code_comb_id, paas.set_of_books_id, paas.period_of_service_id,
      FROM   per_all_people_f per,
             per_all_assignments_f paas,
             per_addresses padd
       WHERE per.employee_number = p_emp_number
         AND per.person_id = padd.person_id
         AND paas.person_id(+) = per.person_id;
   emp_rec                          c_check_employee%ROWTYPE;
-- Cursor retrieves latest Object Version Number from per_assignments_f table..
   CURSOR csr_ovn (cp_person_id IN per_all_people_f.person_id%TYPE)
   IS
      SELECT MAX (paas.object_version_number)
        FROM per_assignments_f paas, per_all_people_f per
       WHERE paas.person_id = per.person_id
         AND per.employee_number = paas.assignment_number
         AND per.person_id = cp_person_id;
-- Cursor to get Oracle_Loc_Code from SU CHRIS vs ORACLE Locations Table into a variable..
     CURSOR csr_ora_loc_code IS
      SELECT sil.ORACLE_LOC_CODE
     -- INTO ora_loc_code
     FROM SU_TEMPLOYEE_DETAILS std, SU_IEXP_LOCATIONS sil
     WHERE std.STD_LOCATION_ID = sil.CHRIS_LOC_code;
BEGIN
-- Process each record in the work table
   FOR v_emp IN get_employee_details
   LOOP
-- determine whether customer already exists
      OPEN c_check_employee (v_emp.std_employee_number);
      FETCH c_check_employee
       INTO emp_rec;
      IF c_check_employee%NOTFOUND
      THEN
         insert_flag := 'I';
         DBMS_OUTPUT.PUT_LINE ('Employee No: ' || v_emp.std_employee_number);
      ELSE
         DBMS_OUTPUT.PUT (CHR (10));
         insert_flag := 'X';
       RAISE_APPLICATION_ERROR (-20001,  'Employee No: ' || v_emp.std_employee_number  || '  already
exists - please  UPDATE  manually..'    );
       END IF;
      CLOSE c_check_employee;
-- Obtain the most recent Object Version Number..
      OPEN csr_ovn (v_emp.std_person_id);
      FETCH csr_ovn
       INTO l_obj;
      -- IF csr_ovn%NOTFOUND     THEN        RAISE NO_DATA_FOUND;   END IF;
      CLOSE csr_ovn;
-- Open Oracle Location Code cursor
      OPEN csr_ora_loc_code;   -- (v_emp.std_person_id);
      FETCH csr_ora_loc_code
       INTO ora_loc_code;
      CLOSE csr_ora_loc_code;
-- Create new PER_ALL_PEOPLE_F and PER_ADDRESSES record from
--            info in  table record
      IF insert_flag = 'I'
      THEN
--         BEGIN                             -- Importing Employee Procedure --
         Hr_Employee_Api.create_gb_employee
                 (p_validate                       => l_validate,
                  p_hire_date                      => v_emp.std_hire_date,
                  p_business_group_id              => l_std_business_group_id,
                  p_date_of_birth                  => v_emp.std_date_of_birth,
                  p_email_address                  => v_emp.std_email_address,
                  p_first_name                     => v_emp.std_first_name,
                  p_middle_names                   => v_emp.std_middle_names,
                  p_last_name                      => v_emp.std_last_name,
                  p_sex                            => v_emp.std_sex,
                  p_ni_number                      => v_emp.std_national_identifier,
                  p_employee_number                => v_emp.std_employee_number,
                  p_person_id                      => l_person_id,
                  p_title                          => v_emp.std_title,
                  p_assignment_id                  => l_assignment_id,
                  p_per_object_version_number      => l_per_object_version_number,
                  p_asg_object_version_number      => l_asg_object_version_number,
                  p_per_effective_start_date       => l_per_effective_start_date,
                  p_per_effective_end_date         => l_per_effective_end_date,
                  p_full_name                      => l_full_name,
                  p_per_comment_id                 => l_per_comment_id,
                  p_assignment_sequence            => l_assignment_sequence,
                  p_assignment_number              => l_assignment_number,
                  p_name_combination_warning       => l_name_combination_warning,
                  p_assign_payroll_warning         => l_assign_payroll_warning
         Hr_Person_Address_Api.create_person_address
                                  (p_validate                     => l_validate,
                                   p_effective_date               => v_emp.std_hire_date,
                                   p_pradd_ovlapval_override      => NULL,
                                   p_validate_county              => NULL,
                                   p_person_id                    => l_person_id,
                                   p_primary_flag                 => 'Y',
                                   p_style                        => 'GB_GLB',
                                   p_date_from                    => SYSDATE,
                                   p_date_to                      => NULL,
                                   p_address_type                 => NULL,
                                   p_comments                     => NULL,
                                   p_address_line1                => v_emp.std_address_line1,
                                   p_address_line2                => v_emp.std_address_line2,
                                   p_address_line3                => v_emp.std_address_line3,
                                   p_town_or_city                 => v_emp.std_address_line4,
                                   p_region_1                     => NULL,
                                   p_region_2                     => NULL,
                                   p_region_3                     => NULL,
                                   p_postal_code                  => v_emp.std_post_code,
                                   p_country                      => v_emp.std_nationality,
                                   p_telephone_number_1           => NULL,
                                   p_telephone_number_2           => NULL,
                                   p_telephone_number_3           => NULL,
                                   p_party_id                     => ip_p_party_id,
                                   p_address_id                   => ip_p_address_id,
                                   p_object_version_number        => l_obj
         Hr_Assignment_Api.update_emp_asg
                        (p_validate                    => l_validate,
                         p_effective_date              => SYSDATE,  -- l_date,
                         p_datetrack_update_mode       => l_datetrack_update_mode,
                         p_assignment_id               => l_assignment_id,
                         p_object_version_number       => l_obj,
                         p_supervisor_id               => v_emp.std_supervisor_id,
                         p_default_code_comb_id        => l_default_code_comb_id,
                         p_set_of_books_id             => l_set_of_books_id,
                         p_concatenated_segments       => l_concatenated_segments,
                         --IN/OUT
                         p_soft_coding_keyflex_id      => l_soft_coding_keyflex_id,
                         --IN/OUT
                         p_comment_id                  => l_comment_id,
                         --IN/OUT
                         p_effective_start_date        => l_date,     --IN/OUT
                         p_effective_end_date          => l_effective_end_date,
                         --IN/OUT
                         p_no_managers_warning         => l_no_managers_warning,
                         --IN/OUT
                         p_other_manager_warning       => l_other_manager_warning
                        --IN/OUT
         Hr_Assignment_Api.update_emp_asg_criteria
             (p_validate                          => l_validate,
              p_effective_date                    => SYSDATE,       -- l_date,
              p_datetrack_update_mode             => l_datetrack_update_mode,
              p_assignment_id                     => l_assignment_id,
              p_object_version_number             => l_obj,
              p_organization_id                   => l_organization_id,
              p_location_id                       => ora_loc_code,
              p_job_id                            => l_job_id,
              p_position_id                       => v_emp.std_position_id,
              p_special_ceiling_step_id           => l_special_ceiling_step_id,
              p_effective_start_date              => l_date,
              --per_effective_start_date,
              p_effective_end_date                => l_effective_end_date,
              --IN/OUT
              p_people_group_id                   => l_people_group_id,
              --IN/OUT
              p_group_name                        => l_group_name,    --IN/OUT
              p_org_now_no_manager_warning        => l_org_now_no_manager_warning,
              --IN/OUT
              p_other_manager_warning             => l_other_manager_warning,
              --IN/OUT
              p_spp_delete_warning                => l_spp_delete_warning,
              --IN/OUT
              p_entries_changed_warning           => l_entries_changed_warning,
              --IN/OUT
              p_tax_district_changed_warning      => l_tax_district_changed_warning
             --IN/OUT
         v_rec_cnt := v_rec_cnt + 1;
         DBMS_OUTPUT.PUT (CHR (10));
         DBMS_OUTPUT.PUT_LINE (   'There were '
                               || v_rec_cnt
                               || '  records read in..'
         DBMS_OUTPUT.PUT (CHR (10));
-- End of customer related details
      END IF;
   END LOOP;
   COMMIT;
EXCEPTION
   WHEN NO_DATA_FOUND
   THEN
      ROLLBACK;
   WHEN OTHERS
   THEN
      ROLLBACK;
      err_num := TO_CHAR (SQLCODE);
      err_msg := SUBSTR (SQLERRM, 1, 150);
      err_line :=   'ORACLE error occurred processing record.. ' ||  err_msg;
      DBMS_OUTPUT.PUT_LINE (err_line);
      INSERT INTO SU_SL_ERRORS  VALUES (err_num, err_msg, SYSTIMESTAMP);
END;
EXIT;

Answer 1

     CURSOR csr_ora_loc_code IS     SELECT sil.ORACLE_LOC_CODE
     -- INTO ora_loc_code
     FROM SU_TEMPLOYEE_DETAILS std, SU_IEXP_LOCATIONS sil
     WHERE std.STD_LOCATION_ID = sil.CHRIS_LOC_code; OPEN csr_ora_loc_code; -- (v_emp.std_person_id);
FETCH csr_ora_loc_code
INTO ora_loc_code;
CLOSE csr_ora_loc_code;Obviously yes.It will select one sil.ORACLE_LOC_CODE, as you are fetching one. That can be any one of the sil.ORACLE_LOC_CODE, as you didn't tell Oracle to pick a particular one.
If you want to get some particular sil.ORACLE_LOC_CODE, you need to put some filter on that.     CURSOR csr_ora_loc_code(p_your_parameter NUMBER) IS -- whatever datatype you wan to pass
      SELECT sil.ORACLE_LOC_CODE
     -- INTO ora_loc_code
     FROM SU_TEMPLOYEE_DETAILS std, SU_IEXP_LOCATIONS sil
     WHERE std.STD_LOCATION_ID = sil.CHRIS_LOC_code
     AND your_column = p_your_parameter;
      OPEN csr_ora_loc_code(v_emp.std_person_id);   -- (v_emp.std_person_id); -- I'm not sure why did you comment this out.
      FETCH csr_ora_loc_code
       INTO ora_loc_code;
      CLOSE csr_ora_loc_code;By
Vamsi