Do I use an IN OUT parameter procedure or what?

Question

Hi,
I believe my logic is fine but my syntax and knowing when to use what smacks me.
I have 2 tables CLASSIFICATION and EMPLOYEE in a 1:M relationship.
Now I have to use a value in CLASSIFICATION called CLASSIFICATION.YEARLY_PAY to update my EMPLOYEE.PRO_RATA column in my EMPLOYEE table and I got stuck
See below:
CREATE TABLE CLASSIFICATION(
CLASS_ID VARCHAR2(6) NOT NULL,
CLASS_TYPE VARCHAR2(10),
DESCRIPTION VARCHAR2(30) NOT NULL,
YEARLY_PAY NUMBER(8),
HOURLY_RATE NUMBER,
WEEKDAY_OVER_TIME NUMBER,
WEEKEND_OVER_TIME NUMBER,
CONSTRAINT PK_CLASS_ID PRIMARY KEY (CLASS_ID));
INSERT INTO CLASSIFICATION VALUES('PR1','PERMANENT','MANAGER',45000,'','',NULL);
INSERT INTO CLASSIFICATION VALUES('PR2','PERMANENT','ADMIN ASSISTANT',22000,'',1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('PR3','PERMANENT','CONTROLLER',32000,'',1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('PR4','PERMANENT','CASH OFFICER',22000,'',1.5,NULL;
INSERT INTO CLASSIFICATION VALUES('PR5','PERMANENT','CLEANERS',16000,'',1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('PR6','PERMANENT','ADMIN OFFICER',22000,'',1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('PR7','PERMANENT','WAREHOUSE ATTENDANT',20000,''1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('PR8','PERMANENT','WINDOWS DRESSER',22000,'',1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('PR9','PERMANENT','DIRECTOR',60000,'','',NULL);
INSERT INTO CLASSIFICATION VALUES('PR10','PERMANENT','DEPUTY DIRECTOR',52000,'','',NULL);
INSERT INTO CLASSIFICATION VALUES('PR11','PERMANENT','SALES ASSISTANT',21000,'',1.5,NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP2','TEMP STAFF','ADMIN ASSISTANT','',16.50,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP3','TEMP STAFF','CONTROLLER','',29.00,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP4','TEMP STAFF','CASH OFFICER','',19.00,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP5','TEMP STAFF','CLEANERS','',10.00,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP6','TEMP STAFF','ADMIN OFFICER','',20.00,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP7','TEMP STAFF','WAREHOUSE ATTENDANT','',18.00,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP8','TEMP STAFF','WINDOWS DRESSER','',18.50,'',NULL);
INSERT INTO CLASSIFICATION VALUES('TEMP11','TEMP STAFF','SALES ASSISTANT','',16.00,'',NULL);
CREATE TABLE EMPLOYEE(
EMPID NUMBER(5) NOT NULL,
SURNAME VARCHAR2(30) NOT NULL,
FNAME VARCHAR2(30) NOT NULL,
GENDER CHAR(1) NOT NULL,
DOB DATE NOT NULL,
EMP_TYPE VARCHAR2(20) NOT NULL,
PRO_RATA_WAGES NUMBER(7,2),
ANNUAL_WEEKS_REQD NUMBER(2),
HOLIDAY_ENTLMENT NUMBER(2),
SICK_LEAVE_ENTLMENT NUMBER(2),
HIRE_DATE DATE NOT NULL,
END_DATE DATE,
ACCNO NUMBER(8) NOT NULL,
BANKNAME VARCHAR2(20) NOT NULL,
BRANCH VARCHAR2(20) NOT NULL,
ACCOUNTNAME VARCHAR2(20),
CLASS_ID VARCHAR2(6),
CONSTRAINT CK_HIRE_END CHECK (HIRE_DATE < END_DATE),
CONSTRAINT CK_HIRE_DOB CHECK (HIRE_DATE >= ADD_MONTHS(DOB, 12 * 18)),
CONSTRAINT CK_EMP_TYPE CHECK (EMP_TYPE IN ('FT','PT1','PT2','PT3','HOURLY')),
CONSTRAINT CK_EMP_GENDER CHECK (GENDER IN ('M','F')),
CONSTRAINT FK_EMP_CLASS FOREIGN KEY (CLASS_ID) REFERENCES CLASSIFICATION(CLASS_ID),
CONSTRAINT PK_EMP PRIMARY KEY (EMPID));
INSERT INTO EMPLOYEE VALUES(
SEQ_EMPID.NEXTVAL,'RICHARD','BRANDON','M','25-DEC-1966','FT',22000.00,52,28,14,'10-JAN-2005',NULL,90823227,'NATWEST','BROMLEY','DEPOSIT','PR2');
--record that needs updating to
INSERT INTO EMPLOYEE VALUES(
SEQ_EMPID.NEXTVAL,'BOYCE','CODD','M','15-JAN-1972','PT1','',39,'','','12-JAN-2005',NULL,72444091,'LLOYDS','KENT','CURRENT','PR8');
CREATE SEQUENCE SEQ_EMPID START WITH 1;
==========================================================
SQL> BEGIN
2 v_EMPID NUMBER(5);
3 V_CLASS_ID VARCHAR2(6);
4 V_YEARLY_PAY NUMBER(8);
5 SELECT SEQ_EMPID.CURRVAL INTO V_EMPID FROM DUAL;
6 SELECT b.CLASS_ID, b.YEARLY_PAY INTO V_CLASS_ID, V_YEARLY_PAY FROM CLASSIFICATION b WHERE b.CLA
SS_ID = V_CLASS_ID;
7 IF a.EMP_TYPE ='FT' THEN
8 UPDATE EMPLOYEE a SET a.ANNUAL_WEEKS_REQD = 52, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*52), a.HO
LIDAY_ENTLMENT=28, a.SICK_LEAVE_ENTLMENT = 14 WHERE a.EMPID
9 = V_EMPID;
10 ENDIF;
11 IF EMP_TYPE ='PT1' THEN
12 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 39, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*39), a.HOLIDA
Y_ENTLMENT=21, a.SICK_LEAVE_ENTLMENT = 10.5 WHERE a.EMPID =
13 V_EMPID;
14 ENDIF;
15 IF EMP_TYPE ='PT2' THEN
16 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 26, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*26), a.HOLIDA
Y_ENTLMENT=14, a.SICK_LEAVE_ENTLMENT = 7 WHERE a.EMPID =
17 V_EMPID;
18 ENDIF;
19 IF EMP_TYPE ='PT3' THEN
20 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 13, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*13), a.HOLIDA
Y_ENTLMENT=7, a.SICK_LEAVE_ENTLMENT = 3.5 WHERE a.EMPID =
21 V_EMPID;
22 IF EMP_TYPE ='HOURLY' THEN
23 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = NULL a.PRO_RATA_WAGES = NULL, a.HOLIDAY_ENTLMENT=NULL,
a.SICK_LEAVE_ENTLMENT = NULL WHERE a.EMPID = V_EMPID;
24 ELSE
25 RAISE_APPLICATION_ERROR(12101,'NO MATCHING RECORD EXIST YET');
26 ENDIF;
27 end;
28 /
v_EMPID NUMBER(5);
ERROR at line 2:
ORA-06550: line 2, column 9:
PLS-00103: Encountered the symbol "NUMBER" when expecting one of the following:
:= . ( @ % ;
The symbol ":=" was substituted for "NUMBER" to continue.
ORA-06550: line 3, column 12:
PLS-00103: Encountered the symbol "VARCHAR2" when expecting one of the following:
:= . ( @ % ;
The symbol ":=" was substituted for "VARCHAR2" to continue.
ORA-06550: line 4, column 14:
PLS-00103: Encountered the symbol "NUMBER" when expecting one of the following:
:= . ( @ % ;
The symbol ":=" was substituted for "NUMBER" to continue.
ORA-06550: line 23, column 46:
PLS-00103: Encountered the symbol "A" when expecting one of the following:
, * & - + ; / at mod rem return returning <an exponent (**)>
where ||
The symbol "," was substituted for "A" to continue.
ORA-06550: line 27, column 4:
PLS-00103: Encountered the symbol ";" when expecting one of the following:
if
I tried an anonymous block first but did not work.
And how do i eventually execute this procedure anyway if not using it to update through a data entry form.
Much appreciation in advance
cube60

Answer 1

Hi,
I have a longer code which I cut off at the top.
Anyway after execute your tip, here is the result. It looks alot better
SQL> declare
2 v_EMPID NUMBER(5);
3 V_CLASS_ID VARCHAR2(6);
4 V_YEARLY_PAY NUMBER(8);
5 begin
6 SELECT SEQ_EMPID.CURRVAL INTO V_EMPID FROM DUAL;
7 SELECT b.CLASS_ID, b.YEARLY_PAY INTO V_CLASS_ID, V_YEARLY_PAY FROM CLASSIFICATION b WHERE b.CLA
SS_ID = V_CLASS_ID;
8 IF a.EMP_TYPE ='FT' THEN
9 UPDATE EMPLOYEE a SET a.ANNUAL_WEEKS_REQD = 52, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*52), a.HO
LIDAY_ENTLMENT=28, a.SICK_LEAVE_ENTLMENT = 14 WHERE a.EMPID
10 = V_EMPID;
11 ENDIF;
12 IF EMP_TYPE ='PT1' THEN
13 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 39, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*39), a.HOLIDA
Y_ENTLMENT=21, a.SICK_LEAVE_ENTLMENT = 10.5 WHERE a.EMPID =
14 V_EMPID;
15 ENDIF;
16 IF EMP_TYPE ='PT2' THEN
17 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 26, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*26), a.HOLIDA
Y_ENTLMENT=14, a.SICK_LEAVE_ENTLMENT = 7 WHERE a.EMPID =
18 V_EMPID;
19 ENDIF;
20 IF EMP_TYPE ='PT3' THEN
21 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 13, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*13), a.HOLIDA
Y_ENTLMENT=7, a.SICK_LEAVE_ENTLMENT = 3.5 WHERE a.EMPID =
22 V_EMPID;
23 IF EMP_TYPE ='HOURLY' THEN
24 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = NULL a.PRO_RATA_WAGES = NULL, a.HOLIDAY_ENTLMENT=NULL,
a.SICK_LEAVE_ENTLMENT = NULL WHERE a.EMPID = V_EMPID;
25 ELSE
26 RAISE_APPLICATION_ERROR(12101,'NO MATCHING RECORD EXIST YET');
27 ENDIF;
28 end;
29 /
SELECT b.CLASS_ID, b.YEARLY_PAY INTO V_CLASS_ID, V_YEARLY_PAY FROM CLASSIFICATION b WHERE b.CLASS_ID
ERROR at line 7:
ORA-06550: line 24, column 46:
PL/SQL: ORA-00933: SQL command not properly ended
ORA-06550: line 24, column 1:
PL/SQL: SQL Statement ignored
ORA-06550: line 28, column 4:
PLS-00103: Encountered the symbol ";" when expecting one of the following:
if
This was my original IN OUT parameter procedure
see result below:
SQL> CREATE OR REPLACE PROCEDURE UPDATE_EMPLOYEE(
2 EMPID IN NUMBER,
3 --SURNAME IN VARCHAR2,
4 --FNAME IN VARCHAR2,
5 --GENDER IN CHAR(1),
6 --DOB DATE NOT NULL,
7 EMP_TYPE IN VARCHAR2,
8 PRO_RATA_WAGES OUT NUMBER,
9 ANNUAL_WEEKS_REQD IN NUMBER,
10 HOLIDAY_ENTLMENT IN NUMBER,
11 SICK_LEAVE_ENTLMENT IN NUMBER,
12 HIRE_DATE IN DATE,
13 END_DATE IN DATE,
14 ACCNO IN NUMBER,
15 BANKNAME IN VARCHAR2,
16 BRANCH IN VARCHAR2,
17 ACCOUNTNAME IN VARCHAR2,
18 CLASS_ID IN VARCHAR2)
19 declare
20 v_EMPID NUMBER(5);
21 V_CLASS_ID VARCHAR2(6);
22 V_YEARLY_PAY NUMBER(8);
23 begin
24 SELECT SEQ_EMPID.CURRVAL INTO V_EMPID FROM DUAL;
25 SELECT b.CLASS_ID, b.YEARLY_PAY INTO V_CLASS_ID, V_YEARLY_PAY FROM CLASSIFICATION b WHERE b.CLA
SS_ID = V_CLASS_ID;
26 IF a.EMP_TYPE ='FT' THEN
27 UPDATE EMPLOYEE a SET a.ANNUAL_WEEKS_REQD = 52, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*52), a.HO
LIDAY_ENTLMENT=28, a.SICK_LEAVE_ENTLMENT = 14 WHERE a.EMPID
28 = V_EMPID;
29 ENDIF;
30 IF EMP_TYPE ='PT1' THEN
31 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 39, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*39), a.HOLIDA
Y_ENTLMENT=21, a.SICK_LEAVE_ENTLMENT = 10.5 WHERE a.EMPID =
32 V_EMPID;
33 ENDIF;
34 IF EMP_TYPE ='PT2' THEN
35 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 26, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*26), a.HOLIDA
Y_ENTLMENT=14, a.SICK_LEAVE_ENTLMENT = 7 WHERE a.EMPID =
36 V_EMPID;
37 ENDIF;
38 IF EMP_TYPE ='PT3' THEN
39 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = 13, a.PRO_RATA_WAGES = ((b.YEARLY_PAY/52)*13), a.HOLIDA
Y_ENTLMENT=7, a.SICK_LEAVE_ENTLMENT = 3.5 WHERE a.EMPID =
40 V_EMPID;
41 IF EMP_TYPE ='HOURLY' THEN
42 UPDATE EMPLOYEE SET ANNUAL_WEEKS_REQD = NULL a.PRO_RATA_WAGES = NULL, a.HOLIDAY_ENTLMENT=NULL,
a.SICK_LEAVE_ENTLMENT = NULL WHERE a.EMPID = V_EMPID;
43 ELSE
44 RAISE_APPLICATION_ERROR(12101,'NO MATCHING RECORD EXIST YET');
45 ENDIF;
46 end;
47 /
Warning: Procedure created with compilation errors.
SQL> show err;
Errors for PROCEDURE UPDATE_EMPLOYEE:
LINE/COL ERROR
19/1 PLS-00103: Encountered the symbol "DECLARE" when expecting one of
the following:
; is with authid as cluster order using external
deterministic parallel_enable pipelined
42/46 PLS-00103: Encountered the symbol "A" when expecting one of the
following:
, * & - + ; / at mod rem return returning <an exponent (**)>
where ||
The symbol "," was substituted for "A" to continue.
LINE/COL ERROR
46/4 PLS-00103: Encountered the symbol ";" when expecting one of the
following:
if
Much appreciation in advance
cube60