Error in Insertion through procedures

Question

Dear all,
I executed below procedure without error, but the rows are not inserted in the table...........
create or replace procedure pq_demo
is
cursor cr_rad is select * from rad where radius<10;
cr_val cr_rad%rowtype;
area number;
begin
open cr_rad;
fetch cr_rad into cr_val;
while(cr_rad%NOTFOUND)
loop
--cr_val.sal:=cr_val.sal+(0.10*cr_val.sal);
dbms_output.put_line('Hello');
area:=3.14159*power(cr_val.radius,2);
dbms_output.put_line(cr_val.radius||' : '||area);
insert into area values(cr_val.radius,area);
fetch cr_rad into cr_val;
end loop;
close cr_rad;
commit;
end;

Answer 1

Why dont you simply use a insert, Why are you complicating things by using cursors ,loops etc.
isnt the below very simple?
CREATE OR REPLACE PROCEDURE pq_demo
IS
BEGIN
   INSERT INTO area
      SELECT radius, 3.14159 * POWER ( radius, 2)
        FROM rad
       WHERE radius < 10;
   COMMIT;
END;G.