Error in writing execute immendiate statement

Question

i am writing this SQL procedure i have made use of dynamic SQL in this .... on compilation this is giving
me error
procedure
create or replace
PROCEDURE USP_GETMSTORDERFORBATCHSMPGENE
v_pUserid IN NUMBER ,
v_pFromDate IN DATE ,
v_pToDate IN DATE ,
v_pVisitTypeID IN NUMBER ,
v_pWardID IN NUMBER ,
v_pSubDeptID IN NUMBER ,
v_plocid IN char
AS
v_Sql NVARCHAR2(4000);
BEGIN
v_Sql := '';
v_Sql := 'SELECT DISTINCT
OrderMst.OrdNo,OrderMst.OrdDateTime,OrderMst.OrdId,LABSampleType.ID AS SampleTypeID,LABSampleType.SampleType,
NVL(LABSampleType.SampleCode, '''') AS SampleCode,SubDepartment_Mst.SubDepartment_Name,Visit.VisitTypeID,Ward_Mst.Ward_ID,
Patient.First_Name || '''' '''' || Patient.Middle_Name || '''' '''' || Patient.Last_Name AS Patient,Patient.Registration_No,Visit.VisitNo
FROM OrderDtl INNER JOIN
OrderMst ONOrderDtl.OrdID =OrderMst.OrdId INNER JOIN
Service_Mst ONOrderDtl.ServiceId =Service_Mst.Service_ID INNER JOIN
LABTest ONService_Mst.Service_ID =LABTest.ServiceID INNER JOIN
LABSampleType ONLABTest.SampleType =LABSampleType.ID INNER JOIN
Visit ONOrderMst.OrdVisitID =Visit.Visit_ID INNER JOIN
Patient ONVisit.PatientID =Patient.PatientId INNER JOIN
SubDepartment_Mst ONService_Mst.SubDepartmentId =SubDepartment_Mst.SubDepartment_ID LEFT OUTER JOIN
Ward_Mst ONVisit.WardID =Ward_Mst.Ward_ID
WHERE (OrderDtl.OrdDtlID NOT IN (SELECT OrderDtlID FROM LABSampleDtl)) And
TO_CHAR(OrderMst.OrdDateTime,''DD-MON-YYYY'') Between
''' || TO_CHAR( v_pFromDate, 'DD-MON-YYYY') || ''' And
''' ||TO_CHAR( v_pToDate, 'DD-MON-YYYY') || '''
and (Cancelled = 0 or Cancelled is null)
and SubDepartment in (select subdetartmentid from userdepartment where userid = ' || CAST(v_pUserid AS VARCHAR2) || ') and OrderMst.locid='|| v_plocid;
IF v_pSubDeptID != 0 THEN
v_Sql := v_Sql || ' AND LABTest.SubDepartment = ' || CAST(v_pSubDeptID AS VARCHAR2) || '';
END IF;
IF v_pVisitTypeID != 0 THEN
v_Sql := v_Sql || ' AND Visit.VisitTypeID = ' || CAST(v_pVisitTypeID AS VARCHAR2) || '';
END IF;
IF v_pWardID != 0 THEN
v_Sql := v_Sql || ' AND Visit.WardID = ' || CAST(v_pWardID AS VARCHAR2) || '';
END IF;
--DBMS_OUTPUT.PUT_LINE((v_Sql));
EXECUTE IMMEDIATE v_Sql;----- error coming in this line
END;
ERROR
Error(55,22): PLS-00382: expression is of wrong type
Edited by: user21354 on Mar 23, 2011 11:53 PM

Answer 1

Looks like this is your problem:
INNER JOIN
Service_Mst ONOrderDtl.ServiceId =Service_Mst.Service_ID INNER JOIN
LABTest ONService_Mst.Service_ID =LABTest.ServiceID INNER JOIN
LABSampleType ONLABTest.SampleType =LABSampleType.ID INNER JOIN
Visit ONOrderMst.OrdVisitID =Visit.Visit_ID INNER JOIN
Patient ONVisit.PatientID =Patient.PatientId INNER JOIN
SubDepartment_Mst ONService_Mst.SubDepartmentId =SubDepartment_Mst.SubDepartment_ID LEFT OUTER JOIN
Ward_Mst ONVisit.WardID =Ward_Mst.Ward_IDYou're missing a space after every 'ON'
Plus in addition to what others have said I really don't believe this is what you want:
And
TO_CHAR(OrderMst.OrdDateTime,''DD-MON-YYYY'') Between
''' || TO_CHAR( v_pFromDate, 'DD-MON-YYYY') || ''' And
''' ||TO_CHAR( v_pToDate, 'DD-MON-YYYY') || '''Also if you're executing a dynamic select statement you need to provide a place for it to put the results.
Also I don't see any reason that this needs to be dynamic. You could just as easily have this:
create or replace
PROCEDURE USP_GETMSTORDERFORBATCHSMPGENE
   v_pUserid IN NUMBER ,
   v_pFromDate IN DATE ,
   v_pToDate IN DATE ,
   v_pVisitTypeID IN NUMBER ,
   v_pWardID IN NUMBER ,
   v_pSubDeptID IN NUMBER ,
   v_plocid IN char
AS
BEGIN
  SELECT DISTINCT OrderMst.OrdNo
                 ,OrderMst.OrdDateTime
                 ,OrderMst.OrdId
                 ,LABSampleType.ID AS SampleTypeID
                 ,LABSampleType.SampleType
                 ,LABSampleType.SampleCode AS SampleCode
                 ,SubDepartment_Mst.SubDepartment_Name
                 ,Visit.VisitTypeID
                 ,Ward_Mst.Ward_ID
                 ,Patient.First_Name || ' ' || Patient.Middle_Name || ' ' || Patient.Last_Name AS Patient
                 ,Patient.Registration_No
                 ,Visit.VisitNo
  -- INTO something goes here
    FROM OrderDtl
      INNER JOIN OrderMst ON OrderDtl.OrdID =OrderMst.OrdId
      INNER JOIN Service_Mst ON OrderDtl.ServiceId =Service_Mst.Service_ID
      INNER JOIN LABTest ON Service_Mst.Service_ID =LABTest.ServiceID
      INNER JOIN LABSampleType ON LABTest.SampleType =LABSampleType.ID
      INNER JOIN Visit ON OrderMst.OrdVisitID =Visit.Visit_ID
      INNER JOIN Patient ON Visit.PatientID =Patient.PatientId
      INNER JOIN SubDepartment_Mst ON Service_Mst.SubDepartmentId =SubDepartment_Mst.SubDepartment_ID
      LEFT OUTER JOIN Ward_Mst ON Visit.WardID =Ward_Mst.Ward_ID
   WHERE (OrderDtl.OrdDtlID NOT IN (SELECT OrderDtlID FROM LABSampleDtl))
     And OrderMst.OrdDateTime Between v_pFromDate And v_pToDate
     and (Cancelled = 0 or Cancelled is null)
     and SubDepartment in
        (select subdetartmentid from userdepartment where userid = CAST(v_pUserid AS VARCHAR2))
     and OrderMst.locid= v_plocid
     AND nvl(LABTest.SubDepartment,'0') = CASE when v_pSubDeptID != 0
                                               then CAST(v_pSubDeptID AS VARCHAR2)
                                               else nvl(LABTest.SubDepartment,'0')
                                          END
     AND nvl(Visit.VisitTypeID,'0') = CASE when v_pVisitTypeID != 0
                                           then CAST(v_pVisitTypeID AS VARCHAR2)
                                           else nvl(Visit.VisitTypeID,'0')
                                      END
     AND nvl(Visit.WardID,'0') = CASE WHEN v_pWardID != 0
                                      THEN CAST(v_pWardID AS VARCHAR2)
                                      ELSE nvl(Visit.WardID,'0')
END;