Error inserting data into database

Question

Hello I am having error inserting data into database through a servlet.Please I am very new to Java Technology and need your immediate help. beloww is the codea nd the error
Apache Tomcat/4.0.3
ERROR: Problems with adding new entry
java.sql.SQLException: [Microsoft][ODBC SQL Server Driver][SQL Server]There are more columns in the INSERT statement than values specified in the VALUES clause. The number of values in the VALUES clause must match the number of columns specified in the INSERT statement.
     at sun.jdbc.odbc.JdbcOdbc.createSQLException(JdbcOdbc.java:6106)
     at sun.jdbc.odbc.JdbcOdbc.standardError(JdbcOdbc.java:6263)
     at sun.jdbc.odbc.JdbcOdbc.SQLExecDirect(JdbcOdbc.java:2525)
     at sun.jdbc.odbc.JdbcOdbcStatement.execute(JdbcOdbcStatement.java:337)
     at Register.insertIntoDB(Register.java:71)
     at Register.doPost(Register.java:53)
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:760)
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
     at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:243)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
     at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
     at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
     at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:190)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
     at org.apache.catalina.valves.CertificatesValve.invoke(CertificatesValve.java:246)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
     at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
     at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
     at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2343)
     at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
     at org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:170)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
     at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:170)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
     at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:468)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
     at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
     at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
     at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
     at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
     at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
     at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
     at org.apache.catalina.connector.http.HttpProcessor.process(HttpProcessor.java:1012)
     at org.apache.catalina.connector.http.HttpProcessor.run(HttpProcessor.java:1107)
     at java.lang.Thread.run(Thread.java:536)
COde:
import java.util.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.io.*;
import java.sql.*;
public class Register extends HttpServlet
     public static Statement statement;
     private Connection DBConn;
     public void init(ServletConfig config) throws ServletException
          super.init(config);
          try {
               Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
               DBConn=DriverManager.getConnection("jdbc:odbc:Challenge");
          catch(Exception e) {
               e.printStackTrace();
               DBConn=null;
     public void doPost(HttpServletRequest req, HttpServletResponse res)
          throws ServletException, IOException
               String user_id,FirstName,LastName, Email, Login, Password;
          FirstName = req.getParameter("FirstName");
          LastName = req.getParameter("LastName");
          Email = req.getParameter("Email");
          Login = req.getParameter("Login");
          Password = req.getParameter("Password");
          PrintWriter output = res.getWriter();
          res.setContentType("text/html");
          if (user_id.equals("")||
          FirstName.equals("") ||
               LastName.equals("") ||
               Email.equals("") ||
               Login.equals("") ||
               Password.equals(""))
                    output.println("<H3>Please click back " + "button and fill in all " + "fileds.</H3>");
                    output.close();
                    return;
               boolean success = insertIntoDB("'" + FirstName + "','" + LastName + "','" + Email + "','" + Login + "','" + Password + "'");
               if (success)
                    output.print("<H2>Thank You " + FirstName + " for registering.</H2>");
                    res.sendRedirect("file:///Register.html");
               else
                    output.print("<H2>An error occured. " + "Please try again later.</H2>");
                    output.close();
          private boolean insertIntoDB(String stringtoinsert)
               try
                    statement = DBConn.createStatement();
                    statement.execute("INSERT INTO Users(user_id,FirstName,LastName,Email,Login,Password) values (" + stringtoinsert + ");");
                    statement.close();
               catch (Exception e)
                    System.err.println("ERROR: Problems with adding new entry");
                    e.printStackTrace();
                    return false;
               return true;
          public void destroy()
               try
                    DBConn.close();
               catch(Exception e)
                    System.err.println("Problem closing the database");
Your Help will be very much appreciate.I am using SQL Server database

Answer 1

The error concerns these two lines:
boolean success = insertIntoDB("'" + FirstName + "','" + LastName + "','" + Email + "','" + Login + "','" + Password + "'");
statement.execute("INSERT INTO Users(user_id,FirstName,LastName,Email,Login,Password) values (" + stringtoinsert + ");");
In the first line above, you have a string which represents the VALUES which you are inserting. There are 5 values. However in the second line above this is your actual SQL execution you are specifying 6 columns of data. If the column "user_id" is an identity or auto-incrementing field in the database, just remove it from this line. If not then you need to supply the "UserID" into the VALUES.
This should fix the problem.