Error: [Microsoft][ODBC driver for Oracle][Oracle]ORA-00917: missing comma

Question

hi
i dont no why this error is coming. error may b while storing chaacter array in database
program is
//TCPClient.java
import java.io.*;
import java.net.*;
import java.util.Calendar;
import java.text.SimpleDateFormat;
import java.sql.*;
import javax.swing.*;
class Client
     protected DataInputStream in;
protected DataOutputStream out;
//Jframe frame;
public static final String DATE_FORMAT_NOW = "yyyy/MM/dd HH:mm:ss";
public static String now() {
Calendar cal = Calendar.getInstance();
SimpleDateFormat sdf = new SimpleDateFormat(DATE_FORMAT_NOW);
return sdf.format(cal.getTime());
public static void main(String argv[]) throws Exception
String FromServer;
String ToServer;
int i=0;
// frame = new JFrame("Show Message Dialog");
Socket clientSocket = new Socket("localhost", 5000);
BufferedReader inFromUser =
new BufferedReader(new InputStreamReader(System.in));
PrintWriter outToServer = new PrintWriter(
clientSocket.getOutputStream(),true);
BufferedReader inFromServer = new BufferedReader(new InputStreamReader(
clientSocket.getInputStream()));
String d=(Client.now());
try{
String cmd = "reg query \"HKEY_LOCAL_MACHINE\\SOFTWARE\"";
     Process p = Runtime.getRuntime().exec(cmd);
Thread.sleep(200l); //terrible, the right way is p.waitFor
InputStream in = p.getInputStream();
byte[] bytes = new byte[16384];
StringBuffer buf = new StringBuffer();
while(true) {
int num = in.read(bytes);
if(num == -1) break;
buf.append(new String(bytes,0,num,"UTF-8"));
//output stored in a string
System.out.println(buf.toString());
String str=new String();
str=(buf.toString());
//formating output
String newtext=str.replaceAll("HKEY_LOCAL_MACHINE","");
String newtext1=newtext.replaceAll("SOFTWARE","*");
System.out.println(newtext1);
//getting local ip
InetAddress thisIp =InetAddress.getLocalHost();
String ip=(thisIp.getHostAddress());
System.out.println("IP:"+thisIp.getHostAddress());
// printing date and time
System.out.println(d);
// connection
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection conn=DriverManager.getConnection("jdbc:odbc:cat","system","root");     
          PreparedStatement ps=conn.prepareStatement("select ip,dates,software from ipdet");
ResultSet r=ps.executeQuery();
char softlist[]=newtext1.toCharArray();
     for(i=0;i<softlist.length;i++)
if(softlist=='*')
System.out.println("\n");
     System.out.print(softlist[i]);
          Statement s=conn.createStatement();
          String ins="insert into ipdet(ip,dates,software) values(ip,d,softlist[i])";
          s.executeUpdate(ins);
// s.setString(1,ip);
          //s.setString(2,d);
               // s.setString(3,softlist[i]);
               // s.executeUpdate();
System.out.println("record inserted succcessfully") ;
          r.close();
          conn.close();
          clientSocket.close();
catch (Exception e)
System.err.println("Error: " + e.getMessage());

Answer 1

i don't think its your connection. You must be hitting the DB otherwise you would not be getting an ORA error returned wrapped in an SQLException. I think its your pseudo-SQL, it simply says that you are missing a comma in an update string. Realistically, it could be that it is being misled into looking for a comma, probably because you have put a ';' at the end of your update string...