Failing to update all rows in a table

Question

Hello, I want to go through every row in a tbale and update values, but it does not work. The error message complains about too small buffer size, and when I add bigger buffett size, (as included in the example), the execution never stops...
CREATE OR REPLACE PROCEDURE convert_frn AS
counter NUMBER;
BEGIN
DBMS_OUTPUT.enable(10000);
SELECT COUNT(fixedcoupondatenb)
INTO counter
FROM floating_rate_note;
FOR i IN 1 .. counter
LOOP
UPDATE floating_rate_note
SET fixedcoupondatenb = '1'
WHERE fixedcoupondatenb = 'YES';
UPDATE floating_rate_note
SET fixedcoupondatenb = '0'
WHERE fixedcoupondatenb = 'NO';
END LOOP;
COMMIT;
END convert_frn;
best regards
Harald

Answer 1

You don't need a loop.
You are working with SQL which means you have to think in sets. With your two update statements executed once ALL records in the floating_rate_note table with fixedcoupondatenb = 'YES' or 'NO' are updated in one shot.
So your procedure should be:
CREATE OR REPLACE PROCEDURE convert_frn
AS
BEGIN
  UPDATE floating_rate_note
  SET fixedcoupondatenb = decode(fixedcoupondatenb,'NO','0','YES','1')
  WHERE fixedcoupondatenb in ('YES','NO')
END convert_frn;Regards,
Rob.