Forms based Query

Question

I have created a control block and on the new block instance I have written the following query using reference cursor
DECLARE
TYPE t1 IS REF CURSOR;
r1 t1;
v_rag_soc_fornitore VARCHAR2(30);
V_societa_for VARCHAR2(2);
v_num_sped NUMBER(6);
v_prg_sped NUMBER(2);
v_num_bolla NUMBER(6);
v_data_bolla DATE;
ec number;
     v_where varchar2(4000);
BEGIN
OPEN r1 for
SELECT DISTINCT rgs0af rag_soc_fornitore
, soc2cc societa_for,ncv2cc num_sped,psc2cc prg_sped,nbu2cc num_bolla,to_date(dbu2cc,'yyyymmdd') data_bolla
FROM wam_acq_ordcli,bl1v2cc,bl2v2cd,or1v2ca,or2a1bb,anag0af --,temp_notice
WHERE societa= 'WM'
AND soccli IN (SELECT DISTINCT SOCCLI FROM WAM_ACQ_ORDCLI WHERE SOCIETA ='WM'
AND FORNITORE = :PARAMETER.P_SUP_CODE) --
AND FORNITORE =:PARAMETER.P_SUP_CODE -- '005598' --
AND soc0af=societa
AND tcn0af='F'
AND cod0af=fornitore
AND tor !='P'
-- AND NBU2CC IN ('801241','801242','801244','801245','801246')--(:PARAMETER.P_GV ) --('1','2')
AND (NBU2CC) IN (:GLOBAL.NUM_BOLLA)--(:PARAMETER.P_GV ) --('1','2')
--AND NBU2CC = DDT
AND soc2cc=soccli
AND cod2cc=cliente
AND tov2cc=tov
AND soc2cd=soc2cc
AND ncv2cd=ncv2cc
AND soc2ca=soc2cd
AND ncv2ca=nol2cd
AND psc2cd=psc2cc
AND nvl(nrd2ca,'X' )!='X'
AND soc1bb=societa
AND nrd1bb=nrd2ca
AND nro1bb=pgo2cd
AND EXISTS (SELECT 1 FROM or1a1ba WHERE soc1ba=soc1bb AND nrd1ba=nrd1bb AND tor1ba=tor)
AND NOT EXISTS (SELECT 1 FROM bl1a1bc x WHERE x.soc1bc=societa AND x.dbu1bc=dbu2cc AND x.nbu1bc=nbu2cc);
--order by num_sped,prg_sped ; 
     FIRST_RECORD;
LOOP
     FETCH r1 INTO
     v_rag_soc_fornitore ,V_societa_for ,v_num_sped ,v_prg_sped , v_num_bolla , v_data_bolla;
IF r1%NOTFOUND then
EXIT;
END IF;
     :BLOCK11.RAG_SOC_FORNITORE_TXT := v_rag_soc_fornitore;
     :BLOCK11.SOCIETA_FOR_TXT := V_societa_for;
     :BLOCK11.NUM_SPED_TXT := TO_CHAR(v_num_sped);
     :BLOCK11.PRG_SPED_TXT := TO_CHAR(v_prg_sped);
     --:BLOCK11.NUM_BOLLA_TXT := to_char(v_num_bolla);
     :BLOCK11.NUM_BOLLA_TXT := (v_num_bolla);
     MESSAGE(:BLOCK11.NUM_BOLLA_TXT);
     MESSAGE(' ');
:BLOCK11.DATA_BOLLA_TXT := v_data_bolla;
NEXT_RECORD;
END LOOP;
FIRST_RECORD;
END;
I am passing the parameter P_sup_code from the first form (say 005598). And the global variable :GLOBAL.NUMBOLLA has the values like 801241,801242,801243,etc. The global variable is passed from the first canvas of the second form to the second canvas.
I am not able to display the values obtained from this cursor on the control block and I am getting the error ORA:01722 . I analysed this code but it shows the error due to the Global variable. which I have used in the query.
Kindly help me in resolving this issue and let me know for the modification that needs to be done.
Thanks,
gobinath

Answer 1

Gobinath,
Why are you assigning each item of each row manually through a CURSOR LOOP? Based on the provided code sample, I don't see why you have not based your Block on a Base Table. You could simply create a View on the database and then base your Data Block on this view. Then you simply need modify the DEFAULT_WHERE clause of the data block to filter the data as you need it filtered. If you are unable to create a view on the database - for what ever reason - then I would recommend you base your Data Block on a From Clause Query. To create a From Clause Query set the Block Property "Query Data Source Type" to "FROM clause query" and set the "Query Data Source Name" to your SQL Statement. A From Clause Query allows you to specify the SQL Statement that supports your Data Block. You can still use the WHERE Clause block property to filter data or you can tweak the query itself by reading the QUERY_DATA_SOURCE_NAME property using GET_BLOCK_PROPERTY() built-in. I recommend using the WHERE Clause property of the block.
It is always far better and far easier to allow Forms do most of the work for you. Displaying data in your form as you are doing is unnecessary and very slow as well.
As for parsing the Global Variable with embedded Apostrophes, I agree with Remco in the use of the INSTR function.
Hope this helps.
Craig...