Help in CURSOR when pass parameter for the IN

Question

Hi,
Need some help I have CURSOR that takes a VARCHAR2 and NUMBER but when I run my Procedure it gives invalid number. Here is the CURSOR
CURSOR get_count (p_list VARCHAR2, p_id NUMBER)
      IS
         SELECT COUNT (*) total_rows,
                NVL
                   (SUM (CASE
                            WHEN UPPER (cdcode) = 'PASS'
                               THEN 1
                            ELSE 0
                         END
                    0
                   ) tot_returned,
                  COUNT (*)
                - NVL (SUM (CASE
                               WHEN UPPER (cdcode) = 'PASS'
                                  THEN 1
                               ELSE 0
                            END
                       0
                      ) diff
           FROM testtable
          WHERE plistcol IN (p_list)
            AND pidcol = p_id;
plistcol is of datatype NUMBER
In my procedure I am building a list to comma separated numbers that goes in p_list parameter of type VARCHAR2 to the cursor i.e.
I have a for loop to build that list e.g.
loop
-- num is of datatype NUMBER
p_list := p_list || num || ',';
end loop
IF (p_list IS NOT NULL)
THEN
p_list := SUBSTR (p_list, 1, LENGTH (p_list) - 1);
END IF;here is how my p_list looks when i pass it on to the cursor
*12,345,678*
and here is how open the cursor
OPEN get_count (p_list, 99999);
and here is the error I get
SQLERRM ORA-01722: invalid number
Now when I hard *12,345,678* in my CURSOR SELECT it works fine, it's only when I pass this as parameter it fails. For example I hard code the values in my CURSOR select it works fine
CURSOR get_count (p_list VARCHAR2, p_id NUMBER)
      IS
         SELECT COUNT (*) total_rows,
                NVL
                   (SUM (CASE
                            WHEN UPPER (cdcode) = 'PASS'
                               THEN 1
                            ELSE 0
                         END
                    0
                   ) tot_returned,
                  COUNT (*)
                - NVL (SUM (CASE
                               WHEN UPPER (cdcode) = 'PASS'
                                  THEN 1
                               ELSE 0
                            END
                       0
                      ) diff
           FROM testtable
          WHERE plistcol IN (12,345,678) -- even '12','345','678' works when hardcoded
            AND pidcol = p_id;I even tried passing the values in the format *'12','345','678'* but still get the above error. So how can I pass the values to cursor IN clause.
So wondering what might be the issue.
Thanks

Answer 1

Why this kind of coding needs to be avoid - here is one demonstration of one aspect ->
satyaki>
satyaki>select * from v$version;
BANNER
Oracle Database 10g Enterprise Edition Release 10.2.0.3.0 - Prod
PL/SQL Release 10.2.0.3.0 - Production
CORE    10.2.0.3.0      Production
TNS for 32-bit Windows: Version 10.2.0.3.0 - Production
NLSRTL Version 10.2.0.3.0 - Production
Elapsed: 00:00:00.22
satyaki>
satyaki>select * from emp;
     EMPNO ENAME      JOB              MGR HIREDATE         SAL       COMM     DEPTNO
      9999 SATYAKI    SLS             7698 02-NOV-08      55000       3455         10
      7777 SOURAV     SLS                  14-SEP-08      45000       3400         10
      7521 WARD       SALESMAN        7698 22-FEB-81       1250        500         30
      7566 JONES      MANAGER         7839 02-APR-81       2975                    20
      7654 MARTIN     SALESMAN        7698 28-SEP-81       1250       1400         30
      7698 BLAKE      MANAGER         7839 01-MAY-81       2850                    30
      7782 CLARK      MANAGER         7839 09-JUN-81       4450                    10
      7788 SCOTT      ANALYST         7566 19-APR-87       3000                    20
      7839 KING       PRESIDENT            17-NOV-81       7000                    10
      7844 TURNER     SALESMAN        7698 08-SEP-81       1500          0         30
      7876 ADAMS      CLERK           7788 23-MAY-87       1100                    20
     EMPNO ENAME      JOB              MGR HIREDATE         SAL       COMM     DEPTNO
      7900 JAMES      CLERK           7698 03-DEC-81        950                    30
      7902 FORD       ANALYST         7566 03-DEC-81       3000                    20
13 rows selected.
Elapsed: 00:00:01.90
satyaki>
--Your query works and here is the slightly modified version of your query
satyaki>
satyaki>
satyaki>declare
  2  
  3   type t_ref_cursor is ref cursor;
  4   l_cursor t_ref_cursor;
  5   l_count number;
  6   l_list varchar2(1000) := '10,20';
  7   v_sql varchar2(1000);
  8  
  9  begin
10  
11  v_sql := '';
12  v_sql := v_sql||'select count(*) as tot_count ';
13  v_sql := v_sql||'from emp ';
14  v_sql := v_sql||'where deptno in ('||l_list||')';
15  
16  open l_cursor for v_sql;
17  loop
18    fetch l_cursor into l_count;
19    exit when l_cursor%notfound;
20    dbms_output.put_line('count: '||l_count);
21  end loop;
22  close l_cursor;
23  
24  end;
25  /
count: 8
PL/SQL procedure successfully completed.
Elapsed: 00:00:00.09
satyaki>
--Now, modifying the input i can sniff into the entire data
satyaki>
satyaki>declare
  2  
  3   type t_ref_cursor is ref cursor;
  4   l_cursor t_ref_cursor;
  5   l_count number;
  6   l_list varchar2(1000) := '10,20) or (1=1';
  7   v_sql varchar2(1000);
  8  
  9  begin
10  
11  v_sql := '';
12  v_sql := v_sql||'select count(*) as tot_count ';
13  v_sql := v_sql||'from emp ';
14  v_sql := v_sql||'where deptno in ('||l_list||')';
15  
16  open l_cursor for v_sql;
17  loop
18    fetch l_cursor into l_count;
19    exit when l_cursor%notfound;
20    dbms_output.put_line('count: '||l_count);
21  end loop;
22  close l_cursor;
23  
24  end;
25  /
count: 13
PL/SQL procedure successfully completed.
Elapsed: 00:00:00.10
satyaki>Got me?
Regards.
Satyaki De.