Help with triggers

Question

Hi All,
i have a few triggers that I need your help with.
The first trigger (below) is fired when an update is made to a column in an invoices table.
The question I have is to do with the exception section.
I want to change the status of the invoice if it fails to F.
This trigger has already complied fine but I have no test data yet to test against.
I was unsure of the mutating effect and was wondering if the exception section will cause it to mutate since it is trying to update the status of the current invoice being processed. Pls see below
create or replace
TRIGGER POP_STAGE AFTER
UPDATE OF "EXCHANGED_DATE" ON "INVOICES" FOR EACH ROW
declare
-- check if the invoice.mco_transfer_status has been updated to R
-- if it has then insert records into the relevant tables
-- Start the Insert based on the update of invoices.mco_transfer_status
ecode varchar2(100);
thisproc CONSTANT VARCHAR2(80) := 'trap_errmesg for transfer_status';
v_value varchar2(150);
BEGIN
-- do updates based on update of invoices.transfer_status column
IF :NEW.TRANSFER_STATUS='R'
THEN
-- Insert into E_TICKET_STAGE
INSERT INTO E_TICKET_STAGE (emco_document_number,exchanged_date,pax_seq,pax_forename,pax_surname,pax_type)
select :NEW.EMCO_DOCUMENT_NUMBER, :NEW.EXCHANGED_DATE,PX.PAX_SEQ,PX.FORENAME,PX.SURNAME,PX.PAX_TYPE
FROM PAX PX WHERE PX.BOOKING_ID=:NEW.BOOKING_ID;
-- Insert into SECTOR_STAGE table
INSERT INTO SECTOR_STAGE (emco_document_number,ps_id,sector_seq,pax_seq,fare_class,fare_basis,net_fare,tax,gross_fare,
flight_number,departure_date,dep_airport_code,dest_airport_code)
SELECT :NEW.EMCO_DOCUMENT_NUMBER, PS.PS_ID,PS.SECTOR_SEQ,PS.PAX_SEQ,PS.FARE_CLASS,PS.FARE_BASIS,PS.NET_FARE,PS.TAX,PS.GROSS_FARE,BS.FLIGHT_NUMBER,BS.DEPARTURE_DATE,
BS.DEP_AIRPORT_CODE,BS.DEST_AIRPORT_CODE
FROM PAX_SECTORS PS, BOOKING_SECTORS BS
WHERE PS.BOOKING_ID=:NEW.BOOKING_ID
AND BS.BOOKING_ID=PS.BOOKING_ID;
-- Insert into TAX_STAGE table
INSERT INTO TAX_STAGE (emco_docUment_number,PS_ID,TAX_SEQ,TAX_CODE,VALUE)
SELECT :NEW.EMCO_DOCUMENT_NUMBER, pt.PS_ID,TAX_SEQ,TAX_CODE,VALUE
FROM PAX_TAX pt,PAX_SECTORS ps
WHERE ps.BOOKING_ID=:OLD.booking_id and pt.PS_ID=ps.PS_ID;
-- Insert into CHARGES_STAGE table
insert into CHARGES_STAGE (emco_document_number,CHARGE_TYPE,CHARGE_AMOUNT)
select :NEW.EMCO_DOCUMENT_NUMBER, CHARGE_TYPE,VALUE FROM INVOICE_DETAILS IND
WHERE :NEW.INVOICE_ID=IND.INVOICE_ID;
END IF;
EXCEPTION
WHEN OTHERS THEN
ecode := SQLCODE|| ' '||sqlerrm ;
dbms_output.put_line(thisproc || ' - ' || ecode);
v_value := thisproc || ' - ' || ecode;
-- Insert into DOCUMENT_STATUS_STAGE ANY ERRORS DURING PROCESSING
     insert into DOCUMENT_STATUS_STAGE (EMCO_DOCUMENT_NUMBER, STATUS,STATUS_DATE)
VALUES (:NEW.EMCO_DOCUMENT_NUMBER,v_value,sysdate);
update invoices set TRANSFER_STATUS='F' where invoice_id=:old.invoice_id;
END pop_stage;
The second trigger (also below) does a check on the payments table to see if the payment_complete date has been set.
If this has been set then we want to sum all the payments (based on invoice_id). once this sum has been made we want to compare this value to the value of the gross amount on the invoices table for that invoice. if they match (which shows the invoce has been fully paid) then we want to update the paid_date and set to sysdate.
create or replace
TRIGGER CHECK_INVOICE_STATUS AFTER
UPDATE OF "PAYMENT_COMPLETE" ON "PAYMENTS" FOR EACH ROW
declare
-- check if all the payments for that invoice have been received (completed)
-- if they are complete then sum all the payments for that invoice and compare to gross value on invoices
v_invoice_amount number;
v_gross_amount number;
thisproc CONSTANT VARCHAR2(80) := 'trap_errmesg for mco_transfer_status';
v_value varchar2(150);
BEGIN
IF :NEW.PAYMENT_COMPLETE is not null
THEN
-- We will sum all the payments for that invoice that have a value in payment_complete
select sum(amount) into v_invoice_amount from payments where payment_complete is not null
group by :OLD.INVOICE_ID;
-- We will also get the gross amount for the invoice to compare to the sum of the payments
select gross into v_gross_amount from invoices where
:OLD.INVOICE_ID = invoice_id;
END IF;
IF v_invoice_amount = v_gross_amount
then
update invoices set paid_date=sysdate;
end if;
end CHECK_INVOICE_STATUS;
Is this trigger sufficent?
Any tips will be appreciate.
Thanks

Answer 1

I didn't really look into your post (rather long) ... anyway, I have 2 words for you "stored procedures".