How can i read XML string in a loop???

Question

i changed xml file reader to xml string reader by
looking around this and other forums.
here is the code.
public class XMLTester2 {
    public static void main(String[] args) {
        String s = "<firsttag><secondtag>123</secondtag></firsttag>";
        java.io.Reader reader = new java.io.StringReader(s);
        org.xml.sax.InputSource source = new org.xml.sax.InputSource(reader);
        org.w3c.dom.Document doc = null;
        javax.xml.parsers.DocumentBuilderFactory fact = javax.xml.parsers.DocumentBuilderFactory.newInstance();
        try {
            javax.xml.parsers.DocumentBuilder builder = fact.newDocumentBuilder();
            doc = builder.parse(source);
        } catch (javax.xml.parsers.ParserConfigurationException pce) {
        } catch (org.xml.sax.SAXException se) {
        } catch (java.io.IOException ioe) {
        } finally {
            try {
                reader.close();
            } catch (java.io.IOException ignored) {
}i put this stuff into a loop, but i always ends up
having new in the loop.
            String inputLine = "Start";
            // define what's needed for XML messages
            Reader reader = new StringReader(inputLine);
            InputSource source = new InputSource(reader);
            Document doc = null;
            DocumentBuilderFactory fact = DocumentBuilderFactory.newInstance();
            DocumentBuilder builder = null;
            Node xmlNode = null;
            try {
                builder = fact.newDocumentBuilder();
            } catch (ParserConfigurationException pce) {
            // -->
            while ( (inputLine = in.readLine()) != null) {
                System.out.println("readLine() : {" + inputLine + "}");
                reader = new StringReader(inputLine);
                source.setCharacterStream(reader);
                try {
                    doc = builder.parse(source);
                } catch (SAXException se) {
                    System.out.println("SAXException : " + se);
                    System.out.println("SAXException source : " + source.toString() );
                    se.printStackTrace();
                } catch (IOException ioe) {
                    System.out.println("IOException : " + ioe);
                } finally {
                    try {
                        reader.close();
                    } catch (IOException ignored) {
                reader = null;i know putting new in the loop is VERY bad.
i gotto get ride of this new from the loop.
can anyone help me?

Answer 1

i know putting new in the loop is VERY bad.
i gotto get ride of this new from the loop.Don't design your application based on one-liners you heard somewhere. Do some timings to see if it matters. My guess would be that parsing an XML file would take a fair bit longer than creating a StringReader object. And you do need a new StringReader each time, they aren't reusable, so the alternatives are not obvious. And don't accept my guess about the timings, check it for yourself.