How to organize the bean class?

Question

Hello I am a new to ADF. I am using mostly pages with session scope, because I can pass parameters from the session scope: adf.context.expressionEvaluator.evaluate('#{sessionBean.dateDay}');
Because of that I am trying to not put many variables to the scope.
I am wondering what is the better practice? To put the Application Module as a static class field to my bean and call it as 'this.am' in every function or
to create it in every function around 30+ times per class like that: AppModuleImpl am = (AppModuleImpl)ADFUtils.getApplicationModuleForDataControl("AppModuleDataControl");
Also I am wondering if I have a button and I want to modify its 'visible' attribute is it better to bind this button and change it visibility as : this.button.setVisible(false);
or to make a field in my class private Boolean isButtonVisible = false; and in the setter to look like this:
    public void setIsButtonVisible(Boolean isButtonVisible) {
        this.isButtonVisible= isButtonVisible;
        refreshButtonById(":pt1:but1");
       private void refreshButtonById(String elementId) {
        RichCommandLink button =
            (RichCommandLink)FacesContext.getCurrentInstance().getViewRoot().findComponent(elementId);
        AdfFacesContext.getCurrentInstance().addPartialTarget(button);
    }I will gladly accept any links that will show me how to write a quality code in ADF. :)

Answer 1

Here is a part of the code of one of my beans:
    public String save() {
        try {
            BuildixxUtils.commit();
            System.out.println("The changes are commited.");
            BuildixxUtils.addInfoMessage("All changes are successfully saved");
        } catch (Exception e) {
            BuildixxUtils.addErrorMessage(e.getMessage());
        return "null";
    public String cancel() {
        DCBindingContainer dbc = (DCBindingContainer)BindingContext.getCurrent().getCurrentBindingsEntry();
        DCIteratorBinding vehicleOwnerIterator = dbc.findIteratorBinding("VehicleOwnerAdminViewIterator");
        Key selectedVehicleOwnerKey = vehicleOwnerIterator.getCurrentRow().getKey();
        DCIteratorBinding voGroupIdIterator = dbc.findIteratorBinding("VoGroupAdminView2Iterator");
        Key selectedVoGroupKey = null;
        if (voGroupIdIterator.getCurrentRow() != null) {
            selectedVoGroupKey = voGroupIdIterator.getCurrentRow().getKey();
        try {
            AppModuleImpl am = (AppModuleImpl)ADFUtils.getApplicationModuleForDataControl("AppModuleDataControl");
            am.getTransaction().rollback();
            System.out.println("Rollback done.");
            BuildixxUtils.addInfoMessage("All changes are cancelled");
        } catch (Exception e) {
            BuildixxUtils.addErrorMessage(e.getMessage());
        setCurrentRowsOfAllTables(dbc, vehicleOwnerIterator, selectedVehicleOwnerKey, voGroupIdIterator,
                                  selectedVoGroupKey);
        return "null";
    private void setCurrentRowsOfAllTables(DCBindingContainer dbc,
                                           DCIteratorBinding vehicleOwnerIterator,
                                           Key selectedVehicleOwnerKey,
                                           DCIteratorBinding voGroupIdIterator,
                                           Key selectedVoGroupKey) {
        vehicleOwnerIterator.setCurrentRowWithKey(selectedVehicleOwnerKey.toStringFormat(true));
        if (selectedVoGroupKey != null) {
            Row row = voGroupIdIterator.findRowByKeyString(selectedVoGroupKey.toStringFormat(true));
            if (row != null) {
                System.out.println("Key exists");
                voGroupIdIterator.setCurrentRowWithKey(selectedVoGroupKey.toStringFormat(true));
                HidePersonVehicleButtonsIfNeeded(dbc);
            } else {
                System.out.println("Key doesn't exist");
                setIsDeleteGroupButtonVisible(false);
                setIsDeletePersonButtonVisible(false);
    private void HidePersonVehicleButtonsIfNeeded(DCBindingContainer dbc) {
        DCIteratorBinding personGroupIterator = dbc.findIteratorBinding("VoGroupPersonView2Iterator");
        if (personGroupIterator.getCurrentRow() == null) {
            setIsDeletePersonButtonVisible(false);
        DCIteratorBinding vehicleGroupIterator = dbc.findIteratorBinding("VoGroupVehicleView1Iterator");
        if (vehicleGroupIterator.getCurrentRow() == null) {
            setIsDeleteVehicleButtonVisible(false);
    }I am using 5 tables 3 popups 8 buttons. When no rows are selected i make the delete buttons invisible. When a cancel button is pressed I want to save the state of the page so I need to set the current rows of some of the tables. The tables are connected with view links etc...
You can give me some hits how I can refactor the functions to improve them. Thanks. :)