HowTo Close stream on exception (FindBug)

Question

Hi there.
I've just started to use the tool FindBugs which seems to work all right as far as it goes.
But it claims, that in the following code the method may "fail to close stream on exception":
     void writeToFile(String fileName){
          System.out.print("Creating "+fileName+" ..");
          try {
               FileOutputStream fos = new FileOutputStream(new File(fileName));
               PrintWriter o = new PrintWriter(fos);  //this line is marked as error-prone
               o.println("Some String");
               o.close();
          } catch (FileNotFoundException e) {
               e.printStackTrace();
          System.out.println(".done");
     }Whereas if I comment out the line with the o.println-call, everything's fine again for "FindBugs".
I have absolutely no clue to what's meant by "on exception", since neither the line itself nor the following line throws an Exception.
(BTW: adding an "finally" block or closing the stream after the try-catch-block doesn't seem to solve the problem for FindBugs).
So, what's my problem? The code seems to work yet. But FindBugs seems to be a neat tool and since I don't like having code that might fail to close streams on exceptions,
I'd like to hear from some of you how you'd code a simple block like that.
(Add to that: I hate being corrected by a programme (At least as long as this fucker seems to be smarter than me ;) So now it's time for me to learn!! )
Any suggestions about how to improve my programming technique are gratefully taken, as well as blind guessing around about what the hell FindBugs thinks I should do better.
-T-

Answer 1

Hi,
This is the first time I am using findbugs tool. I have this piece of code
<target if="javadoc.packages" name="findbug" >
<!--<available file="etc/javadoc_build.inc" property="javadoc.buildinc"/>-->
<findbugs home="D:\bin\common\_lib\build\findbugs"
output="xml"
outputFile="bcel-fb.xml" >
          <!--<auxClasspath path="${basedir}/lib/Regex.jar" />-->
          <sourcePath path="C:\java.zip" />
<class location="C:\java.zip" />
</findbugs>
</target>
My questions are
1)Is the <auxClasspath> extension required.
2)on running ant task, i get the following error
D:\deepak\buildProcess_2\logging>ant findbug
Buildfile: build.xml
[taskdef] Could not load definitions from resource tasks.properties. It could not be found.
findbug:
findbug:
BUILD FAILED
file:D:/deepak/buildProcess_2/_setup/docs.xml:190: Could not create task or type of type: findbugs.
Ant could not find the task or a class this task relies upon.
This is common and has a number of causes; the usual
solutions are to read the manual pages then download and
install needed JAR files, or fix the build file:
- You have misspelt 'findbugs'.
Fix: check your spelling.
- The task needs an external JAR file to execute
and this is not found at the right place in the classpath.
Fix: check the documentation for dependencies.
Fix: declare the task.
- The task is an Ant optional task and optional.jar is absent
Fix: look for optional.jar in ANT_HOME/lib, download if needed
- The task was not built into optional.jar as dependent
libraries were not found at build time.
Fix: look in the JAR to verify, then rebuild with the needed
libraries, or download a release version from apache.org
- The build file was written for a later version of Ant
Fix: upgrade to at least the latest release version of Ant
- The task is not an Ant core or optional task
and needs to be declared using <taskdef>.
Remember that for JAR files to be visible to Ant tasks implemented
in ANT_HOME/lib, the files must be in the same directory or on the
classpath
Please neither file bug reports on this problem, nor email the
Ant mailing lists, until all of these causes have been explored,
as this is not an Ant bug.
Total time: 3 seconds
Anyone suggest me a solution.
bye,
with regards,
Deepak.