I need help to improve speed

Question

Hello
I have a JTable with 33 nessesary columns. The row count can be from 1 to 50. That gives maximum 1650 diffrent values to save to the database.
The current system, creates a object for each line(33 values) and fill them into a arraylist, send it to my dao, who takes object by object and stores them. The speed this way is "okay, could be better".
Then when im retreawing the data, I get row by row, create a object, fill my arraylist, goes trough it object by object and put them in each row.
1 row goes fast, 5 rows takes time, 50 rows takes forever...
What can speed things upp here ? If u need some code, please let me know.
Ive been thinking of something thread based, 1 thread for each row, sounds smart?

Answer 1

My JTable lists "meetings" for 1 week. 1 row presents a meetings data.
There are 2 JButtons used for changing week, either +1 or -1 from the week number your standing inn. I will now show everything that happens with 1 click. Thats 4 steps.
Step 1: Saving current data(meetings for current week)
     private void saveM�ter() {
          dao.slettM�ter(�r, uke);
          ArrayList m�ter = new ArrayList();
          for (int i = 0; i < mdlRapport.getRowCount(); i++) {
               UkerapportM�te m�te =
                    new UkerapportM�te(
                         �r,
                         uke,
                         (String) mdlRapport.getValueAt(i, 0),
                         (String) mdlRapport.getValueAt(i, 1),
                         (String) mdlRapport.getValueAt(i, 32),
                         (String) mdlRapport.getValueAt(i, 33));
               UkerapportM�te m�teX = formatM�te(m�te);
               m�ter.add(m�teX);
          dao.lagreM�ter(m�ter);
     }Comments:
dao.slettM�ter(�r, uke); This method removes everything from the database for the current week.
dao.lagreM�ter(m�ter);This method saves everything to the database current week. That method is posted bellow, maybe that is a bottleneck.
     public void lagreM�ter(ArrayList m�ter) {
          Statement stmt = null;
          String sql = null;
          UkerapportM�te m�te = null;
          try {
               for (int i = 0; i < m�ter.size(); i++) {
                    m�te = (UkerapportM�te) m�ter.get(i);
                    sql =      " INSERT INTO Ukerapport VALUES("
                              + m�te.get�rID()
                              + ","
                              + m�te.getUkeID()
                              + ",'"
                              + m�te.getM�tedag()
                              + "','"
                              + m�te.getM�teKlokke()
                              + "','"
                              + m�te.getM�teSted()
                              + "','"
                              + m�te.getM�teKunde()
                    + "','"
                              + m�te.getPrivatBilP()
                    + "','"
                              + m�te.getPrivatBilS()
                    + "','"
                              + m�te.getPrivatVillaP()
                    + "','"
                              + m�te.getPrivatVillaS()
                    + "','"
                              + m�te.getPrivatServP()
                    + "','"
                              + m�te.getPrivatServS()
                    + "','"
                              + m�te.getN�ringslivAntP()
                    + "','"
                              + m�te.getN�ringslivAntS()
                    + "','"
                              + m�te.getMersalgKrP()
                    + "','"
                              + m�te.getMersalgKrS()
                    + "','"
                              + m�te.getMersalgAntP()
                    + "','"     
                              + m�te.getMersalgAntS()
                    + "','"
                              + m�te.getLivP()
                    + "','"
                              + m�te.getLivS()
                    + "','"
                              + m�te.getSparAntP()
                    + "','"
                              + m�te.getSparAntS()
                    + "','"
                              + m�te.getSparKrP()
                    + "','"
                              + m�te.getSparKrS()
                    + "','"
                              + m�te.getKollpensjonAntP()
                    + "','"
                              + m�te.getKollpensjonAntS()
                    + "','"
                              + m�te.getKollpensjonKrP()
                    + "','"
                              + m�te.getKollpensjonKrS()
                    + "','"
                              + m�te.getFinansAntP()
                    + "','"
                              + m�te.getFinansAntS()
                    + "','"
                              + m�te.getFinansKrP()
                    + "','"
                              + m�te.getFinansKrS()
                    + "','"
                              + m�te.getRef()
                    + "','"
                              + m�te.getProv()
                    + "','"
                              + m�te.getForening()
                              + "','"
                              + m�te.getKommentar()
                              + "')";
                    stmt = con.createStatement();
                    //rs = stmt.executeQuery(sql);
                    int x = stmt.executeUpdate(sql);
          } //end try
          catch (SQLException e) {
               System.out.println("UkerapportDAO: Klarer ikke � utf�re sp�rringen: " + sql);
               System.out.println("--lagreM�ter() " + e.getMessage() + "\n");
          }finally{
               try{
               if(stmt!=null)
                    stmt.close();
               }catch(SQLException sqlex){
                    System.out.println("UkerapportDAO: Klarer ikke � lukke");
                    System.out.println("--lagreM�ter() " + sqlex.getMessage() + "\n");
     }Step 2:
I update values for week and year, depening on going 1 week up or down. I dont find it nessesary to show that code....
Step 3: Remove everything from the JTable
     private void clearTable() {
          for (int i = 0; i < mdlRapport.getRowCount(); i++) {
               mdlRapport.removeRow(i);
     }Comments: Dont think theres anything todo here...
Step4: Get new meetings from the database.
private void loadM�ter() {
          ArrayList nyeM�ter = dao.getM�ter(�r, uke);
          mdlRapport.setRowCount(nyeM�ter.size());
          for (int i = 0; i < nyeM�ter.size(); i++) {
               UkerapportM�te m�te = (UkerapportM�te) nyeM�ter.get(i);
               if (m�te.getM�tedag().equals("Blank")) {
                    mdlRapport.setValueAt("", i, 0);
               } else {
                    mdlRapport.setValueAt(m�te.getM�tedag(), i, 0);
               if (m�te.getM�teKlokke().equals("Blank")) {
                    mdlRapport.setValueAt("", i, 1);
               } else {
                    mdlRapport.setValueAt(m�te.getM�teKlokke(), i, 1);
               if (m�te.getProv().equals("0")) {
                    mdlRapport.setValueAt("", i, 31);
               } else {
                    mdlRapport.setValueAt(m�te.getProv() + "", i, 31);
               if (m�te.getForening().equals("Blank")) {
                    mdlRapport.setValueAt("", i, 32);
               } else {
                    mdlRapport.setValueAt(m�te.getForening(), i, 32);
               if (m�te.getKommentar().equals("Blank")) {
                    mdlRapport.setValueAt("", i, 33);
               } else {
                    mdlRapport.setValueAt(m�te.getKommentar(), i, 33);
     }Comments: I skipped alot of code here, This code is ofcouse much longer, I just took the first if*s and the last ones.
ArrayList nyeM�ter = dao.getM�ter(�r, uke); This method is posted bellow.
     public ArrayList getM�ter(int �rID, int ukeID) {
          Statement stmt = null;
          ResultSet rs = null;
          String sql = "SELECT * FROM Ukerapport WHERE ukeID="      + ukeID      + " AND �rID =" + �rID;
          list = new ArrayList();
          try {
               stmt = con.createStatement();
               rs = stmt.executeQuery(sql);
               while (rs.next()) {
                    m�te =
                         new UkerapportM�te( rs.getInt(1), rs.getInt(2), rs.getString(3), rs.getString(4), rs.getString(5), rs.getString(6), rs.getString(7), rs.getString(8), rs.getString(9), rs.getString(10), rs.getString(11), rs.getString(12), rs.getString(13),      rs.getString(14), rs.getString(15), rs.getString(16),      rs.getString(17), rs.getString(18), rs.getString(19), rs.getString(20),      rs.getString(21),      rs.getString(22),      rs.getString(23), rs.getString(24), rs.getString(25), rs.getString(26),      rs.getString(27),      rs.getString(28), rs.getString(29), rs.getString(30), rs.getString(31), rs.getString(32), rs.getString(33), rs.getString(34), rs.getString(35),      rs.getString(36));
                    list.add(m�te);
               rs.close();
               stmt.close();
          } catch (SQLException sqlex) {
               System.out.println( "Error: Klarer ikke � utf�re sp�rringen. " + sqlex.getMessage());
               System.out.println( "--getM�ter()");
          return list;
     }I Think this is the slow part. The if tests where made cause i had trouble saving empty meeting values in the database, so When a meetings value is missing i save it as "Blank", and when i read the data i check for "Blank" and if true I set the value "".
Can you help me make this faster?