Is this correct way of coding report

Question

*& Report  ZPP_MELTSHOP
this report is :
based on the date it should pick all production orders & for each po it should display the quantity by material.
I am displaying the material of movement type '101' beside that in the same line I am displaying the quantities of material of movement type '261' ie. mscrap, pig iron etc.
just check the logic is correct in the code
pls reply
REPORT  zpp_meltshop NO STANDARD PAGE HEADING LINE-SIZE 150.
TYPE-POOLS: slis.
TABLES : afko,
         mkpf,
         mseg.
SELECTION-SCREEN BEGIN OF BLOCK b1 WITH FRAME TITLE text-001.
*SELECT-OPTIONS : s_aufnr like afko-aufnr.
SELECT-OPTIONS: s_date FOR afko-gltrp.  "finish date
SELECTION-SCREEN END OF BLOCK b1.
DATA : BEGIN OF i_prod OCCURS 0,
          aufnr LIKE afko-aufnr,
          gstrp LIKE afko-gstrp,
          gltrp LIKE afko-gltrp,
       END OF i_prod.
DATA : BEGIN OF i_mseg OCCURS 0,
          mblnr LIKE mseg-mblnr,        "mat doc.no
          mjahr LIKE mseg-mjahr,
          zeile LIKE mseg-zeile,
          bwart LIKE mseg-bwart,        "movement type
          matnr LIKE mseg-matnr,
          werks LIKE mseg-werks,
          lgort LIKE mseg-lgort,
          charg LIKE mseg-charg,
          menge LIKE mseg-menge,
          meins LIKE mseg-meins,
          aufnr LIKE mseg-aufnr,
        END OF i_mseg.
DATA : BEGIN OF i_qals OCCURS 0,
          prueflos LIKE qals-prueflos,
          aufnr LIKE qals-aufnr,
       END OF i_qals.
DATA : BEGIN OF i_results OCCURS 0,
           prueflos LIKE qamv-prueflos,            "inspection lot number
           kurztext LIKE qamv-kurztext,            "short text of characteristic
           merknr LIKE qamr-merknr,                "inspection characteristic no.
           original_input LIKE qamr-original_input, "Original Value
       END OF i_results.
DATA : BEGIN OF i_short_text OCCURS 0,
           prueflos LIKE qamv-prueflos,            "inspection lot number
           merknr LIKE qamr-merknr,                "inspection characteristic no.
           kurztext LIKE qamv-kurztext,            "short text of characteristic
       END OF i_short_text.
DATA : BEGIN OF i_original_value OCCURS 0,
           prueflos LIKE qals-prueflos,            "inspection lot number
           merknr LIKE qamr-merknr,                "inspection characteristic no.
           original_input LIKE qamr-original_input, "Original Value
       END OF i_original_value.
DATA : BEGIN OF  i_final OCCURS 0,
          aufnr LIKE afko-aufnr,
          gstrp LIKE afko-gstrp,
          gltrp LIKE afko-gltrp,
          mblnr LIKE mseg-mblnr,        "mat doc.no
          bwart LIKE mseg-bwart,        "movement type
          matnr LIKE mseg-matnr,
          werks LIKE mseg-werks,
          lgort LIKE mseg-lgort,
          charg LIKE mseg-charg,
          menge LIKE mseg-menge,
          meins LIKE mseg-meins,
       END OF i_final.
DATA : BEGIN OF i_final2 OCCURS 0,
          aufnr LIKE afko-aufnr,
          gstrp LIKE afko-gstrp,
          gltrp LIKE afko-gltrp,
          mblnr LIKE mseg-mblnr,        "mat doc.no
          bwart LIKE mseg-bwart,        "movement type
          matnr LIKE mseg-matnr,
          werks LIKE mseg-werks,
          lgort LIKE mseg-lgort,
          charg LIKE mseg-charg,
          menge LIKE mseg-menge,
          meins LIKE mseg-meins,
          mqty1 LIKE mseg-menge,        "MILD STEEL SCRAP
          mqty2 LIKE mseg-menge,        "PIG IRON
          mqty3 LIKE mseg-menge,        "FOUNDRY RETURN NORMAL
          mqty4 LIKE mseg-menge,        "CALCINED PETROLEUM COK
          mqty5 LIKE mseg-menge,        "FERRO SILICON
          mqty6 LIKE mseg-menge,        "FERRO MANGANESE
          mqty7 LIKE mseg-menge,        "COPPER SCRAP
          prueflos LIKE qals-prueflos,            "inspection lot number
          merknr LIKE qamr-merknr,                "inspection characteristic no
          kurztext LIKE qamv-kurztext,            "short text of characteristic
          qc_c  LIKE qamr-original_input,
          qc_mn LIKE qamr-original_input,
          qc_ni LIKE qamr-original_input,
       END OF i_final2.
DATA : BEGIN OF i_final3 OCCURS 0,
           aufnr LIKE afko-aufnr,
           gstrp LIKE afko-gstrp,
           gltrp LIKE afko-gltrp,
           mblnr LIKE mseg-mblnr,        "mat doc.no
           bwart LIKE mseg-bwart,        "movement type
           matnr LIKE mseg-matnr,
           werks LIKE mseg-werks,
           lgort LIKE mseg-lgort,
           charg LIKE mseg-charg,
           menge LIKE mseg-menge,
           meins LIKE mseg-meins,
           mqty1 LIKE mseg-menge,        "MILD STEEL SCRAP
           mqty2 LIKE mseg-menge,        "PIG IRON
           mqty3 LIKE mseg-menge,        "FOUNDRY RETURN NORMAL
           mqty4 LIKE mseg-menge,        "CALCINED PETROLEUM COK
           mqty5 LIKE mseg-menge,        "FERRO SILICON
           mqty6 LIKE mseg-menge,        "FERRO MANGANESE
           mqty7 LIKE mseg-menge,        "COPPER SCRAP
           prueflos LIKE qals-prueflos,            "inspection lot number
           merknr LIKE qamr-merknr,                "inspection characteristic no
           kurztext LIKE qamv-kurztext,            "short text of characteristic
           qc_c  LIKE qamr-original_input,
           qc_mn LIKE qamr-original_input,
           qc_ni LIKE qamr-original_input,
        END OF i_final3.
DATA : indx TYPE i,
       indx2 TYPE i.
DATA : i_fieldcat TYPE slis_fieldcat_alv OCCURS 0,
       w_fieldcat TYPE slis_fieldcat_alv.
START-OF-SELECTION.
  SELECT aufnr gstrp gltrp FROM afko INTO TABLE i_prod WHERE gltrp IN s_date.
  IF sy-subrc EQ 0.
    SELECT  mblnr
            mjahr
            zeile
            bwart
            matnr
            werks
            lgort
            charg
            menge
            meins
            aufnr FROM mseg INTO TABLE i_mseg
                  FOR ALL ENTRIES IN i_prod WHERE aufnr = i_prod-aufnr
                  %_HINTS ORACLE 'INDEX("MSEG" "MSEG~ZPD")'.
    IF sy-subrc NE 0.
      MESSAGE e001(zmsg1).
    ENDIF.
  ELSE.
    WRITE : / 'No production orders found within the date'.
  ENDIF.
*qals
  IF NOT i_mseg[] IS INITIAL.
    SELECT prueflos
           aufnr
           INTO TABLE i_qals FROM qals FOR ALL ENTRIES IN i_mseg
           WHERE aufnr = i_mseg-aufnr.
  ENDIF.
*short text
  IF NOT i_qals[] IS INITIAL.
    SELECT prueflos
           merknr
           kurztext FROM qamv
                   INTO TABLE i_short_text
                   FOR ALL ENTRIES IN i_qals
                   WHERE prueflos = i_qals-prueflos.
  ENDIF.
*original value
  IF NOT i_short_text[] IS INITIAL.
    SELECT prueflos
           merknr
           original_input FROM qamr
                   INTO TABLE i_original_value
                   FOR ALL ENTRIES IN i_short_text
                   WHERE prueflos = i_short_text-prueflos.
  ENDIF.
  LOOP AT i_short_text.
    LOOP AT i_original_value WHERE prueflos = i_short_text-prueflos AND
                                    merknr = i_short_text-merknr.
      i_results-prueflos = i_short_text-prueflos.
      i_results-merknr = i_short_text-merknr.
      i_results-kurztext = i_short_text-kurztext.
      i_results-original_input = i_original_value-original_input.
      APPEND i_results.
    ENDLOOP.
  ENDLOOP.
*data : indx1 type i.
LOOP AT i_results.
indx1 = sy-tabix.
   LOOP AT i_original_value WHERE prueflos = i_results-prueflos AND
                                  merknr = i_results-merknr.
     i_results-original_input = i_original_value-original_input.
     modify i_results index indx1.
   ENDLOOP.
ENDLOOP.
*move data to i_final internal table
  LOOP AT i_prod.
    LOOP AT i_mseg WHERE aufnr = i_prod-aufnr.
   IF sy-subrc EQ 0.
      i_final-aufnr = i_mseg-aufnr.
      i_final-gstrp = i_prod-gstrp.
      i_final-gltrp = i_prod-gltrp.
      i_final-mblnr = i_mseg-mblnr.
      i_final-bwart = i_mseg-bwart.
      i_final-matnr = i_mseg-matnr.
      i_final-werks = i_mseg-werks.
      i_final-lgort = i_mseg-lgort.
      i_final-charg = i_mseg-charg.
      i_final-menge = i_mseg-menge.
      i_final-meins = i_mseg-meins.
   ENDIF.
      APPEND i_final.
      CLEAR i_final.
    ENDLOOP.
  ENDLOOP.
  LOOP AT i_final.
    i_final2-aufnr = i_final-aufnr.
    i_final2-gstrp = i_final-gstrp.
    i_final2-gltrp = i_final-gltrp.
    i_final2-mblnr = i_final-mblnr.
    i_final2-bwart = i_final-bwart.
    i_final2-matnr = i_final-matnr.
    i_final2-werks = i_final-werks.
    i_final2-lgort = i_final-lgort.
    i_final2-charg = i_final-charg.
    i_final2-menge = i_final-menge.
    i_final2-meins = i_final-meins.
    APPEND i_final2.
    CLEAR i_final2.
  ENDLOOP.
  LOOP AT i_final2.
    indx = sy-tabix.
    IF i_final2-bwart = '261'.
      READ TABLE i_final WITH KEY aufnr = i_final2-aufnr.
      IF sy-subrc EQ 0.
        IF i_final2-matnr = 'MSCRAP'.
          i_final2-mqty1 = i_final2-mqty1 + i_final-menge.
        ELSEIF i_final2-matnr = '100072'.    "PIG IRON
          i_final2-mqty2 = i_final2-mqty2 + i_final-menge.
        ELSEIF i_final2-matnr = 'RETFDYNORM'.  "FOUNDRY RETURN NORMAL
          i_final2-mqty3 = i_final2-mqty3 + i_final-menge.
        ELSEIF i_final2-matnr = '100062'.      "CALCINED PETROLEUM COK
          i_final2-mqty4 = i_final2-mqty4 + i_final-menge.
        ELSEIF i_final2-matnr = '100063'.      "FERRO SILICON
          i_final2-mqty5 =  i_final2-mqty5 + i_final-menge.
        ELSEIF i_final2-matnr = '100065'.      "FERRO MANGANESE
          i_final2-mqty6 = i_final2-mqty6 + i_final-menge.
        ELSEIF i_final2-matnr = '100070'.
          i_final2-mqty7 = i_final2-mqty7 + i_final-menge.
        ENDIF.
      ENDIF.
endif.
      READ TABLE i_qals WITH KEY aufnr = i_final2-aufnr.
      IF sy-subrc EQ 0.
        i_final2-prueflos = i_qals-prueflos.
      ENDIF.
if i_final2-bwart = '101'.
      LOOP AT i_results WHERE prueflos = i_final2-prueflos.
     IF sy-subrc EQ 0.
        i_final2-merknr = i_results-merknr.
        i_final2-kurztext = i_results-kurztext.
        IF i_final2-kurztext = 'C'.
          i_final2-qc_c = i_results-original_input.
        ELSEIF i_final2-kurztext = 'Mn'.
          i_final2-qc_mn = i_results-original_input.
        ELSEIF  i_final2-kurztext = 'Ni'.
          i_final2-qc_ni = i_results-original_input.
        ENDIF.
      ENDLOOP.
      ENDIF.
      MODIFY i_final2 INDEX indx.
   ENDIF.
ENDIF.
  ENDLOOP..
  LOOP AT i_final2.
    i_final3-aufnr = i_final2-aufnr.
    i_final3-gstrp = i_final2-gstrp.
    i_final3-gltrp = i_final2-gltrp.
    i_final3-mblnr = i_final2-mblnr.
    i_final3-bwart = i_final2-bwart.
    i_final3-matnr = i_final2-matnr.
    i_final3-werks = i_final2-werks.
    i_final3-lgort = i_final2-lgort.
    i_final3-charg = i_final2-charg.
    i_final3-menge = i_final2-menge.
    i_final3-meins = i_final2-meins.
         mqty1 LIKE mseg-menge,        "MILD STEEL SCRAP
         mqty2 LIKE mseg-menge,        "PIG IRON
         mqty3 LIKE mseg-menge,        "FOUNDRY RETURN NORMAL
         mqty4 LIKE mseg-menge,        "CALCINED PETROLEUM COK
         mqty5 LIKE mseg-menge,        "FERRO SILICON
         mqty6 LIKE mseg-menge,        "FERRO MANGANESE
         mqty7 LIKE mseg-menge,        "COPPER SCRAP
    i_final3-prueflos = i_final2-prueflos.            "inspection lot number
    i_final3-merknr = i_final2-merknr.                "inspection characteristic no
    i_final3-kurztext = i_final2-kurztext.            "short text of characteristic
    i_final3-qc_c = i_final2-qc_c.
    i_final3-qc_mn = i_final2-qc_mn.
    i_final3-qc_ni = i_final2-qc_ni.
    APPEND i_final3.
    CLEAR i_final3.
  ENDLOOP.
  LOOP AT i_final3.
    indx2 = sy-tabix.
loop at i_final2 where aufnr = i_final3-aufnr and
                       bwart = '261'.
if i_final3-bwart = '101'.
i_final3-mqty1 = i_final2-mqty1.
i_final3-mqty2 = i_final2-mqty2.
i_final3-mqty3 = i_final2-mqty3.
i_final3-mqty4 = i_final2-mqty4.
i_final3-mqty5 = i_final2-mqty5.
i_final3-mqty6 = i_final2-mqty6.
i_final3-mqty7 = i_final2-mqty7.
endif.
endloop.
modify i_final3 index indx2.
endloop.
PERFORM build_fieldcat.
END-OF-SELECTION.
  DATA : v_repid LIKE sy-repid.
  v_repid = sy-repid.
  CALL FUNCTION 'REUSE_ALV_GRID_DISPLAY'
   EXPORTING
  I_INTERFACE_CHECK                 = ' '
  I_BYPASSING_BUFFER                = ' '
  I_BUFFER_ACTIVE                   = ' '
     i_callback_program                = v_repid
  I_CALLBACK_PF_STATUS_SET          = ' '
  I_CALLBACK_USER_COMMAND           = ' '
  I_CALLBACK_TOP_OF_PAGE            = ' '
  I_CALLBACK_HTML_TOP_OF_PAGE       = ' '
  I_CALLBACK_HTML_END_OF_LIST       = ' '
  I_STRUCTURE_NAME                  =
  I_BACKGROUND_ID                   = ' '
  I_GRID_TITLE                      =
  I_GRID_SETTINGS                   =
  IS_LAYOUT                         =
     it_fieldcat                       = i_fieldcat
  IT_EXCLUDING                      =
  IT_SPECIAL_GROUPS                 =
  IT_SORT                           =
  IT_FILTER                         =
  IS_SEL_HIDE                       =
  I_DEFAULT                         = 'X'
  I_SAVE                            = ' '
  IS_VARIANT                        =
  IT_EVENTS                         =
  IT_EVENT_EXIT                     =
  IS_PRINT                          =
  IS_REPREP_ID                      =
  I_SCREEN_START_COLUMN             = 0
  I_SCREEN_START_LINE               = 0
  I_SCREEN_END_COLUMN               = 0
  I_SCREEN_END_LINE                 = 0
  I_HTML_HEIGHT_TOP                 = 0
  I_HTML_HEIGHT_END                 = 0
  IT_ALV_GRAPHICS                   =
  IT_HYPERLINK                      =
  IT_ADD_FIELDCAT                   =
  IT_EXCEPT_QINFO                   =
  IR_SALV_FULLSCREEN_ADAPTER        =
IMPORTING
  E_EXIT_CAUSED_BY_CALLER           =
  ES_EXIT_CAUSED_BY_USER            =
    TABLES
      t_outtab                          = i_final3.
EXCEPTIONS
  PROGRAM_ERROR                     = 1
  OTHERS                            = 2
  IF sy-subrc <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
        WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
  ENDIF.
*&      Form  BUILD_FIELDCAT
      text
-->  p1        text
<--  p2        text
FORM build_fieldcat .
  PERFORM field_create USING 'AUFNR' 'Production Order' 'Prod.Ord' 1 15.
  PERFORM field_create USING 'GSTRP' 'Basic Start date' 'St. Date' 2 10.
  PERFORM field_create USING 'GLTRP' 'Basic End date' 'End. Date' 3 10.
  PERFORM field_create USING 'MBLNR' 'Material Documnet' 'Mat.Doc' 4 10.
PERFORM field_create USING 'BWART' 'Movement type' 'Mvmt. type' 5 3.
  PERFORM field_create USING 'MATNR' 'Material' 'Material' 6 10.
  PERFORM field_create USING 'WERKS' 'Plant' 'Plant' 7 4.
PERFORM field_create USING 'LGORT' 'Storage Location' 'St. Loc' 8 5.
  PERFORM field_create USING 'CHARG' 'Batch number' 'Batch. No' 9 5.
  PERFORM field_create USING 'MENGE' 'Quantity' 'Qty.' 10 13.
PERFORM field_create USING 'MEINS' 'Base unit of measure' 'Unit of measure' 11 3.
  PERFORM field_create USING 'MQTY1' 'MILD STEEL SCRAP' 'MS SCRAP' 12 13.
  PERFORM field_create USING 'MQTY2' 'PIG IRON' 'PIG IRON' 13 13.
  PERFORM field_create USING 'MQTY3' 'FOUNDRY RETURN NORMAL' 'FOUNDRY RET' 14 13.
  PERFORM field_create USING 'MQTY4' 'CALCINED PETROLEUM COK' 'CAL PETROLEUM' 15 13.
  PERFORM field_create USING 'MQTY5' 'FERRO SILICON' 'FERRO SIL' 16 13.
  PERFORM field_create USING 'MQTY6' 'FERRO MANGANESE' 'FERRO MANG' 17 13.
  PERFORM field_create USING 'MQTY7' 'COPPER SCRAP' 'COPPER SCRAP' 18 13.
  PERFORM field_create USING 'QC_C' 'QC_C' 'QC_C' 19 25.
  PERFORM field_create USING 'QC_MN' 'QC_MN' 'QC_MN' 20 25.
  PERFORM field_create USING 'QC_NI' 'QC_NI' 'QC_NI' 21 25.
ENDFORM.                    " BUILD_FIELDCAT
*&      Form  FIELD_CREATE
      text
     -->P1   text
     -->P2   text
     -->P3      text
     -->P4     text
FORM field_create  USING    value(p1)
                            value(p2)
                            value(p3)
                            value(p4)
                            value(p5).
  w_fieldcat-fieldname   = p1.
  w_fieldcat-seltext_l   = p2.
  w_fieldcat-seltext_m   = p3.
  w_fieldcat-col_pos     =  p4.
  w_fieldcat-outputlen = p5.
*w_fieldcat-no_zero = 'X'.
  APPEND w_fieldcat TO i_fieldcat.
  CLEAR  w_fieldcat.
  CLEAR : p1, p2, p3, p4, p5.
ENDFORM.                    " FIELD_CREATE
Edited by: uday madhav chebrolu on May 20, 2008 2:02 PM

Answer 1

There are so many mistakes in the code:
1) Don't declare data using TABLE statement, it brings the table into buffer, is not good performance wise.
2)Don't use LIKE statements, use TYPE declarations.LIKE statement is obsolete.
3)Modularize the code using SUBROUTINES.
4)Use PARALLEL SURSOR when there are nested loops.
5)Use read statement with addition of BINARY SEARCH