Javascript code needed for "Add to Favorites" icon in Webhelp using RH8

Question

Hi,
  I have a huge problem in making the add to favorites icon click event associate with the appropriate code.
This was the code i used in the Inline Javascript tab:
<script type="text/javascript" language="JavaScript" src="showhide.js"></script>
<input type="image" value="Add to Favorites" onclick="window.external.AddFavorite(location.href, document.title);return false"
/="" name="AddTopicToFavorites_selected.gif"  src="AddTopicToFavorites_selected.gif"  
<script type="text/javascript">var BookmarkURL="http://www.geekpedia.com"
var BookmarkTitle="Geekpedia"
// If the browser is Internet Explorer
if (document.all)
  // Add to Favorites (Internet Explorer)
    window.external.AddFavorite(BookmarkURL,BookmarkTitle)
      else
              // Add to Bookmarks (Mozilla Firefox)
              window.sidebar.addPanel(BookmarkTitle, BookmarkURL, '');
      }</script>
Also in the onclick in the Edit tab, i wrote: window.external.AddFavorite(BookmarkURL,BookmarkTitle)
It loads the add to favorites window very well as in any IE..But since the static word Geekpedia is being used, it displays the same and also navigates to the static URL http://www.geekpedia.com".
I want to make it work dynamically...Please help me with any code change if any one has tried this before.
One other thing that got messed up with was this icon replaced all other icons in the output....but...if i viewed the whskin_tbars.htm, i could see that the default icons appeared below somwhere...and there was this Add to Favorites icon appearing at the top...I dont know why these icons have got misplaced,,,i want to align them all in the same line..
Please help me with this.....
-Nanditha

Answer 1

Hi,
A long story, but I will need some more time to sort this out:
Simple solutions:
     - Change the var BookmarkURL="http://www.geekpedia.com" to your own URL, such as: var BookmarkURL="http://myhelp.com"
     - Change the var BookmarkTitle="Geekpedia" to your name, such as: var BookmarkTitle="My help system"
     - Do not insert an image trough the javascript tab, add it using the image options with the custom toolbar items popup. This will probably solve your image problem.
If you want to the URL dynamic, you need document.location.href, such as: var BookmarkURL = document.location.href; This however will get the adress of the current frame, which is whskin_tbars.htm.
If you want to get the Title dynamic, you will need document.getElementsByTagName('title')[0]; and then you need to retrieve the title, as: xxx.firstChild.data,: such as:
     - var BookmarkGet = document.getElementsByTagName('title')[0];
     - var BookmarkTitle = BookmarkGet.firstChild.data;
This always gets the URL and the Title of the frame you inserted the script in, which for the button toolbar is whskin_tbar.htm. When you insert this in any give topic, your bookmark will work fine, but will only call the topic, and not your skin.
If you only want the URL of your helpsystem, I suggest you just change the  variables BookmarkURL and BookmarkTitle.
If you want to target the current topic from any other location, such as the title bar, you need to address the top frame and then the topic. I don't know which frame this is, but I will look into it. This may take me some time though, but perhaps someone else knows which frames to address.
Example for getting the url of your helpsystem dynamically:
var BookmarkURL= this.parent.document.location.href;
//Your projects main file does not have a title, so don't get it dynamically.
var BookmarkTitle="My help system"
// If the browser is Internet Explorer
if (document.all)
  // Add to Favorites (Internet Explorer)
    window.external.AddFavorite(BookmarkURL,BookmarkTitle)
      else
              // Add to Bookmarks (Mozilla Firefox)
              window.sidebar.addPanel(BookmarkTitle, BookmarkURL, '');
Long story, if you have any further questions, just ask.
Greets,
Willam