JTable Numeric cell editor

Does anybody can post very simple cell renderer or cell editor class.
I need i my table for example in the second column in all rows possible to enter only digits (0...9) for example 125689 but 4578f78 is not valid.
Pointer should stay at editable cell until user enter valid value.
Thanks a lot

Hello, yes it is good example thanks.
But i need some how to inform user that he entering bad value.
Now user cant leave cell until enter proper value.
I need some how to show InputDialog when user wants to leave a cell and he must shoose edit or leave if leave need to restore value as was before.

Similar Messages

JTable custom cell editor focus problem

Hi I have created a JTable (using Java 1.4.2) and have three cell Editors, one is a JFormattedTextField, one is a JComboBox and one is a custom cell editor.
When I press tab I can select the cell with the JFormattedTextField and when I start typing the JFormattedTextField accepts my input and it is displayed in the cell. This is the type of behaviour I would like but it does not seem to work for my other 2 cell editors:
When I tab to the JComboBox cell I can see that the cell is selected but typing or using the arrow keys does not allow me to select a new value in the JComboBox. (I have also tried typing space or enter to activate the JComboBox whilst the cell is selected.) The only ways to select a new value at the moment is to first click on the cell with the mouse and then use the keyboard to select a new value. It is like the actual JComboBox is not receiving the focus? Does anyone know how to solve this problem?
I also seem to have the same problem with my custom cell editor. My custom editor is a JPanel which contains JFormattedTextField again I can tab to the cell and see that it is selected but to activate the JFormattedTextField I have to actually select it with the mouse.
I have been stuck on this for some time so if any one has any suggestions they would be much appreciated !

Hi I have created a JTable (using Java 1.4.2) and have three cell Editors, one is a JFormattedTextField, one is a JComboBox and one is a custom cell editor.
When I press tab I can select the cell with the JFormattedTextField and when I start typing the JFormattedTextField accepts my input and it is displayed in the cell. This is the type of behaviour I would like but it does not seem to work for my other 2 cell editors:
When I tab to the JComboBox cell I can see that the cell is selected but typing or using the arrow keys does not allow me to select a new value in the JComboBox. (I have also tried typing space or enter to activate the JComboBox whilst the cell is selected.) The only ways to select a new value at the moment is to first click on the cell with the mouse and then use the keyboard to select a new value. It is like the actual JComboBox is not receiving the focus? Does anyone know how to solve this problem?
I also seem to have the same problem with my custom cell editor. My custom editor is a JPanel which contains JFormattedTextField again I can tab to the cell and see that it is selected but to activate the JFormattedTextField I have to actually select it with the mouse.
I have been stuck on this for some time so if any one has any suggestions they would be much appreciated !

JTable & custom cell editor

Hello everyone,
what is the correct way of writing a custom cell editor for a JTable? I followed the example in the Java tutorial ([How to use tables|http://java.sun.com/docs/books/tutorial/uiswing/components/table.html#editor]), but the result is a bit weird. The code I have is the following:
    private class NumericCellEditor extends AbstractCellEditor implements TableCellEditor {
        NumericFTField field = new NumericFTField(threeDecimalsFormat, 3, null, 1);
        public Component getTableCellEditorComponent(JTable table, Object value,
                boolean isSelected, int row, int col) {
            field.setValue(value);
            return field;
        public Object getCellEditorValue() {
            return field.getValue();
        @Override
        public boolean stopCellEditing() {
            if (((NumericFTField)field).verifyDouble()) {
                field.setBorder(new EmptyBorder(0, 0, 0, 0));
                fireEditingStopped();
                return true;
            } else {
                field.setBorder(BorderFactory.createLineBorder(Color.red));
                return false;
    }where the NumericFTField is a class derived from JFormattedTextField that only allows digits, decimal separator, minus and 'E' to be inserted, and it monitors clipboard operations. verifyDouble() is a method of the NumericFTField class that verifies whether the current input can be parsed to a double and whether it satisfies everything it should. This is then used in
((TableColumn)jTblSpecs.getColumnModel().getColumn(1)).setCellEditor(new NumericCellEditor());The NumericFTField class works great, I use it also in place of a JTextFields, so I'd say there is nothing wrong with it.
After I click in a cell (single click), it behaves a little different that the default cell editor: the cell is not highlighted, but it immediately jumps to the editing state (why???). I, indeed, can insert the allowed characters only. When I click in a cell, do some editing and press Enter, the cell's content gets validated. If it is invalid, stopCellEditing() method does its magic; if it is valid, the caret disappears and everything SEEMS okay. However, if I started typing at this point, the cell reverts to the editing state, but now I am able to enter any character I want. It truly looks like the cell editor is now some other component, not the original NumericFTField one. What is going on here?
It would be great is someone could provide a short schematic source of a custom cell editor class that would work exactly as the JTable's default one except it would only permit digits and so on. It doesn't have to be anything fancy, just a "skeleton" of the class with comments like "input verification here" etc.
I am sorry for any lack of clarity, but I am still a Java newbie.
Any help would be much appreciated.
Best regards,
vt

Hi,
I am also facing the same problem. In addition to what you have specified, my requirement is to be able to select multiple rows for deletion. But, the very first row selected using mouse is not visible as selected though its selected. The other rows are visible as selected.
If you can use any JDK version, start using JDK1.6. You will not be facing this problem. There were so many changes done for swings from JDK 1.4 to 1.6. But, I have to strictly use JDK1.4, but could not find any workaround for this problem.
It would be great if anyone can help me out in this issue to get workaround for this problem.

JTable Custom Cell Editor: how to get value?

I have some custom cell renderers and editor. One of my custom cell editor is a text field that can popup a separat gui for easier data selection. As this text field alone with the popup gui works great, when i use this field in my custom jtable cell editor, the gui selected value is never displayed in the table cell. it just shows the old value.?

Well, here's how I do it. I'm very new to Swing so I'm, not sure if this is the best way. If you find a better way, please repost on this message.
My cell editor is a JPanel with a JTextfield in it. I make sure that the JTextfield will have default focus when the JPanel is focused.
In the CellEditor, I add a KeyListener to the JTextField so that when the user hits enter, it fires the stopEditing. I then add a function to CellEditor that returns what's in the JTextField.
In the code, m_value is the JTextField. You want to add MyKeyAdapter to the JTextField. Viola, it works!
      * This private class reads in an enter key.
     class MyKeyAdapter extends KeyAdapter {
          public void keyPressed(KeyEvent e) {
               if (e.getKeyCode() == KeyEvent.VK_ENTER) {
                    stopCellEditing();
      * Returns the value of the editor
      * @return the value of the editor
     public String getValue() {
          return m_value.getText();

JTable custom cell editor losing focus

This is a followup to Re: Tutorial on AWT/Swing control flow wherein I ask for pointers to help me understand the source of focus-loss behaviour in my JTable's custom cell editor.
I have done some more investigations and it turns out that the focus loss is a more general problem with custom cell editors which call other windows. Even the color-picker demo in the JTable tutorial at http://download.oracle.com/javase/tutorial/uiswing/examples/components/index.html#TableDialogEditDemo has this problem, IF you add a text field or two to the layout BEFORE the table. The only reason the table in the demo doesn't lose the focus when the color-picker comes out is because the table is the only thing in the window!
Here is the demo code, augmented with two text fields, which are admittedly ugly here but which serve the desired purpose:
* Copyright (c) 1995, 2008, Oracle and/or its affiliates. All rights reserved.
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*   - Redistributions of source code must retain the above copyright
*     notice, this list of conditions and the following disclaimer.
*   - Redistributions in binary form must reproduce the above copyright
*     notice, this list of conditions and the following disclaimer in the
*     documentation and/or other materials provided with the distribution.
*   - Neither the name of Oracle or the names of its
*     contributors may be used to endorse or promote products derived
*     from this software without specific prior written permission.
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
* IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
* LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import javax.swing.*;
import javax.swing.border.Border;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableCellEditor;
import javax.swing.table.TableCellRenderer;
import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
public class TableDialogEditDemo extends JPanel {
    public class ColorEditor extends AbstractCellEditor
            implements TableCellEditor,
            ActionListener {
        Color currentColor;
        JButton button;
        JColorChooser colorChooser;
        JDialog dialog;
        protected static final String EDIT = "edit";
        public ColorEditor() {
            //Set up the editor (from the table's point of view), which is a button.
            //This button brings up the color chooser dialog, which is the editor from the user's point of view.
            button = new JButton();
            button.setActionCommand(EDIT);
            button.addActionListener(this);
            button.setBorderPainted(false);
            //Set up the dialog that the button brings up.
            colorChooser = new JColorChooser();
            dialog = JColorChooser.createDialog(button, "Pick a Color", true, //modal
                    colorChooser, this, //OK button handler
                    null); //no CANCEL button handler
         * Handles events from the editor button and from the dialog's OK button.
        public void actionPerformed(ActionEvent e) {
            if (EDIT.equals(e.getActionCommand())) {
                //The user has clicked the cell, so bring up the dialog.
                button.setBackground(currentColor);
                colorChooser.setColor(currentColor);
                dialog.setVisible(true);
                //Make the renderer reappear.
                fireEditingStopped();
            } else { //User pressed dialog's "OK" button
                currentColor = colorChooser.getColor();
        public Object getCellEditorValue() {
            return currentColor;
        public Component getTableCellEditorComponent(JTable table,
                                                     Object value,
                                                     boolean isSelected,
                                                     int row,
                                                     int column) {
            currentColor = (Color) value;
            return button;
    public class ColorRenderer extends JLabel
            implements TableCellRenderer {
        Border unselectedBorder = null;
        Border selectedBorder = null;
        boolean isBordered = true;
        public ColorRenderer(boolean isBordered) {
            this.isBordered = isBordered;
            setOpaque(true);
        public Component getTableCellRendererComponent(
                JTable table, Object color,
                boolean isSelected, boolean hasFocus,
                int row, int column) {
            Color newColor = (Color) color;
            setBackground(newColor);
            if (isBordered) {
                if (isSelected) {
                    if (selectedBorder == null) {
                        selectedBorder = BorderFactory.createMatteBorder(2, 5, 2, 5,
                                table.getSelectionBackground());
                    setBorder(selectedBorder);
                } else {
                    if (unselectedBorder == null) {
                        unselectedBorder = BorderFactory.createMatteBorder(2, 5, 2, 5,
                                table.getBackground());
                    setBorder(unselectedBorder);
            return this;
    public TableDialogEditDemo() {
        super(new GridLayout());
        JTextField tf1 = new JTextField("tf1");
        add(tf1);
        JTextField tf2 = new JTextField("tf2");
        add(tf2);
        JTable table = new JTable(new MyTableModel());
        table.setPreferredScrollableViewportSize(new Dimension(500, 70));
        table.setFillsViewportHeight(true);
        JScrollPane scrollPane = new JScrollPane(table);
        table.setDefaultRenderer(Color.class,
                new ColorRenderer(true));
        table.setDefaultEditor(Color.class,
                new ColorEditor());
        add(scrollPane);
    class MyTableModel extends AbstractTableModel {
        private String[] columnNames = {"First Name",
                "Favorite Color",
                "Sport",
                "# of Years",
                "Vegetarian"};
        private Object[][] data = {
                {"Mary", new Color(153, 0, 153),
                        "Snowboarding", new Integer(5), new Boolean(false)},
                {"Alison", new Color(51, 51, 153),
                        "Rowing", new Integer(3), new Boolean(true)},
                {"Kathy", new Color(51, 102, 51),
                        "Knitting", new Integer(2), new Boolean(false)},
                {"Sharon", Color.red,
                        "Speed reading", new Integer(20), new Boolean(true)},
                {"Philip", Color.pink,
                        "Pool", new Integer(10), new Boolean(false)}
        public int getColumnCount() {
            return columnNames.length;
        public int getRowCount() {
            return data.length;
        public String getColumnName(int col) {
            return columnNames[col];
        public Object getValueAt(int row, int col) {
            return data[row][col];
        public Class getColumnClass(int c) {
            return getValueAt(0, c).getClass();
        public boolean isCellEditable(int row, int col) {
            if (col < 1) {
                return false;
            } else {
                return true;
        public void setValueAt(Object value, int row, int col) {
            data[row][col] = value;
            fireTableCellUpdated(row, col);
    private static void createAndShowGUI() {
        JFrame frame = new JFrame("TableDialogEditDemo");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        JComponent newContentPane = new TableDialogEditDemo();
        newContentPane.setOpaque(true);
        frame.setContentPane(newContentPane);
        frame.pack();
        frame.setVisible(true);
    public static void main(String[] args) {
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                createAndShowGUI();
}When you come back from choosing a color, tf1 is given the focus, instead of the table. This is because bringing the color picker window to the front causes a focus lost event for the cell editor component; it's temporary, as it should be, so why on earth is the system losing track of who has focus in the window??
I see the following in Window#getMostRecentFocusOwner():
public Component getMostRecentFocusOwner()
    if (isFocused())
      return getFocusOwner();
    else
      Component mostRecent =
        KeyboardFocusManager.getMostRecentFocusOwner(this);
      if (mostRecent != null)
        return mostRecent;
      else
        return (isFocusableWindow())
               ? getFocusTraversalPolicy().getInitialComponent(this)
               : null;
}My app has a custom focus traversal policy, so I'm able to see who is being called, and indeed, getInitialComponent() is being called. Clearly, the KeyboardFocusManager is actually losing track of the fact that the table was focussed at the point where control was transferred to the color picker! This strikes me as completely unreasonable, especially since, as noted, this is a temporary focus loss event, not a permanent one.
I'd be grateful for any wisdom in solving this, since similar behaviour to this little demo -- without focus loss, naturally -- is an essential part of my application.

Looks like it is because the 'restore-focus-to-previous-after-modal-dialog-close' is in a later event than when the control returns to the action performed (which I guess makes sense: it continues the action event handler and the focus events are handled later, but I needed two chained invoke laters so it might also be that the OS events comes later).
The following works for me (in the actionPerformed edited):
           // create the dialog here so it is correctly parented
           // (otherwise sometimes OK button not correctly the default button)
           dialog = JColorChooser.createDialog(button, "Pick a Color", true, //modal
                        colorChooser, this, //OK button handler
                        null); //no CANCEL button handler
                //The user has clicked the cell, so bring up the dialog.
                button.setBackground(currentColor);
                colorChooser.setColor(currentColor);
                button.addFocusListener(new FocusListener() {
                    @Override
                    public void focusLost(FocusEvent e) {}
                    @Override
                    public void focusGained(FocusEvent e) {
                        // dialog closed and focus restored
                        button.removeFocusListener(this);
                        fireEditingStopped();
                dialog.setVisible(true);but a simpler request might be better (althoug I still need an invoke later):
// rest as before except the FocusListener
                dialog.setVisible(true);
                button.requestFocusInWindow();
                EventQueue.invokeLater(new Runnable() {
                    public void run() {
                        fireEditingStopped();
                });And a quick fix to the renderer so you can actualy see the focus on it:
                if(hasFocus) {
                    Border border = DefaultLookup.getBorder(this, ui, "Table.focusCellHighlightBorder");
                    setBorder(BorderFactory.createCompoundBorder(
                            border, BorderFactory.createMatteBorder(1, 4, 1, 4,
                                    ((MatteBorder) getBorder()).getMatteColor())));
                }

JTable - Custom cell editor lossing commit

Hello,
I have a custom cell editor and a default renderer assigned to a specific cell in my table...
I have the following problem :
If i change the value of cell 'c1' from value 'v1' to 'v2' and press enter and go to another cell the value in 'c1' is rendered correctly as 'v2'
Hoever if i change the value of cell 'c1' from 'v1' to 'v2' and simply click over to another cell the value in 'c1' stays rendered as 'v1'
Question : Is there ANY way to mimic the behavior of the user pressing enter in my custom cell editor when a user simply selects another cell, i guess on loss of focus or something..
This is the last problem i have on the current project i am on and its very annoying.
Thanks in advance, any help appreciated..
-Alan

I have the same problem using a custom Date/Time Picker Object (which extends JComboBox) as an editor within a table cell. For simplicity sake, I am posting code using only the base editable JComboBox, but it exhibits the same symptoms. If you enter a value in the TextField portion of the ComboBox and Tab, your value remains the same. If you enter a value in the TextField portion of the ComboBox and click in another cell, the value returns to the previous value (before editing began).
import java.awt.*;                                                  // BorderLayout
import javax.swing.*;                                               // JTable, JFrame
import javax.swing.table.*;                                         // DefaultTableModel
public class Tester extends JFrame
public static void main(String[] args)
    Tester test = new Tester();
public Tester()
    String[] values = {"Test", "Values"};
    JComboBox combo = new JComboBox(values);
    combo.setEditable(true);
    DefaultCellEditor editor = new DefaultCellEditor(combo);
    JTable table = new JTable(2, 3);
    table.getColumn(table.getColumnName(0)).setCellEditor(editor);
    JScrollPane scroll = new JScrollPane(table);
    getContentPane().add(scroll, BorderLayout.CENTER);
    pack();
    setVisible(true);
}

JTable Custom Cell Editor "focus through keyboard" question (SSCCE included

I was trying to use two components in a table cell. The first was JTextField and second the JButton. Everything works fine, except when it comes to editing the JTextfield using keyboard instead of mouse. When I use tab key to go to the custom cell, I can see that the focus is on the cell (as can be visible from background color). But when I try to edit the cell using F2 or directly entering text, nothing gets entered. If I use the mouse to go to particular cell, it works fine. Here is SSCCE. Try the following.
1. Use mouse key to select first cell for editing. Edit the cell. Everything normal.
2. Use the tab key to go to the first cell. Try to edit cell either by entering directly for after using F2. Can't get the typed text into the JTextfield.
package com.ns;
import java.awt.BorderLayout;
import java.awt.Component;
import java.awt.Dimension;
import java.awt.Point;
import java.awt.Toolkit;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.DefaultCellEditor;
import javax.swing.JButton;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.JTextField;
import javax.swing.UIManager;
import javax.swing.WindowConstants;
import javax.swing.table.DefaultTableModel;
import javax.swing.table.TableCellRenderer;
public class TextButtonCellFrame extends javax.swing.JFrame {
    // Variables declaration - do not modify
    private JScrollPane jScrollPane1;
    private JPanel testPanel;
    private JTable testTable;
    // End of variables declaration
    public TextButtonCellFrame() {
        initComponents();
    @SuppressWarnings("unchecked")
    // <editor-fold defaultstate="collapsed" desc="Generated Code">
    private void initComponents() {
        testPanel = new JPanel();
        jScrollPane1 = new JScrollPane();
        testTable = new JTable();
        setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
        testTable.setModel(new DefaultTableModel(
            new Object [][] {
                {null, null, null, null},
                {null, null, null, null},
                {null, null, null, null},
                {null, null, null, null}
            new String [] {
                "Title 1", "Title 2", "Title 3", "Title 4"
        testTable.setRowHeight(20);
        testTable.getColumnModel().getColumn(0).setCellRenderer(new MyTableCellRenderer());
        testTable.getColumnModel().getColumn(0).setCellEditor(new MyTableCellEditor());
        testTable.getColumnModel().getColumn(0).setPreferredWidth(200);
        jScrollPane1.setViewportView(testTable);
        testPanel.add(jScrollPane1);
        getContentPane().add(testPanel, BorderLayout.CENTER);
        Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
        setBounds((screenSize.width-496)/2, (screenSize.height-330)/2, 496, 330);
    }// </editor-fold>
    public static void main(String args[]) {
        java.awt.EventQueue.invokeLater(new Runnable() {
            public void run() {
                new TextButtonCellFrame().setVisible(true);
    public class MyTableCellRenderer extends JPanel implements TableCellRenderer {
        Point point;
        JButton button1 = new JButton("Test 1");
        JTextField txtField = new JTextField();
        public MyTableCellRenderer() {
            setLayout(new BorderLayout());
            this.add(button1, BorderLayout.EAST);
            this.add(txtField,BorderLayout.CENTER);
        public Component getTableCellRendererComponent(JTable table, Object value,
                boolean isSelected, boolean hasFocus, int rowIndex, int vColIndex) {
            if (isSelected) {
                txtField.setBackground(testTable.getSelectionBackground());
                txtField.setBorder(UIManager.getBorder("Table.focusCellHighlightBorder"));
            else {
                txtField.setBackground(testTable.getBackground());
                txtField.setBorder(null);
            return this;
    public class MyTableCellEditor extends DefaultCellEditor
                                    implements ActionListener {
        JPanel panel = new JPanel();
        JButton button1 = new JButton ("Test 1");
        JTextField txtField = new JTextField();
        MyTableCellEditor() {
            super (new JTextField());
            button1.addActionListener(this);
            panel.setLayout(new BorderLayout());
            panel.add(button1, BorderLayout.EAST);
            panel.add(txtField,BorderLayout.CENTER);
        public void actionPerformed(ActionEvent e) {
            if (e.getSource() == button1)
                JOptionPane.showMessageDialog(null, "Action One Successful");
        public Component getTableCellEditorComponent(JTable table, Object value,
                                    boolean isSelected, int row, int column) {
            txtField.requestFocusInWindow();
            return panel;
}regards,
nirvan.

I don't know what's better:
import java.awt.*;
import java.awt.event.*;
import java.util.EventObject;
import javax.swing.*;
import javax.swing.table.*;
public class TextButtonCellFrame extends JFrame {
JTable testTable = new JTable();
public TextButtonCellFrame() {
    testTable.setModel(new DefaultTableModel(
      new Object [][] {
        {null, null, null, null},
        {null, null, null, null}
      new String [] { "1", "2", "3", "4" }
    testTable.setRowHeight(20);
    testTable.getColumnModel().getColumn(0).setCellRenderer(
      new MyTableCellRenderer());
    testTable.getColumnModel().getColumn(0).setCellEditor(
      new MyTableCellEditor(new JTextField()));
    testTable.getColumnModel().getColumn(0).setPreferredWidth(200);
    getContentPane().add(new JScrollPane(testTable));
    setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
    setSize(480,320);
    setLocationRelativeTo(null);
public static void main(String args[]) {
    java.awt.EventQueue.invokeLater(new Runnable() {
      public void run() {
        new TextButtonCellFrame().setVisible(true);
public class MyTableCellRenderer extends JPanel
                implements TableCellRenderer {
    JButton button1 = new JButton("Test 1");
    JTextField txtField = new JTextField();
    public MyTableCellRenderer() {
      setLayout(new BorderLayout());
      this.add(button1, BorderLayout.EAST);
      this.add(txtField,BorderLayout.CENTER);
    public Component getTableCellRendererComponent(JTable table, Object value,
        boolean isSelected, boolean hasFocus, int rowIndex, int vColIndex) {
      if (isSelected) {
        txtField.setBackground(testTable.getSelectionBackground());
        txtField.setBorder(UIManager.getBorder("Table.focusCellHighlightBorder"));
      } else {
        txtField.setBackground(testTable.getBackground());
        txtField.setBorder(null);
      txtField.setText(value==null?"":value.toString());
      return this;
public class MyTableCellEditor extends DefaultCellEditor
                  implements ActionListener {
    JPanel panel = new JPanel(new BorderLayout());
    JButton button1 = new JButton ("Test 1");
    JTextField txtField; // = new JTextField();
    MyTableCellEditor(JTextField txtField) {
      super (txtField);
      this.txtField = txtField;
      button1.addActionListener(this);
      panel.add(button1, BorderLayout.EAST);
      panel.add(txtField,BorderLayout.CENTER);
    public void actionPerformed(ActionEvent e) {
      if (e.getSource() == button1)
        JOptionPane.showMessageDialog(null, "Action One Successful");
    public Component getTableCellEditorComponent(JTable table, Object value,
                  boolean isSelected, int row, int column) {
      txtField.setText(value==null?"":value.toString());
      SwingUtilities.invokeLater(new Runnable() {
        public void run() {
          txtField.requestFocusInWindow();
      return panel;
}

AutoComplete JComboBox As JTable cell editor

Hello, when I try to use AutoComplete JComboBox as my JTable cell editor, I facing the following problem
1) Exception thrown when show pop up. - Exception in thread "AWT-EventQueue-0" java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
2) Unable to capture enter key event.
Here is my complete working code. With the same JComboBox class, I face no problem in adding it at JFrame. But when using it as JTable cell editor, I will have the mentioned problem.
Any advice? Thanks
import javax.swing.*;
import javax.swing.JTable.*;
import javax.swing.table.*;
import java.awt.event.*;
* @author yccheok
public class NewJFrame extends javax.swing.JFrame {
    /** Creates new form NewJFrame */
    public NewJFrame() {
        initComponents();
                /* Combo Box Added In JFrame. Work as expected. */
                final JComboBox comboBox = new JComboBox();
                comboBox.addItem("Snowboarding");
                comboBox.addItem("Rowing");
                comboBox.addItem("Chasing toddlers");
                comboBox.setEditable(true);
                comboBox.getEditor().getEditorComponent().addKeyListener(new KeyAdapter() {
                   public void keyReleased(KeyEvent e) {
                       if(e.getKeyCode() == KeyEvent.VK_ENTER) {
                           System.out.println("is enter");
                           return;
                       System.out.println("typed");
                       comboBox.setSelectedIndex(0);
                       comboBox.showPopup();
                getContentPane().add(comboBox, java.awt.BorderLayout.SOUTH);
    public JTable getMyTable() {
        return new JTable() {
             Combo Box Added In JTable as cell editor. Didn't work as expected:
             1. Exception thrown when show pop up.
             2. Unable to capture enter key event.
            public TableCellEditor getCellEditor(int row, int column) {
                final JComboBox comboBox = new JComboBox();
                comboBox.addItem("Snowboarding");
                comboBox.addItem("Rowing");
                comboBox.addItem("Chasing toddlers");
                comboBox.setEditable(true);
                comboBox.getEditor().getEditorComponent().addKeyListener(new KeyAdapter() {
                   public void keyReleased(KeyEvent e) {
                       if(e.getKeyCode() == KeyEvent.VK_ENTER) {
                           System.out.println("is enter");
                           return;
                       System.out.println("typed");
                       comboBox.setSelectedIndex(0);
                       comboBox.showPopup();
                return new DefaultCellEditor(comboBox);
    /** This method is called from within the constructor to
     * initialize the form.
     * WARNING: Do NOT modify this code. The content of this method is
     * always regenerated by the Form Editor.
    // <editor-fold defaultstate="collapsed" desc=" Generated Code ">
    private void initComponents() {
        jScrollPane1 = new javax.swing.JScrollPane();
        jTable1 = getMyTable();
        setDefaultCloseOperation(javax.swing.WindowConstants.EXIT_ON_CLOSE);
        jTable1.setModel(new javax.swing.table.DefaultTableModel(
            new Object [][] {
                {null, null, null, null},
                {null, null, null, null},
                {null, null, null, null},
                {null, null, null, null}
            new String [] {
                "Title 1", "Title 2", "Title 3", "Title 4"
        jScrollPane1.setViewportView(jTable1);
        getContentPane().add(jScrollPane1, java.awt.BorderLayout.CENTER);
        pack();
    }// </editor-fold>
     * @param args the command line arguments
    public static void main(String args[]) {
        java.awt.EventQueue.invokeLater(new Runnable() {
            public void run() {
                new NewJFrame().setVisible(true);
    // Variables declaration - do not modify
    private javax.swing.JScrollPane jScrollPane1;
    private javax.swing.JTable jTable1;
    // End of variables declaration
}

You need to create a custom CellEditor which will prevent these problems from occurring. The explanation behind the problem and source code for the new editor can be found at Thomas Bierhance's site http://www.orbital-computer.de/JComboBox/. The description of the problem and the workaround are at the bottom of the page.

Help!!! JTable cell editor problem...

I am having a problem with table cell editors.
The problem is that when I click on another component
in the frame (out side of the JTable) the cell editors's
stopCellEditing() is not called so I get a JTable with a cell
editor in editing mode.
Any help?
Thanks a lot

It is difficult to tell what happens with FocusEvents when you are actually editing a cell and the editor is "up". I am experiencing different difficulties with the same root issue. I think the problem here is that the Java Focus Manager is consuming the focus event without propagating the event to any of the JTable components (CellEditor or JTable). I am not sure if this is exactly the case but I haven't been able to trap focus events in the Editors, Renderers or JTable anywhere. If the editor is not "up" then event handling seems to be fairly normal but when you are actually editing a cell it becomes tricky.
However, this is a problem I fixed by placing a FocusGained event handler on the other (non JTable) component and then manually stopping editing on the JTable. In other words in the JFrame (or whatever component you are using) I added a FocusListener to the non JTable component and inside of FocusGanied() I execute:
public void focusGained(FocusEvent e){
table.getCellEditor().stopEditing();
table.removeEditor();
You could, of course, use cancelEditing() as well. You'll probably want to wrap the code with some robustness as follows to ensure that you don't get trapped by wierdness.
public void focusGained(FocusEvent e){
if (table.isEditing() && table.getCellEditor() != null){
table.getCellEditor().stopEditing();
table.removeEditor();
This is probably not the only way to solve the problem but it was the way that worked when I encountered that issue.

Using a JPanel as cell editor in JTable

I have a composite component (JPanel that contains a JTextField and a
JButton) that I would like to use as the a cell editor in a JTable.The JButton instantiates a UI editor component that I have designed. Example would be date editor for dates, tet editor for strings etc. This editor allows the user to select a date to populate the JTextField (the date may also be manually entered).
I have no problem with the rendering of the component within the table.However, I would like for the JTextField embedded within the JPanel to receive focus and a visible caret, when using the tab key to navigate to the cell. After reading through some of the posts here , I was able to transfer the focus. But I dont see a visible caret. I am unable to edit. I have to click on the text box and then start typing. Its a great pain in the ass.
I have a custom designed table and custom designed editor. Code is attached...
<pre>
protected boolean processKeyBinding(KeyStroke ks, KeyEvent e,int condition, boolean pressed) {
final int selRow = getSelectedRow();
final int rowCount = getRowCount();
final int selCol = getSelectedColumn();
final EventObject obj = (EventObject) e;
if (selRow == -1) {
SwingUtilities.invokeLater(new Runnable() {
public void run() {
changeSelection(0, 1, false, false);
editCellAt(0, 1, obj);
boolean isSelected = false;
if ((ks == KeyStroke.getKeyStroke(KeyEvent.VK_TAB,0)) ||
(ks == KeyStroke.getKeyStroke(KeyEvent.VK_ENTER,0))) {
if (selCol == 1) {
isSelected= getCellEditor(selRow,selCol).stopCellEditing();
targetRow = (selRow + 1) % rowCount;
SwingUtilities.invokeLater(new Runnable() {
public void run() {
if (editCellAt(targetRow, 1, obj)) {
changeSelection(targetRow, 1, false, false);
getComponentAt(targetRow, 1).requestFocus();
} else {
getCellEditor(selRow, selCol).shouldSelectCell(obj);
return super.processKeyBinding(ks,e,condition,pressed);
</pre>
Relevant code of my custom editor is below....
public Component getTableCellEditorComponent(JTable table,
Object value, boolean isSelected, int row, int column) {
lastEditedRow = row;
lastEditedCol = column;
lastEditedTable = table;
lastEditedValue = value;
val = value;
((JTextField)editorComponent).
setText(val == null ? "" : val.toString());
setClickCountToStart(1);
if (value instanceof CycCollectionChooserModel) {
String collection = ((CycCollectionChooserModel)value).
getCollection().cyclify();
button.setVisible(EditorForCollectionMap.hasUIEditor(collection));
button.setMargin (new Insets (1,1,1,1));
button.setIconTextGap(0);
buttonListener.model = (CycCollectionChooserModel)value;
buttonListener.rowIndex = row;
buttonListener.localTable = table;
return panel;
public boolean isCellEditable(EventObject evt) {
if (evt instanceof MouseEvent) {
int clickCount;
clickCount = 1;
return ((MouseEvent)evt).getClickCount() >= clickCount;
return super.isCellEditable(evt);
public boolean stopCellEditing() {
if (super.stopCellEditing()) {
final int targetRow = (lastEditedRow+1)%lastEditedTable.getRowCount();
SwingUtilities.invokeLater(new Runnable() {
public void run() {
lastEditedTable.changeSelection(targetRow, 1, false, false);
lastEditedTable.getComponentAt(targetRow, 1).requestFocus();
return true;
return false;
Does any one know why I am not able to see the caret? Any insights you have will be most welcome.
Thanks in advance,
Praveen.

Almost solved the problem. Navigation through Tab key, up/ down arrow, Enter key works for text boxes. Navigation through Tab Key, Up/down arrow works for combo boxes. But for "Enter" key it doesnt. Changes in code ....
(I have added a key listener to my editor class)
<pre>
protected boolean processKeyBinding(KeyStroke ks, KeyEvent e,int condition, boolean pressed) {
final int selRow = getSelectedRow();
final int rowCount = getRowCount();
final int selCol = getSelectedColumn();
final EventObject obj = (EventObject) e;
if (selRow == -1) {
SwingUtilities.invokeLater(new Runnable() {
public void run() {
changeSelection(0, 1, false, false);
editCellAt(0, 1, obj);
boolean isSelected = false;
if ((ks == KeyStroke.getKeyStroke(KeyEvent.VK_TAB,0)) ||
(ks == KeyStroke.getKeyStroke(KeyEvent.VK_ENTER,0)) ||
(ks == KeyStroke.getKeyStroke(KeyEvent.VK_DOWN,0))) {
if (selCol == 1) {
final int targetRow = (selRow + 1) % rowCount;
getCellEditor(selRow,selCol).stopCellEditing();
SwingUtilities.invokeLater(new Runnable() {
public void run() {
editCellAt(targetRow, 1, obj);
changeSelection(targetRow, 1, false, false);
getComponentAt(targetRow, 1).requestFocus();
if ((ks == KeyStroke.getKeyStroke(KeyEvent.VK_UP,0))||
(ks == KeyStroke.getKeyStroke(KeyEvent.VK_TAB,1))) {
if (selCol == 1) {
final int targetRow = (selRow - 1) % rowCount;
getCellEditor(selRow,selCol).stopCellEditing();
SwingUtilities.invokeLater(new Runnable() {
public void run() {
editCellAt(targetRow, 1, obj);
changeSelection(targetRow, 1, false, false);
getComponentAt(targetRow, 1).requestFocus();
return super.processKeyBinding(ks,e,condition,pressed);
public class FactEditorComboBoxTableEditor extends DefaultCellEditor implements KeyListener{
//// Constructors
/** Creates a new instance of FactEditorComboBoxTableEditor. */
public FactEditorComboBoxTableEditor(JComboBox comboBox) {
super(comboBox);
JTextField TF =(JTextField)((ComboBoxEditor)comboBox.getEditor()).
getEditorComponent();
TF.addKeyListener(this);
public class FactEditorComboBoxTableEditor extends DefaultCellEditor implements KeyListener{
//// Constructors
/** Creates a new instance of FactEditorComboBoxTableEditor. */
public FactEditorComboBoxTableEditor(JComboBox comboBox) {
super(comboBox);
JTextField TF =(JTextField)((ComboBoxEditor)comboBox.getEditor()).
getEditorComponent();
TF.addKeyListener(this);
</pre>
P.S : viravan, help me solve this problem and you will get the rest of the dukes LOL

Problem in JTable with a JComboBox cell editor

Hi gurus,
Please help! I am having a problem with a JTable that has a JComboBox cell editor. When the table is first loaded, the combo box column displays correct data. But whenever I click the combo box, the selection will be set to the first item in the combo box list once the popup menu pops up even before I make any new selection. It is very annoying.
Here is how I set the cell editor:
populateComboBoxModel(); // populate the combo box model.
DefaultCellEditor cell_editor = new DefaultCellEditor(new JComboBox(
combo_model));
contrib_table.getColumnModel().getColumn(1).setCellEditor(
cell_editor);
I didn't set the cell renderer so I assume it is using the default cell renderer.
Thanks !

Not quite. The example doesn't have a different cell editor for each row of the table. I'm sure I must be missing something, bc I've found many references to the fact that this is possible to do. And I have most of it working. However, when I click on any given combobox, it automatically switches to the first value in the list, not the selected item. I've tried setting the selected item all over the code, but it has no effect on this behavior. Also, it only happens the first time I select a given cell. For example, suppose the first row has items A, B, and C, with B being the selected value. The table initially displays with B in this cell, but when I click on B, it switches to A when it brings up the list. If I select B, and move on to some other cell, and then go back and click on B again, it doesn't switch to A.
There seems to be a disconnect between the values that I display initially, and the values that I set as selected in the comboboxes. Either that, or it behaves as though I never set the selected item for the combobox at all.
Any help would be greatly appreciated.

JComboBox Cell Editor in JTable

I've scouered the forums for an answer to my question, and while
finding other valuable advice, I have yet to find an answer to my
question. But first, a little description:
I have a JTable consisting of 5 columns:
col1= standard Object cell editor
col2= JComboBox cell editor
col3= JComboBox cell editor, values dependent on col2
col4= JComboBox cell editor, values dependent on col3
col5= JComboBox cell editor, values dependent on col4
Data structure looks like this:
col1= company object, containing vector of values for col2
col2= lease object, containing vector of values for col3
col3= well object, containing vector of values for col4
col4= pump object, containing vector of values for col5
col5= simply displayed.
I have a JButton that adds a new row to the table via dialog, then menu
options to add entries to the comboboxes/vectors. The kicker here is
that everything is fine up until I've added a pump, and click the cell
to view the entry. In my cellEditor class, I have a 'getSelected()'
method that returns 'combobox.getSelectedIndex()'. When 'edittingStopped()'
is thrown for any cell in this column, I get a null pointer in my
getSelectedIndex() method of the lease combobox - only in this pump
column. Even the part column works correctly. Code snips:
public class MyApplication ... {
private TableColumn leaseColumn;
private TableColumn wellColumn;
private TableColumn pumpColumn;
private TableColumn partColumn;
private LeaseDropDown leaseDropDown;
private WellDropDown wellDropDown;
private PumpDropDown pumpDropDown;
private PartDropDown partDropDown;
private int currentLease = 0;
private int currentWell = 0;
private int currentPump = 0;
public MyApplication() {
    leaseColumn = pumpshopTable.getColumnModel().getColumn(1);
    leaseDropDown = new LeaseDropDown(companies);
    leaseColumn.setCellEditor(leaseDropDown);
    DefaultTableCellRenderer leaseRenderer =
      new DefaultTableCellRenderer();
    leaseRenderer.setToolTipText("Click for leases");
    leaseColumn.setCellRenderer(leaseRenderer);
    //... same for lease, well, pump, part ...
    leaseDropDown.addCellEditorListener(new CellEditorListener() {
      public void editingCanceled(ChangeEvent e) {
      } // end editingCanceled method
      public void editingStopped(ChangeEvent e) {
        updateCells();
      } // end editingStopped method
    }); // end addCellEditorListener inner class
    //.... same inner class for well, pump, part ...
} // end MyApplication constructor
public void updateCells() {
    currentLease = leaseDropDown.getSelectedLease();
    //... get current well, pump, part ...
    leaseDropDown = new LeaseDropDown(companies); // companies=Vector,col1
    leaseColumn.setCellEditor(leaseDropDown);
    //... same for lease, well, pump and part columns ...
} // end updateCells method
} // end MyApplication class
public class LeaseDropDown extends AbstractCellEditor
    implements TableCellEditor {
private Vector companiesVector;
private JComboBox leaseList;
public LeaseDropDown(Vector cVector) {
    companiesVector = cVector;
} // end LeaseDropDown constructor
public Component getTableCellEditorComponent(JTable table,
      Object value, boolean isSelected, int rowIndex, int vColIndex) {
    Company thisCompany = (Company) companiesVector.get(rowIndex);
    Vector leasesVector = (Vector) thisCompany.getLeases();
    leaseList = new JComboBox(leasesVector);
    return leaseList;
} // end getTableCellEditorComponent method
public Object getCellEditorValue() {
    return leaseList.getSelectedItem();
} // end getCellEditorValue method
public int getSelectedLease() {
    JOptionPane.showInputDialog("Selected lease is: " +
      leaseList.getSelectedIndex());
    return leaseList.getSelectedIndex();
} // end getSelectedLease method
} // end LeaseDropDown class... LeaseDropDown can be extrapolated to well, pump, and part,
handing well the selected lease, handing pump the selected
lease and well, handing part the selected lease, well and pump.
I guess my question is how do I get the selected comboboxitem (I'd
settle for the entire combobox if there's no other way) to fill in the
next column? Why does the way I have it now work for the first 2 combobox
columns and not the third?

I'll try to provide more details.
I use a JComboBox implementation as a cell in a JTable. The CombBox is editable . This is what I get when I try to type in something.
java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
at java.awt.Component.getLocationOnScreen_NoTreeLock(Component.java:1507)
at java.awt.Component.getLocationOnScreen(Component.java:1481)
at javax.swing.JPopupMenu.show(JPopupMenu.java:921)
at javax.swing.plaf.basic.BasicComboPopup.show(BasicComboPopup.java:177)
at javax.swing.plaf.basic.BasicComboBoxUI.setPopupVisible(BasicComboBoxUI.java:927)
at javax.swing.JComboBox.setPopupVisible(JComboBox.java:790)
at javax.swing.JComboBox.showPopup(JComboBox.java:775)
I read some related bugs on the sun site but I am not sure if this is a bug and if it is then has it been fixed or work-around provided.
any insights ??

Problem using an editable JComboBox as JTable cell editor

Hi,
i have a problem using an editable JComboBox as cell editor in a JTable.
When i edit the combo and then I press the TAB or ENTER key then all works fine and the value in the TableModel is updated with the edited one, but if i leave the cell with the mouse then the value is not passed to the TableModel. Why ? Is there a way to solve this problem ?
Regards
sergio sette

if (v1.4) [url
http://java.sun.com/j2se/1.4.2/docs/api/javax/swing/JTa
le.html#setSurrendersFocusOnKeystroke(boolean)]go
hereelse [url
http://forum.java.sun.com/thread.jsp?forum=57&thread=43
440]go here
Thank you. I've also found this one (the first reply): http://forum.java.sun.com/thread.jsp?forum=57&thread=124361 Works fine for me.
Regards
sergio sette

JTable: RFC on good practice (SQL queries from cell editor)

I usually add/remove/edit JTable data from an external panel. But in this scenario, my client would like to be able to click on the first column of an empty row and enter a product number. Within the cell editor, I must make an SQL query to the database in order to determine if the product number is valid and if so, use part of the SQL data to populate other cells of the current row (like product description).
My problem is that this just doesn't seem right! Isn't the cell editor executed on the only Swing thread? Also, if the product number is not valid, I correctly implement the stopCellEditing() method but for some reason, you can still navigate the table (click on any other cell or press the TAB key, etc)... weird!!
Does anyone have a good practice on how to perform the SQL query in a better place and force a cell to be selected until you enter a valid number or press the CANCEL key?
I was looking at implementing the TableModelListener's tableChanged(...) method but I'm not sure if that would be a better place either.
I personally would edit outside of the table, but good practice seems hard when the requirement is to edit from a cell editor!!
Any suggestion would be greatly appreciated!
Thanks!

maybe you could write an input verifier for the column that does the query and rejects invalid entries.
maybe you could send the query off in a worker thread.
as far as making the table so you can't select any cells, hmm. not sure.
you could disable
.setEnabled(false);the table until the query comes back, something like that.

Custom JTable cell editors and persistence

I have a JTable with an underlying data model (an extension of AbstractTableModel) that uses custom cell editors in the last column. The cell editor in that column, for a given row, depends on the value selected in another column of the same row. The cell editors include text, date, list, and tree editors (the last one in a separate dialogue). The number of rows is changeable.
I have need to persist the data for a populated table from time to time, for restoration later on. I've achieved that, such that the data model is recreated, the table appears correct, and the appropriate cell editors activated (by creating new instances of the editors' classes).
However, my problem is that the (custom) cell editors do not reflect the data in the model when editing mode is begun the first time after restoration. Eg. the text editor is always empty, the list editor shows the first item, and no node is selected in the tree editor.
If I've restored the model correctly, should the editors properly reflect the underlying data when they are set to editing mode?
I suspected not, and thus tried to explicitly 'set' the correct values immediately after each editor is recreated ... but to no avail.
Does anyone have any thoughts, or experience with something similar? I'm happy to supply code.

You can use html tags within Swing, so I think you can do the following:
* MyRenderer.java
* Created on 26 April 2007, 10:27
* To change this template, choose Tools | Template Manager
* and open the template in the editor.
package newpackage;
import java.awt.Component;
import javax.swing.JLabel;
import javax.swing.JTable;
import javax.swing.SwingConstants;
import javax.swing.table.TableCellRenderer;
* @author CS781RJ
public class MyRenderer extends JLabel implements TableCellRenderer
    public MyRenderer()
        setHorizontalTextPosition(SwingConstants.RIGHT);
        setIconTextGap(3);
        setOpaque(true);
    public Component getTableCellRendererComponent(JTable table, Object value, boolean isSelected, boolean cellHasFocus, int row, int column)
        if (isSelected)
            setBackground(table.getSelectionBackground());
            setForeground(table.getSelectionForeground());
        else
            setBackground(table.getBackground());
            setForeground(table.getForeground());
        if (value instanceof String)
            if ((value != null) && (value.toString().length() > 0))
                System.out.println("Value: " + value.toString());
                setFont(new java.awt.Font("Tahoma", 0, 11));
                setText("<html>" + value.toString().replaceAll("\n", "<br>") + "</html>");
        return this;
}In the class that has the JTable, use the code AFTER declaring the values, columns, etc:
jTable1.getColumnModel().getColumn(0).setCellRenderer(new MyRenderer());
jTable1.setValueAt("Riz\nJavaid", 0, 0);One thing I haven't done is to resize the cell heights, make sure this is done.
Hope this helps
Riz

JTable Numeric cell editor

Similar Messages

Maybe you are looking for