Needs Query Optimization

Question

Hi All
I have the below query - which is a great performance killer.
SELECT A~VBELN A~POSNR A~MATNR A~KWMENG A~KBMENG
         A~ERDAT A~ERZET A~PSTYV D~AUART E~ETTYP
         E~EDATU
           INTO TABLE INT_FIN
      FROM VBAP AS A
      INNER JOIN VBAK AS D ON D~VBELN EQ A~VBELN AND
                           D~MANDT EQ A~MANDT
      INNER JOIN VBEP AS E ON E~VBELN EQ A~VBELN AND
                           E~POSNR EQ A~POSNR    AND
                          E~MANDT EQ A~MANDT
           WHERE           A~VBELN IN s_VBELN AND
                           D~auart in s_auart AND
                           D~vkorg in s_vkorg AND
                           D~vbtyp eq 'C'     AND
  ( ( matnr LIKE c_prefix_sp AND zz_msposnr NE 0 AND kbmeng EQ 0 )
  OR ( matnr LIKE c_prefix_fp AND kwmeng NE A~kbmeng ) ) AND
                           A~ABGRU EQ SPACE      AND
                           A~MTVFP IN R_MTVFP    AND
                           A~PRCTR IN R_PRCT     AND
                           E~ETENR EQ '1'.
  SORT INT_FINBY VBELN POSNR ETTYP.
  DELETE ADJACENT DUPLICATES FROM INT_FIN COMPARING VBELN POSNR.
  CHECK NOT INT_FIN[] IS INITIAL.
  SELECT VBELN UVALL CMGST INTO TABLE INT_VBUK
          FROM VBUK FOR ALL ENTRIES IN INT_FIN
          WHERE VBELN = INT_FIN-VBELN AND
                UVALL NE 'A'.
  SORT INT_VBUK BY VBELN.
  DELETE ADJACENT DUPLICATES FROM INT_VBUK COMPARING VBELN.
How can I optimize this? Please help me to rewrite the same.
Thx

Answer 1

SELECT ...
      FROM VBAP AS A
      INNER JOIN VBAK AS D ON D~VBELN EQ A~VBELN AND
                           D~MANDT EQ A~MANDT
      INNER JOIN VBEP AS E ON E~VBELN EQ A~VBELN AND
                           E~POSNR EQ A~POSNR    AND
                          E~MANDT EQ A~MANDT
           WHERE           A~VBELN IN s_VBELN AND
                           D~auart in s_auart AND
                           D~vkorg in s_vkorg AND
                           D~vbtyp eq 'C'     AND
  ( ( matnr LIKE c_prefix_sp AND zz_msposnr NE 0 AND kbmeng EQ 0 )
  OR ( matnr LIKE c_prefix_fp AND kwmeng NE A~kbmeng ) ) AND
                           A~ABGRU EQ SPACE      AND
                           A~MTVFP IN R_MTVFP    AND
                           A~PRCTR IN R_PRCT     AND
                           E~ETENR EQ '1'.
What is that ????
  ( ( matnr LIKE c_prefix_sp AND zz_msposnr NE 0 AND kbmeng EQ 0 )
  OR ( matnr LIKE c_prefix_fp AND kwmeng NE A~kbmeng ) ) AND
adding the aliases would make your statement clearer.
This can not be such a big issue, start with that one.
SELECT ...
      FROM VBAP AS A
      INNER JOIN VBAK AS D
          ON D~MANDT EQ A~MANDT
          ON D~VBELN EQ A~VBELN
      INNER JOIN VBEP AS E
          ON   E~MANDT EQ A~MANDT
          AND E~VBELN EQ A~VBELN
          AND E~POSNR EQ A~POSNR  
    WHERE   A~VBELN IN s_VBELN.
How many records are in s_VBELN?  Check number of entries of all three tables
and use the alias of the smallest table.
How does that work?
Add the other conditions, without the complicated thing.
At the end add the complicated condition with the correct aliases.
Siegfried