New help writing a function

Question

I am refreshing this an open a new case to see if I get more help( I do apologize, but I do need to move this to production). I am providing scripts:
The Problem: I want to write a procedure to update a column in a table (rprawrt_paid_amt) the amount can not be greater than what is in the RPRAWRt_ACCEPT_AMT, the process is run every payroll period, the payroll table is PHREART (provide a script)
The amount can not exceed the RPRAWRD_ACCEPT_AMT, The procedure is updating the RPRAWRT_PAID_AMT, it is going to be update every pay period, there are going to be cases when SUM(NVL(A.PHREARN_AMT,0)) is going to be greater than the RPRAWRD_ACCEPT_AMT, BUT the update CAN'T exceed the amount in RPRAWRT_ACCEPT_AMT (this value never change, it is set up at the begining of the payroll period(fiscal year).
Please, see more explanation at the end..
SELECT * FROM V$VERSION
results
racle Database 10g Enterprise Edition Release 10.2.0.3.0 - 64bi
PL/SQL Release 10.2.0.3.0 - Production
CORE     10.2.0.3.0     Production
Payroll table, I am just using the columns I need there are more columns in the table(s)
CREATE TABLE PHREART
PHREART_YEAR VARCHAR2(4),
PHREART_PAYNO NUMBER(3),
PHREART_PIDM NUMBER(8),
PHREART_AMT NUMBER(12,2),
PHREART_ACTIVITY_DATE DATE
CREATE TABLE RPRAWRT
RPRAWRT_AIDY_CODE VARCHAR2(4),
RPRAWRT_PIDM NUMBER(8),
RPRAWRT_FUND_CODE VARCHAR2(6),
RPRAWRT_ACCEPT_AMT NUMBER(11,2),
RPRAWRT_PAID_AMT NUMBER(11,2)
I am only inserting one record but you can manipulate the data or insert more records(explain later)
INSERT INTO RPRAWRT
RPRAWRT_AIDY_CODE ,
RPRAWRT_PIDM ,
RPRAWRT_FUND_CODE ,
RPRAWRT_ACCEPT_AMT ,
RPRAWRT_PAID_AMT
SELECT
0910,
2285428,
'CFWS',
60,
45
FROM DUAL
I am inserting to payrolls PHREART_PAYNO  = 20 for the same PHREART_PIDM (PK)
INSERT INTO PHREART
PHREART_YEAR ,
PHREART_PAYNO ,
PHREART_PIDM ,
PHREART_AMT ,
PHREART_ACTIVITY_DATE
SELECT
2009,
20,
2285428,
20,
TO_DATE('9/28/2009','MM/DD/RRRR')
FROM DUAL
I am inserting to payrolls PHREART_PAYNO  = 21
INSERT INTO PHREART
PHREART_YEAR ,
PHREART_PAYNO ,
PHREART_PIDM ,
PHREART_AMT ,
PHREART_ACTIVITY_DATE
SELECT
2009,
21,
2285428,
25,
TO_DATE('10/28/2009','MM/DD/RRRR')
FROM DUAL
Here is the query that I want to use in my cursor, I do want to do this in a pl\sql function
query 1
SELECT rprawrt_aidy_code, rprawrt_pidm, rprawrt_fund_code,
NVL (rprawrt_accept_amt, 0),
NVL (rprawrt_paid_amt, 0) paid_amt,
NVL (rprawrt_paid_amt, 0) pay_amt_sf,
SUM (NVL (a.phreart_amt, 0))
FROM phreart a, rprawrt b
WHERE
rprawrt_pidm = a.phreart_pidm
AND rprawrt_fund_code = 'CFWS'
AND rprawrt_pidm = 2285428
AND rprawrt_aidy_code = 0910
AND a.phreart_year = 2009
AND (rprawrt_accept_amt IS NOT NULL AND rprawrt_accept_amt > 0
GROUP BY rprawrt_pidm,
rprawrt_aidy_code,
rprawrt_fund_code,
rprawrt_accept_amt,
rprawrt_paid_amt,
rprawrt_accept_amt;
I am giving this example for just one pidm the
AND rprawrt_pidm = 2285428
AND rprawrt_aidy_code = 0910
AND a.phreart_year = 2009
are parameters passing to the function p_pidm, p_aidy_code, p_year
Okay this is how my logic needs to work, if I run the query 1 I got this results
RPRAWRT_AIDY_CODE = 0910
RPRAWRT_PIDM = 2285428
RPRAWRT_FUND_CODE = 'CWS'
NVL(RPRAWRT_ACCEPT_AMT,0) = 60
PAID_AMT = 45
PAY_AMT_SF = 45
SUM(NVL(A.PHREART_AMT,0)) = 45
{code)
ok this is the result for the pay period 20 and 21, let's say that for the period 22 the sum amout is 100.
so, if we run the query 1 (that I am going to use in the cursor, I got) SUM(NVL(A.PHREART_AMT,0)) = 100
BUT
the RPRAWRT_ACCEPT_AMT is 60, so I can not update the accept amount for more than 60 that is the limit, this amount never change, it is set up in the begining of the period, the person said I accept 60, but lots of times they do made more than the accept amount (over time), we need to report to the government what they said in the begining in this case, 60
so for the run of the PHREART_PAYNO 22, I should update this record on RPRAWRT_PAID_AMT = 60, so I need to substract the 15 dollars that are needed to get to 60..right 20 + 25 + 15 (forget about the rest, they will get pay, but my report don't need the rest the 85).
Now when the next pay period comes this records should not be update again, it reaches the top (60) the RPRAWRT_ACCEPT_AMT is now 60... ]
here is the insert
INSERT INTO PHREART
PHREART_YEAR   ,
PHREART_PAYNO  ,
PHREART_PIDM  ,
PHREART_AMT   , 
PHREART_ACTIVITY_DATE  
SELECT
2009,
22,
2285428,
55,
TO_DATE('10/28/2009','MM/DD/RRRR')
FROM DUAL
The person made 55 dollars on the PHREART_PAYNO 22, so now we have
PHREART_PAYNO   20  20 dollars
PHREART_PAYNO    21  25 dollars
PHREART_PAYNO    22  55 dollars
I would like to do this in a pl\sql function
something like this
Fetch the results from the cursor in variables the use if statements to do the updates, what I got it works but sometimes does not...
rprawrd the equilant of prawrt, I just created the T tables with the columns I need.
BEGIN
      IF update_rprawrd_cur%ISOPEN
      THEN
         CLOSE update_rprawrd_cur;
      END IF;
      OPEN update_rprawrd_cur;
      LOOP
         FETCH update_rprawrd_cur
          INTO v_aidy_code, v_pidm, v_fund_code, v_accept_amt, v_paid_amt,
               v_need_to_upd, v_pay_amt_sf,v_phrearn_amt;
         ---amount to update
         --v_this_upd := NVL (v_paid_amt, 0) + NVL (v_need_to_upd, 0);
         --- v_this_upd := NVL (v_phrearn_amt, 0) - NVL (v_paid_amt, 0) + NVL(v_pay_amt_sf,0);
         EXIT WHEN update_rprawrd_cur%NOTFOUND;
         IF
             v_accept_amt > v_phrearn_amt
         THEN
            LOCK TABLE faismgr.rprawrd IN SHARE UPDATE MODE;
          UPDATE faismgr.rprawrd
                    SET rprawrd_activity_date = SYSDATE,
                   rprawrd_paid_amt = v_phrearn_amt,
                   rprawrd_paid_date = SYSDATE,
                   rprawrd_data_origin = 'rz_upd_pkg',
                   rprawrd_user_id = p_user
             WHERE rprawrd_pidm = v_pidm
               AND rprawrd_fund_code = 'CFWS'
               AND rprawrd_aidy_code = v_aidy_code;                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               

Answer 1

Thank you, I certainly will look at your recommendations, and I agree with not locking the table, that is something I learned from a piece of code and I saw but I always have question about it, I believe Oracle automaticly look the table when is doing an update, I will never use again.
I don't have any expereience using bulk collector, I will look at your documenntation and I will try to learn it, but It will be helpful if someone can help with the following:
If you run the query 1 after you do the inserts(previous email) you will get
RPRAWRT_AIDY_CODE = 0910
RPRAWRT_PIDM = 2285428
RPRAWRT_FUND_CODE = 'CWS'
NVL(RPRAWRT_ACCEPT_AMT,0) = 60
PAID_AMT = 45
PAY_AMT_SF = 45
SUM(NVL(A.PHREART_AMT,0)) = 45
The RPRAWRT_ACCEPT_AMT is always 60, so I can not update the accept amount for more than 60 that is the limit, this amount never change, it is set up in the begining of the period, the person said I accept 60, but lots of times they do made more than the accept amount (over time), we need to report to the government what they said in the begining in this case, 60
so for the run of the PHREART_PAYNO 22, I should update this record on RPRAWRT_PAID_AMT = 60, so I need to substract the 15 dollars that are needed to get to 60..right 20 + 25 + 15 (forget about the rest, they will get pay, but my report don't need the rest the 85).
Now when the next pay period comes this records should not be update again, it reaches the top (60) the RPRAWRT_ACCEPT_AMT is now 60... ]
here is the insert
INSERT INTO PHREART
PHREART_YEAR ,
PHREART_PAYNO ,
PHREART_PIDM ,
PHREART_AMT ,
PHREART_ACTIVITY_DATE
SELECT
2009,
22,
2285428,
55,
TO_DATE('10/28/2009','MM/DD/RRRR')
FROM DUAL
The person made 55 dollars on the PHREART_PAYNO 22, so now we have
PHREART_PAYNO 20 20 dollars
PHREART_PAYNO 21 25 dollars
PHREART_PAYNO 22 55 dollars
Then for period 23 if the person make some money the table SHOULD not be update because it reaches the limit 60
Thank you
Edited by: peace4all on Feb 20, 2010 6:31 AM