Not able to copy all the record from the table?

Question

Hi All,
I have a table Table_1 with 5 crores of data. I have created the same table structure Table_2 like Table_1 and trying to insert the entire data from Table_1 to Table_2 by use of the below code:
CREATE OR REPLACE PROCEDURE insert_prc (limit_in IN PLS_INTEGER)
IS
    cursor cur_insert
    IS
    SELECT  *
    FROM    Table_1;
    type tabtype_insert IS TABLE OF cur_insert%ROWTYPE INDEX BY PLS_INTEGER;
    v_tabtype_insert   tabtype_insert;
    v_limit_rows    NUMBER := 1000;
    v_start    PLS_INTEGER;
    v_end      PLS_INTEGER;
    v_update_count  NUMBER;
    v_bulk_errors   NUMBER;   
begin
    DBMS_SESSION.free_unused_user_memory;
    show_pga_memory (limit_in || ' - BEFORE');
    v_start := DBMS_UTILITY.get_cpu_time;
    BEGIN
        open cur_insert;
        LOOP
            FETCH cur_insert BULK COLLECT INTO v_tabtype_insert LIMIT v_limit_rows;
            FORALL i IN 1..v_tabtype_insert.COUNT SAVE EXCEPTIONS
            INSERT INTO  Table_2
            VALUES v_tabtype_insert(i);
            EXIT WHEN v_tabtype_insert.COUNT < v_limit_rows;
            COMMIT;
        END LOOP;
        CLOSE cur_insert;
    EXCEPTION
    WHEN OTHERS
    THEN
        v_update_count := 0;
        v_bulk_errors := SQL%BULK_EXCEPTIONS.COUNT;
        dbms_output.put_line('Number of INSERT statements that failed : ' ||v_bulk_errors);
        dbms_output.put_line('*******************************************************************************************************************');
        /*FOR i IN 1..v_bulk_errors
        LOOP
            dbms_output.put_line('An Error ' || i || ' was occured '|| SQL%BULK_EXCEPTIONS(i).ERROR_INDEX ||
                                ' during update of Actuator Model: '|| v_tabtype_mtl_items(SQL%BULK_EXCEPTIONS(i).ERROR_INDEX) ||
                                ' . Oracle error : '|| SQLERRM(-SQL%BULK_EXCEPTIONS(i).ERROR_CODE));
        END LOOP;   */
        dbms_output.put_line('*******************************************************************************************************************');
    END; 
      v_end := DBMS_UTILITY.get_cpu_time;
      DBMS_OUTPUT.put_line (   'Elapsed CPU time for limit of '
                            || limit_in
                            || ' = '
                            || TO_CHAR (v_end - v_start)/100
      show_pga_memory (limit_in || ' - AFTER');
end insert_prc;
CREATE OR REPLACE PROCEDURE APPS.show_pga_memory (
   context_in   IN   VARCHAR2 DEFAULT NULL
SELECT privileges required on:
   SYS.v_$session
   SYS.v_$sesstat
   SYS.v_$statname
Here are the statements you should run:
GRANT SELECT ON SYS.v_$session TO schema;
GRANT SELECT ON SYS.v_$sesstat TO schema;
GRANT SELECT ON SYS.v_$statname TO schema;
IS
   l_memory   NUMBER;
BEGIN
   SELECT st.VALUE
     INTO l_memory
     FROM SYS.v_$session se, SYS.v_$sesstat st, SYS.v_$statname nm
    WHERE se.audsid = USERENV ('SESSIONID')
      AND st.statistic# = nm.statistic#
      AND se.SID = st.SID
      AND nm.NAME = 'session pga memory';
   dbms_output.put_line(CASE
                               WHEN context_in IS NULL
                                  THEN NULL
                               ELSE context_in || ' - '
                            END
                         || 'PGA memory used in session = '
                         || TO_CHAR (l_memory)
END show_pga_memory;
/From the above procedure i am able to insert only some 5000000 data. Remaining 4 crores data is not inserted. But the program says it is completed sucessfully.
Note: Table_2 is the partitioned table and Table_1 is non partitioned table.
Can anyone please what is the problem on above code?
Thanks

Answer 1

user212310 wrote:
-- Using BULK COLLECTS and FORALL's will consume more resources.Ya i will agree that. That's what i am using LIMIT clause passing value as 1000. It means PL/SQL will reuse the same 1000 elements in the collection each time the data is fetched and thus also reuse the same memory. Even if my table grows in size, the PGA consumption will remain stable.Limit or not, your process will consume more resources (and take longer) than the one i showed you. AND it's many many many more lines of code (harder to maintain, etc...).
user212310 wrote:
-- If you don't have a reason (aside from misguided understandings as to which is more performant) to use BULK COLLECTS and FORALL's then you should go with the direct INSERT INTO SELECT * method.The reason i am using BULK COLLECT is to reduce the execution time of the procedure.
Please let me know if i misunderstood something.
ThanksYes, you have.
Please read this
http://asktom.oracle.com/pls/asktom/f?p=100:11:0::::P11_QUESTION_ID:760210800346068768