Opening refcursor for every loop value

Question

Guys,
I have a refcursor which is getting opened for different values which is coming from the enclosing loops but while executing the refcursor is getting fired for once .Please let me know if there is any caveats.
Here is the code pasted
declare
cursor cur_col_dtls is select column_name FROM user_tab_columns WHERE table_name ='JOURNAL_DATA' AND column_name LIKE UPPER('field_def_id%')
ORDER BY SUBSTR(column_name,-3);
v_commit_point number :=0;
type ref_cur IS ref CURSOR;
v_ref_cur ref_cur;
v_slct VARCHAR2(4000);
v_col_no NUMBER;
v_data tj_data_pivot%ROWTYPE;
BEGIN
FOR v_dtls IN cur_col_dtls LOOP
IF length(v_dtls.column_name)=16 THEN
v_col_no :=SUBSTR(v_dtls.column_name,-3);
ELSIF length(v_dtls.column_name)=15 THEN
v_col_no :=SUBSTR(v_dtls.column_name,-2);
ELSE
v_col_no :=SUBSTR(v_dtls.column_name,-1);
END IF;
v_slct :='select journal_entry_id, partition_date,'|| v_col_no||',field_def_id_'||v_col_no||', value_'||v_col_no||' from tp.journal_data where field_def_id_'||v_col_no||' is not null and journal_entry_id>(select NVL(max(journal_entry_id),0) from tj_data_pivot)';
-- DBMS_OUTPUT.PUT_LINE (v_dtls.column_name|| ' '||v_col_no||' '||v_slct);
IF v_ref_cur%ISOPEN THEN
close v_ref_cur;
END IF;
OPEN v_ref_cur FOR v_slct ;
<<innerloop>>
LOOP
FETCH v_ref_cur INTO v_data;
--dbms_output.put_line (v_slct);
EXIT innerloop WHEN v_ref_cur%NOTFOUND;
INSERT INTO TEST VALUES(v_data.journal_entry_id);
-- DBMS_OUTPUT.PUT_LINE (v_data.journal_entry_id||','||v_data.partition_date||','||v_data.field_value);
--INSERT INTO tj_data_pivot VALUES (v_data.journal_entry_id,v_data.partition_date,v_data.field_seq,v_data.field_def,v_data.field_value);
v_commit_point :=v_commit_point+1;
IF v_commit_point=1000 THEN
COMMIT;
v_commit_point :=0;
END IF;
END LOOP innerloop;
-- close v_ref_cur;
-- exit when v_col_no=1;
END LOOP;
-- v_slct :='select journal_entry_id, partition_date, 1, field_def_id_1, value_1 from tp.journal_data where field_def_id_1 is not null
END;

Answer 1

Congratulations!!
This is an excellent example of how PL/SQL can be abused.
Apart from that your 'code' will turn Oracle from a Ferrari into a T-Ford (black).
Your code doesn't scale as it uses dynamic sql.
You commit one of the gravest sins in Oracle: you commit inside a loop.
You don't use BULK COLLECT.
But more importantly: your data model is an utter complete mess, as it doesn't even adhere to First Normal Form, as it has repeating groups.
There is only one advice possible: before you do continue,
issue the
drop database
command.
Then issue the
Drop brain prafullu
command.
Then start learning databases, unlearning all of the evil practises you've 'learned' so far.
Sybrand Bakker
Senior Oracle DBA