Optimization of Codes in ABAP

Question

Hello there,
Can anyone help me about my problem in optimizing my code in ABAP..
before i used SDF logical dbf..but simple select in BSIS,BKPF and BSEG tables are much faster than using logical dbf..but my main problem is it took a while also in processing a report while using a select statement..here is my sample code.
It took 2mins in processing a report...Hope someone can help me
Please give me some advice.
Thanks in advance
aVaDuDz
SELECT SINGLE *
  FROM skb1
  WHERE bukrs EQ p_bukrs
  AND saknr EQ p_saknr.
  IF sy-subrc EQ 0.
    SELECT blart belnr waers monat budat bukrs hkont buzei
           shkzg dmbtr wrbtr gjahr
    INTO CORRESPONDING FIELDS OF TABLE it_bsis
    FROM bsis
    WHERE bukrs EQ p_bukrs
    AND hkont EQ p_saknr
    AND gjahr IN p_gjahr
    AND monat IN p_monat.
    PERFORM add_record.
  ENDIF.
FORM add_record .
  LOOP AT it_bsis.
    g_percn = 1.
    CLEAR g_indic.
    g_indic = c_indic.
    REPLACE '&' WITH it_bsis-belnr INTO g_indic.
    REPLACE '%' WITH it_bsis-buzei INTO g_indic.
    CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
      EXPORTING
        percentage = g_percn
        text       = g_indic.
    READ TABLE it_data ASSIGNING <data>
         WITH KEY  belnr = it_bsis-belnr "document #
                   buzei = it_bsis-buzei. "Line Item
    IF sy-subrc <> 0.
      APPEND INITIAL LINE TO it_data ASSIGNING <data>.
      <data>-belnr = it_bsis-belnr. "document #
      <data>-buzei = it_bsis-buzei. "Line Item
    ENDIF.
    <data>-bukrs = it_bsis-bukrs. "Company
    <data>-hkont = it_bsis-hkont. "G/L Acct.
    <data>-gjahr = it_bsis-gjahr.
    <data>-waers = it_bsis-waers.
    <data>-belnr = it_bsis-belnr.
    <data>-monat = it_bsis-monat.
    <data>-budat = it_bsis-budat.
    <data>-blart = it_bsis-blart.
    IF it_bsis-shkzg ='H'.
      <data>-wrbtr = it_bsis-wrbtr * -1.
      <data>-dmbtr = it_bsis-dmbtr * -1.
    ELSE.
      <data>-wrbtr = it_bsis-wrbtr.
      <data>-dmbtr = it_bsis-dmbtr.
    ENDIF.
    SELECT SINGLE lifnr sgtxt
     FROM bseg
     INTO gs_vendor
     WHERE belnr  =  it_bsis-belnr
     AND gjahr IN p_gjahr
     AND lifnr NE ''.
    SELECT SINGLE lifnr name1 stcd1
     FROM lfa1
     INTO gs_lfa1
     WHERE lifnr = gs_vendor-lifnr.
    <data>-lifnr = gs_lfa1-lifnr.
    <data>-sgtxt = gs_vendor-sgtxt.
    <data>-name1 = gs_lfa1-name1.
    <data>-stcd1 = gs_lfa1-stcd1.
    SELECT SINGLE wt_withcd
    FROM with_item
    INTO gs_item
    WHERE belnr = it_bsis-belnr
    AND gjahr IN p_gjahr.
    IF sy-subrc EQ 0.
      <data>-mwskz = gs_item.
    ENDIF.
    SELECT SINGLE ppnam usnam bldat
    FROM bkpf
    INTO gs_bkpf
    WHERE belnr = it_bsis-belnr
    AND gjahr IN p_gjahr.
    <data>-ppnam = gs_bkpf-ppnam.
    <data>-usnam = gs_bkpf-usnam.
    <data>-bldat = gs_bkpf-bldat.
  ENDLOOP.
ENDFORM.                    " add_record

Answer 1

Hi,
Check this code. See the comments where i have mentioned "Add / Remove this".
For tables like BSEG, BKPF and WITH_ITEM you have to provide complete key to read from table. BUKRS should be the first field in select statement.
Also, you do not need to check LIFNR  NE '', when you select from BSEG. Just read the first line item. It is vendor / customer line item.
Also, <b>DO NOT USE SAPGUI_PROGRESS_INDICATOR inside loop</b>. It does affect performance.
Let me know if you still have performance issue.
SELECT SINGLE *
               FROM skb1
               WHERE bukrs EQ p_bukrs
               AND saknr EQ p_saknr.
IF sy-subrc EQ 0.
  SELECT blart belnr waers monat budat bukrs hkont buzei
  shkzg dmbtr wrbtr gjahr
  INTO CORRESPONDING FIELDS OF TABLE it_bsis
  FROM bsis
  WHERE bukrs EQ p_bukrs
  AND hkont EQ p_saknr
  AND gjahr IN p_gjahr
  AND monat IN p_monat.
  PERFORM add_record.
ENDIF.
*       FORM add_record                                               *
FORM add_record .
  LOOP AT it_bsis.
    g_percn = 1.
    CLEAR g_indic.
    g_indic = c_indic.
    REPLACE '&' WITH it_bsis-belnr INTO g_indic.
    REPLACE '%' WITH it_bsis-buzei INTO g_indic.
    CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
         EXPORTING
              percentage = g_percn
              text       = g_indic.
    READ TABLE it_data ASSIGNING <data>
    WITH KEY belnr = it_bsis-belnr "document #
    buzei = it_bsis-buzei. "Line Item
    IF sy-subrc <> 0.
      append initial line to it_data assigning <data>.
      <data>-belnr = it_bsis-belnr. "document #
      <data>-buzei = it_bsis-buzei. "Line Item
    ENDIF.
    <data>-bukrs = it_bsis-bukrs. "Company
    <data>-hkont = it_bsis-hkont. "G/L Acct.
    <data>-gjahr = it_bsis-gjahr.
    <data>-waers = it_bsis-waers.
    <data>-belnr = it_bsis-belnr.
    <data>-monat = it_bsis-monat.
    <data>-budat = it_bsis-budat.
    <data>-blart = it_bsis-blart.
    IF it_bsis-shkzg ='H'.
      <data>-wrbtr = it_bsis-wrbtr * -1.
      <data>-dmbtr = it_bsis-dmbtr * -1.
    ELSE.
      <data>-wrbtr = it_bsis-wrbtr.
      <data>-dmbtr = it_bsis-dmbtr.
    ENDIF.
    SELECT SINGLE
                 lifnr
                 sgtxt FROM bseg
                       INTO gs_vendor
                       WHERE bukrs = it_bsis-bukrs " --> Add this
                       AND belnr = it_bsis-belnr
                       AND gjahr IN p_gjahr
                       AND buzei = '001'.    " --> Add this
*                       AND lifnr NE ''.     " --> Remove this
    SELECT SINGLE lifnr name1 stcd1
    FROM lfa1
    INTO gs_lfa1
    WHERE lifnr = gs_vendor-lifnr.
    <data>-lifnr = gs_lfa1-lifnr.
    <data>-sgtxt = gs_vendor-sgtxt.
    <data>-name1 = gs_lfa1-name1.
    <data>-stcd1 = gs_lfa1-stcd1.
    SELECT SINGLE wt_withcd
    FROM with_item
    INTO gs_item
    WHERE bukrs = it_bsis-bukrs  " --> Add this
    AND belnr = it_bsis-belnr
    AND gjahr IN p_gjahr.
    IF sy-subrc EQ 0.
      <data>-mwskz = gs_item.
    ENDIF.
    SELECT SINGLE ppnam usnam bldat
    FROM bkpf
    INTO gs_bkpf
    WHERE bukrs = it_bsis-bukrs   " --> Add this
    AND belnr = it_bsis-belnr
    AND gjahr IN p_gjahr.
    <data>-ppnam = gs_bkpf-ppnam.
    <data>-usnam = gs_bkpf-usnam.
    <data>-bldat = gs_bkpf-bldat.
  ENDLOOP.
ENDFORM.
Regards,
RS