Out of memory using Cursor in sql server

Question

Hi, I and my team recently add history tracking to one of you project. It's working fine, but client request to handle records stored in database before the update.So I try to create cursor in order to read all data not involve in history and insert it to
the history table.
Unfortunatelly these are 70 000 recods and each individual column must be an inset into history table
DECLARE @HelpnestID bigint
DECLARE helpnest_cursor CURSOR FAST_FORWARD FORWARD_ONLY READ_ONLY
FOR SELECT
Helpnest_ID
FROM helpnest.Helpnest1407 h
WHERE
h.Helpnest_ID not in (SELECT hh.Helpnest_ID FROM helpnest.HistoryHelpNest1407 hh WHERE hh.OperationType=0)
OPEN helpnest_cursor
FETCH NEXT FROM helpnest_cursor
INTO @HelpnestID
EXEC helpnest.usp_AddHelpNestHistoryByID @HelpnestID
WHILE @@FETCH_STATUS=0
BEGIN
FETCH NEXT FROM helpnest_cursor
INTO @HelpnestID
EXEC helpnest.usp_AddHelpNestHistoryByID @HelpnestID
END
CLOSE helpnest_cursor
DEALLOCATE helpnest_cursor
Every time cursor fetch i call a store procedure, the store procedure use many parameters, so I assume that they didn't free memory after each callback.
Thanks in advance
sincerely, Ivo

Answer 1

If your stored procedure is only doing INSERT INTO helpnest.HistoryHelpNest1407
(col1, col2,
....) based on Helpnest_ID, AS
Satish said that you really do not need a cursor or a loop to do that. His script is good. If your SP is also doing other stuff, you can use a loop:
DECLARE @helpnest_ID bigint
DECLARE @index int
DECLARE @index_Max int
DECLARE @HelpNestIDs TABLE (
ID int IDENTITY(1, 1),
Helpnest_ID bigint
INSERT INTO @HelpNestIDs (Helpnest_ID)
SELECT Helpnest_ID
FROM helpnest.Helpnest1407
WHERE Helpnest_ID NOT IN (
SELECT Helpnest_ID FROM helpnest.HistoryHelpNest1407 WHERE OperationType=0
SET @index = 1
SELECT @index_Max = MAX(ID) FROM @HelpNestIDs
WHILE @index <= @index_Max BEGIN
SELECT @helpnest_ID = Helpnest_ID FROM @HelpNestIDs WHERE ID = @index
EXEC helpnest.usp_AddHelpNestHistoryByID @helpnest_ID
SET @index = @index + 1
END
GO
A Fan of SSIS, SSRS and SSAS