Performance tune

Question

Hi Everyone i am using the following procedure to get Distribution List in a cursor
CREATE OR REPLACE PACKAGE BODY Pk_Outage_Target_Dls AS
-- global Variables used in procedures
v_results_cur VARCHAR2(40);
V_CONCAT_RES VARCHAR2(2000);
V_APPLN_ASSET_ID VARCHAR2(2000);
V_SERVER_IMG_ASSET_ID VARCHAR2(2000);
NAME: FN_IN_LIST
Purpose: To get the table of values to pass to cursor query
FUNCTION FN_IN_LIST(p_string IN VARCHAR2) RETURN myTableType AS
v_l_string LONG DEFAULT p_string || ',';
v_l_data myTableType := myTableType();
v_n NUMBER;
BEGIN
LOOP
EXIT WHEN v_l_string IS NULL;
v_n := INSTR(v_l_string, ',');
v_l_data.EXTEND;
v_l_data(v_l_data.COUNT) := LTRIM(RTRIM(SUBSTR(v_l_string, 1, v_n - 1)));
v_l_string := SUBSTR(v_l_string, v_n + 1);
END LOOP;
RETURN v_l_data;
END FN_IN_LIST;
NAME: PROC_GET_ASSET_CLASS
Purpose: To set the v_scope_name for the given asset_id
PROCEDURE PROC_GET_ASSET_CLASS(P_ASSET_ID IN VARCHAR2,
P_SCOPE_NAME OUT VARCHAR2) AS
v_scope_name VARCHAR2(200);
BEGIN
SELECT ATPT.NAME
INTO v_scope_name
FROM T_ASSET_TYPE ATP, T_RELATED_ASSET_TYPE RATP, T_ASSET_TYPE ATPT
WHERE LOWER(ATP.CATEGORY) = LOWER('HIERARCHY')
AND ATP.ASSET_TYPE_ID = RATP.ASSET_TYPE_ID
AND LOWER(RATP.REL_TYPE) = LOWER('SCOPE')
AND RATP.RELATED_ASSET_TYPE_ID = ATPT.ASSET_TYPE_ID
AND ATPT.ACTIVE_FLAG = 1
AND ATP.ASSET_TYPE_ID IN
(SELECT ASSET_TYPE_ID FROM T_ASSET WHERE ASSET_ID = P_ASSET_ID);
P_SCOPE_NAME := v_scope_name;
EXCEPTION
WHEN NO_DATA_FOUND THEN
P_SCOPE_NAME := NULL;
WHEN OTHERS THEN
P_SCOPE_NAME := NULL;
END PROC_GET_ASSET_CLASS;
NAME: PROC_HARDWARE_SCOPE
Purpose: For processing when "server hardware scope"
PROCEDURE PROC_HARDWARE_SCOPE(P_ASSET_ID IN VARCHAR2,
CUR_DL_LIST OUT REFCURSORTYPE,
P_ERROR_CODE OUT VARCHAR2) AS
V_CUR_SERVER_IMG REFCURSORTYPE;
V_CUR_APPLN_ASSET REFCURSORTYPE;
BEGIN
-- get the server image(s) asset ids on the hardware
OPEN V_CUR_SERVER_IMG FOR
SELECT A.ASSET_ID
FROM T_ASSET A, T_RELATED_ASSET B
WHERE A.ACTIVE_FLAG = 1
AND LOWER(A.STATUS) <> LOWER('Inactive')
AND B.ASSET_ID = A.ASSET_ID
AND B.ACTIVE_FLAG = 1
AND LOWER(B.REL_TYPE) = 'server hardware'
AND B.RELATED_ASSET_ID = P_ASSET_ID;
V_SERVER_IMG_ASSET_ID := '';
LOOP
FETCH V_CUR_SERVER_IMG
INTO v_results_cur;
EXIT WHEN V_CUR_SERVER_IMG%NOTFOUND;
V_SERVER_IMG_ASSET_ID := V_SERVER_IMG_ASSET_ID || v_results_cur || ',';
END LOOP;
CLOSE V_CUR_SERVER_IMG;
-- DBMS_OUTPUT.PUT_LINE('P_ASSET_ID = ' || P_ASSET_ID);
-- DBMS_OUTPUT.PUT_LINE('V_SERVER_IMG_ASSET_ID=' || V_SERVER_IMG_ASSET_ID);
IF V_SERVER_IMG_ASSET_ID IS NOT NULL THEN
V_SERVER_IMG_ASSET_ID := SUBSTR(V_SERVER_IMG_ASSET_ID, 1, LENGTH(V_SERVER_IMG_ASSET_ID) - 1);
END IF;
-- get the application assets ids for each server image ids
OPEN V_CUR_APPLN_ASSET FOR
SELECT A.ASSET_ID
FROM T_ASSET A, T_RELATED_ASSET B
WHERE A.ACTIVE_FLAG = 1
AND LOWER(A.STATUS) <> LOWER('Inactive')
AND B.RELATED_ASSET_ID = A.ASSET_ID
AND B.ACTIVE_FLAG = 1
AND LOWER(B.REL_TYPE) = 'application'
AND B.ASSET_ID IN
(SELECT * FROM THE (SELECT cast(FN_IN_LIST(V_SERVER_IMG_ASSET_ID) AS mytableType) FROM dual));
V_APPLN_ASSET_ID := '';
LOOP
FETCH V_CUR_APPLN_ASSET
INTO v_results_cur;
EXIT WHEN V_CUR_APPLN_ASSET%NOTFOUND;
V_APPLN_ASSET_ID := V_APPLN_ASSET_ID || v_results_cur || ',';
END LOOP;
CLOSE V_CUR_APPLN_ASSET;
-- DBMS_OUTPUT.PUT_LINE('V_APPLN_ASSET_ID = ' || V_APPLN_ASSET_ID);
V_CONCAT_RES := V_SERVER_IMG_ASSET_ID ||','|| V_APPLN_ASSET_ID||P_ASSET_ID;
-- DBMS_OUTPUT.PUT_LINE('v_concat_res = ' || V_CONCAT_RES);
-- get DL ID & DL Name for the application assets ids
OPEN CUR_DL_LIST FOR
SELECT DISTINCT ATO.ORG_Id, ORG.ORG_NAME
FROM T_ASSET_ORG_ROLE ATO, T_ORG ORG
WHERE ATO.ORG_ID = ORG.ORG_ID
AND ATO.ACTIVE_FLAG = 1
AND ATO.ROLE_ID IN (19, 150, 54)
Start Added By Naval Pant
AND ATO.ASSET_ID IN
(SELECT * FROM THE (SELECT cast(FN_IN_LIST(V_CONCAT_RES) AS mytableType) FROM dual))
End Added By Naval Pant
          AND ORG.ACTIVE_FLAG = 1 ORDER BY ORG.ORG_NAME;
P_ERROR_CODE := 'NO_ERROR';
EXCEPTION
WHEN NO_DATA_FOUND THEN
V_SERVER_IMG_ASSET_ID := NULL;
V_APPLN_ASSET_ID := NULL;
P_ERROR_CODE := 'NO DATA FOUND in Hardware Scope: ' ||
SQLCODE || ' ; ' || SQLERRM;
WHEN OTHERS THEN
V_SERVER_IMG_ASSET_ID := NULL;
V_APPLN_ASSET_ID := NULL;
P_ERROR_CODE := 'INVALID DATA in Hardware Scope: ' ||
SQLCODE || ' ; ' || SQLERRM;
END PROC_HARDWARE_SCOPE;
NAME: PROC_SOFTWARE_SCOPE
Purpose: For processing when "server software scope"
PROCEDURE PROC_SOFTWARE_SCOPE(P_ASSET_ID VARCHAR2,
CUR_DL_LIST OUT REFCURSORTYPE,
P_ERROR_CODE OUT VARCHAR2) AS
V_CUR_APPLN_ASSET REFCURSORTYPE;
BEGIN
-- get the application assets ids for each server image asset id.
OPEN V_CUR_APPLN_ASSET FOR
SELECT A.ASSET_ID
FROM T_ASSET A, T_RELATED_ASSET B
WHERE A.ACTIVE_FLAG = 1
AND LOWER(A.STATUS) <> LOWER('Inactive')
AND B.RELATED_ASSET_ID = A.ASSET_ID
AND B.ACTIVE_FLAG = 1
AND LOWER(B.REL_TYPE) = LOWER('Application')
AND B.ASSET_ID = P_ASSET_ID;
V_APPLN_ASSET_ID := '';
LOOP
FETCH V_CUR_APPLN_ASSET
INTO v_results_cur;
EXIT WHEN V_CUR_APPLN_ASSET%NOTFOUND;
V_APPLN_ASSET_ID := V_APPLN_ASSET_ID ||v_results_cur ||',';
     END LOOP;
CLOSE V_CUR_APPLN_ASSET;
-- DBMS_OUTPUT.PUT_LINE('V_APPLN_ASSET_ID =' || V_APPLN_ASSET_ID);
     --DBMS_OUTPUT.PUT_LINE('P_ASSET_ID =' || P_ASSET_ID);
V_CONCAT_RES := V_APPLN_ASSET_ID||P_ASSET_ID ;
-- DBMS_OUTPUT.PUT_LINE('V_CONCAT_RES = ' || V_CONCAT_RES);
-- get DL ID & DL Name for the application assets ids
OPEN CUR_DL_LIST FOR
SELECT DISTINCT ATO.ORG_Id, ORG.ORG_NAME
FROM T_ASSET_ORG_ROLE ATO, T_ORG ORG
WHERE ATO.ORG_ID = ORG.ORG_ID
AND ATO.ACTIVE_FLAG = 1
AND ATO.ROLE_ID IN (19, 150, 54)
Start Added By Naval Pant
AND ATO.ASSET_ID IN
(SELECT * FROM THE (SELECT cast(FN_IN_LIST(V_CONCAT_RES) AS mytableType) FROM dual))
End Added By Naval Pant
AND ORG.ACTIVE_FLAG = 1 ORDER BY ORG.ORG_NAME;
P_ERROR_CODE := 'NO_ERROR';
EXCEPTION
WHEN NO_DATA_FOUND THEN
V_APPLN_ASSET_ID := NULL;
P_ERROR_CODE := 'NO DATA FOUND in Software Scope : ' || SQLCODE ||
' ; ' || SQLERRM;
WHEN OTHERS THEN
V_APPLN_ASSET_ID := NULL;
P_ERROR_CODE := 'INVALID DATA in Software Scope : ' || SQLCODE ||
' ; ' || SQLERRM;
END PROC_SOFTWARE_SCOPE;
NAME: PROC_APPLICATION_SCOPE
Purpose: For processing when asset is of type "application scope"
PROCEDURE PROC_APPLICATION_SCOPE(P_ASSET_ID VARCHAR2,
CUR_DL_LIST OUT REFCURSORTYPE,
P_ERROR_CODE OUT VARCHAR2) AS
BEGIN
-- get DL ID & DL Name for the application asset id
OPEN CUR_DL_LIST FOR
SELECT DISTINCT ATO.ORG_Id, ORG.ORG_NAME
FROM T_ASSET_ORG_ROLE ATO, T_ORG ORG
WHERE ATO.ORG_ID = ORG.ORG_ID
AND ATO.ACTIVE_FLAG = 1
AND ATO.ROLE_ID IN (19, 150, 54)
AND ATO.ASSET_ID IN (P_ASSET_ID)
AND ORG.ACTIVE_FLAG = 1 ORDER BY ORG.ORG_NAME;
P_ERROR_CODE := 'NO_ERROR';
EXCEPTION
WHEN NO_DATA_FOUND THEN
P_ERROR_CODE := 'NO DATA FOUND in Application Scope : ' || SQLCODE ||
' ; ' || SQLERRM;
WHEN OTHERS THEN
P_ERROR_CODE := 'INVALID DATA in Application Scope : ' || SQLCODE ||
' ; ' || SQLERRM;
END PROC_APPLICATION_SCOPE;
NAME: PROC_OTHER_SCOPE
Purpose: For processing when asset is not of type "hardware,software,application" scope
PROCEDURE PROC_OTHER_SCOPE(P_ASSET_ID VARCHAR2,
CUR_DL_LIST OUT REFCURSORTYPE,
P_ERROR_CODE OUT VARCHAR2) AS
BEGIN
-- get DL ID & DL Name for the application asset id
OPEN CUR_DL_LIST FOR
SELECT DISTINCT ATO.ORG_Id, ORG.ORG_NAME
FROM T_ASSET_ORG_ROLE ATO, T_ORG ORG
WHERE ATO.ORG_ID = ORG.ORG_ID
AND ATO.ACTIVE_FLAG = 1
AND ATO.ROLE_ID IN (19, 54)
AND ATO.ASSET_ID IN (P_ASSET_ID)
AND ORG.ACTIVE_FLAG = 1 ORDER BY ORG.ORG_NAME;
P_ERROR_CODE := 'NO_ERROR';
EXCEPTION
WHEN NO_DATA_FOUND THEN
P_ERROR_CODE := 'NO DATA FOUND in Other Scope : ' || SQLCODE || ' ; ' ||
SQLERRM;
WHEN OTHERS THEN
P_ERROR_CODE := 'INVALID DATA in Other Scope : ' || SQLCODE || ' ; ' ||
SQLERRM;
END PROC_OTHER_SCOPE;
NAME: PROC_OUTAGE_TARGET_DLS
Purpose: Main Proc to fetch DL Lists
PROCEDURE PROC_OUTAGE_TARGET_DLS(P_ASSET_ID IN VARCHAR2,
CUR_DL_LIST OUT REFCURSORTYPE,
P_ERROR_CODE OUT VARCHAR2) AS
v_scope_name VARCHAR2(200);
BEGIN
P_ERROR_CODE := 'NO_ERROR';
PROC_GET_ASSET_CLASS(P_ASSET_ID, v_scope_name);
-- DBMS_OUTPUT.PUT_LINE('SCOPE OF ASSET : ' || v_scope_name);
IF (LOWER(v_scope_name) = 'server hardware scope') THEN
PROC_HARDWARE_SCOPE(P_ASSET_ID, CUR_DL_LIST, P_ERROR_CODE);
ELSIF (LOWER(v_scope_name) = 'server software scope') THEN
PROC_SOFTWARE_SCOPE(P_ASSET_ID, CUR_DL_LIST, P_ERROR_CODE);
ELSIF (LOWER(v_scope_name) = 'application scope') THEN
PROC_APPLICATION_SCOPE(P_ASSET_ID, CUR_DL_LIST, P_ERROR_CODE);
ELSE
PROC_OTHER_SCOPE(P_ASSET_ID, CUR_DL_LIST, P_ERROR_CODE);
END IF;
EXCEPTION
WHEN NO_DATA_FOUND THEN
P_ERROR_CODE := 'NO DATA FOUND : OUTAGE_TARGET_DLS ' || SQLCODE ||
' ; ' || SQLERRM;
WHEN OTHERS THEN
P_ERROR_CODE := 'INVALID DATA : OUTAGE_TARGET_DLS ' || SQLCODE ||
' ; ' || SQLERRM;
END PROC_OUTAGE_TARGET_DLS;
END Pk_Outage_Target_Dls;
when i am executing the procedure, it's taking huge time i.e 6 - 72 seconds.
i want this time to be under 1 second. But i don't know what's the performance issue in the above.
If anyone can tell me that would be great help for me.
waiting for your reply, suggestion.........

Answer 1

First of all the varying run times of "the" procedure that you execute (I assume it is PROC_OUTAGE_TARGET_DLS) is probably caused by the fact that it in turn calls four different procedures depending on the input value.
It probably won't help you much since you say you are Java developer, but I think that the PROC_HARDWARE_SCOPE and PROC_SOFTWARE_SCOPE procedure of your package are far too convoluted and should be simplified... In particular the usage of the FN_IN_LIST table function is in my opinion unnecessary, because I think all these separate steps performed in the procedures to generate a comma separated list of strings which is then in turn transformed into rows again should be done in a single SQL using simple IN subqueries or even joins without the prior concatenation of strings in a list.
E.g. the final cursor opened in PROC_HARDWARE_SCOPE could look like the following:
SELECT DISTINCT ATO.ORG_Id, ORG.ORG_NAME
FROM T_ASSET_ORG_ROLE ATO, T_ORG ORG
WHERE ATO.ORG_ID = ORG.ORG_ID
AND ATO.ACTIVE_FLAG = 1
AND ATO.ROLE_ID IN (19, 150, 54)
Start Added By Naval Pant
AND ATO.ASSET_ID IN
  SELECT A.ASSET_ID
  FROM T_ASSET A, T_RELATED_ASSET B
  WHERE A.ACTIVE_FLAG = 1
  AND LOWER(A.STATUS) <> LOWER('Inactive')
  AND B.RELATED_ASSET_ID = A.ASSET_ID
  AND B.ACTIVE_FLAG = 1
  AND LOWER(B.REL_TYPE) = 'application'
  AND B.ASSET_ID IN
    SELECT A.ASSET_ID
    FROM T_ASSET A, T_RELATED_ASSET B
    WHERE A.ACTIVE_FLAG = 1
    AND LOWER(A.STATUS) <> LOWER('Inactive')
    AND B.ASSET_ID = A.ASSET_ID
    AND B.ACTIVE_FLAG = 1
    AND LOWER(B.REL_TYPE) = 'server hardware'
    AND B.RELATED_ASSET_ID = P_ASSET_ID
  UNION ALL
  SELECT P_ASSET_ID FROM DUAL
End Added By Naval Pant
AND ORG.ACTIVE_FLAG = 1 ORDER BY ORG.ORG_NAME;Since you're saying that even in best case you still get a run time of 6 seconds that you want to reduce to 1 second I assume that you'll have to tune all these queries in addition to the simplification, because if a rather simple query like this, taken from PROC_APPLICATION_SCOPE:
SELECT DISTINCT ATO.ORG_Id, ORG.ORG_NAME
FROM T_ASSET_ORG_ROLE ATO, T_ORG ORG
WHERE ATO.ORG_ID = ORG.ORG_ID
AND ATO.ACTIVE_FLAG = 1
AND ATO.ROLE_ID IN (19, 150, 54)
AND ATO.ASSET_ID IN (P_ASSET_ID)
AND ORG.ACTIVE_FLAG = 1 ORDER BY ORG.ORG_NAME;takes more than one second you need to find out why and whether it's possible to retrieve that information quicker.
Note that all queries use a DISTINCT operator which indicates that there might something be wrong with the data model and/or the query because it seems to eliminate duplicates. May be you want to run the queries without distinct to find out what the result then looks like. You might find out that you get a tremendous result set consisting of many duplicates and most of the time is spent by the database on removing them.
Regards,
Randolf
Oracle related stuff blog:
http://oracle-randolf.blogspot.com/
SQLTools++ for Oracle:
http://www.sqltools-plusplus.org:7676/
http://sourceforge.net/projects/sqlt-pp/