PL/SQL function. ORA-00933: SQL command not properly ended

Question

This is my first attempt at pl/sql functions with dynamic sql. It will compile, but when I try to test it I get the ORA-00933 error at line 147. line 147 is OPEN retval FOR report_query;
Please take a look and let me know what it wrong! thanks
{CREATE OR REPLACE FUNCTION TSARPTS.Stats (v_Hub       IN VARCHAR2,
                                          v_type      IN VARCHAR2,
                                          v_subtype   IN VARCHAR2)
   RETURN SYS_REFCURSOR
IS
   retval           SYS_REFCURSOR;
   report_query_a   VARCHAR2 (10000)
                       := '
  SELECT hub,
         CASE
            WHEN Total = 0 OR Pass_1st = 0 THEN 0
            ELSE ROUND (Pass_1st / (Total) * 100, 2)
         END
            AS Pass_1st_percent,
         CASE
            WHEN Total = 0 OR Pass_2nd = 0 THEN 0
            ELSE ROUND (Pass_2nd / (Total) * 100, 2)
         END
            AS Pass_2nd_percent,
         CASE
            WHEN Total = 0 OR Pass_3rd = 0 THEN 0
            ELSE ROUND (Pass_3rd / (Total) * 100, 2)
         END
            AS Pass_3rd_percent,
         CASE
            WHEN Total = 0 OR DNM = 0 THEN 0
            ELSE ROUND (DNM / (Total) * 100, 2)
         END
            AS DNM,
         CASE
            WHEN Total = 0 OR Incomplete = 0 THEN 0
            ELSE ROUND (Incomplete / (Total) * 100, 2)
         END
            AS Incomplete
    FROM (  SELECT hub,
                   SUM (DECODE (result, ''Pass_on_1st'', 1, 0)) Pass_1st,
                   SUM (DECODE (result, ''Pass_on_2nd'', 1, 0)) Pass_2nd,
                   SUM (DECODE (result, ''Pass_on_3rd'', 1, 0)) Pass_3rd,
                   SUM (DECODE (result, ''DNM'', 1, 0)) DNM,
                   SUM (DECODE (result, ''INCOMPLETE'', 1, 0)) Incomplete,
                     SUM (DECODE (result, ''Pass_on_1st'', 1, 0))
                   + SUM (DECODE (result, ''Pass_on_2nd'', 1, 0))
                   + SUM (DECODE (result, ''Pass_on_3rd'', 1, 0))
                   + SUM (DECODE (result, ''DNM'', 1, 0))
                   + SUM (DECODE (result, ''INCOMPLETE'', 1, 0))
                      Total
              FROM employees_vw a, pse_vw b
             WHERE     a.emplid = b.emplid
                   AND status IN (''S'', ''I'', ''N'')
                   AND TYPE = ''PSE''
   report_query_b   VARCHAR2 (10000)
                       := ' 
SELECT hub,
       TYPE,
       subtype,
       CASE
          WHEN Total = 0 OR Pass_1st = 0 THEN 0
          ELSE ROUND (Pass_1st / (Total) * 100, 2)
       END
          AS Pass_1st_percent,
       CASE
          WHEN Total = 0 OR Pass_2nd = 0 THEN 0
          ELSE ROUND (Pass_2nd / (Total) * 100, 2)
       END
          AS Pass_2nd_percent,
       CASE
          WHEN Total = 0 OR Pass_3rd = 0 THEN 0
          ELSE ROUND (Pass_3rd / (Total) * 100, 2)
       END
          AS Pass_3rd_percent,
       CASE
          WHEN Total = 0 OR DNM = 0 THEN 0
          ELSE ROUND (DNM / (Total) * 100, 2)
       END
          AS DNM,
       CASE
          WHEN Total = 0 OR Incomplete = 0 THEN 0
          ELSE ROUND (Incomplete / (Total) * 100, 2)
       END
          AS Incomplete
  FROM (  SELECT hub,
   TYPE,
       subtype
                  SUM (DECODE (result, ''Pass_on_1st'', 1, 0)) Pass_1st,
                   SUM (DECODE (result, ''Pass_on_2nd'', 1, 0)) Pass_2nd,
                   SUM (DECODE (result, ''Pass_on_3rd'', 1, 0)) Pass_3rd,
                   SUM (DECODE (result, ''DNM'', 1, 0)) DNM,
                   SUM (DECODE (result, ''INCOMPLETE'', 1, 0)) Incomplete,
                     SUM (DECODE (result, ''Pass_on_1st'', 1, 0))
                   + SUM (DECODE (result, ''Pass_on_2nd'', 1, 0))
                   + SUM (DECODE (result, ''Pass_on_3rd'', 1, 0))
                   + SUM (DECODE (result, ''DNM'', 1, 0))
                   + SUM (DECODE (result, ''INCOMPLETE'', 1, 0))
                      Total
              FROM employees_vw a, pse_vw b
             WHERE     a.emplid = b.emplid
                   AND status IN (''S'', ''I'', ''N'')
                 AND TYPE = ''PSE''
   report_query     VARCHAR2 (10000);
BEGIN
   IF v_hub <> '*'
   THEN
      report_query := report_query_a;
   ELSE
      report_query := report_query_b;
   END IF;
   IF v_hub <> '*'
   THEN
      report_query :=
         report_query || ' and hub = ''' || v_hub || ''' GROUP BY hub )
GROUP BY hub,
         Pass_1st,
         Pass_2nd,
         Pass_3rd,
         Total,
         DNM,
         Incomplete';
   END IF;
   IF v_type <> '*' AND v_subtype <> '*' AND v_hub <> '*'
   THEN
      report_query :=
            report_query
         || ' and hub = '''
         || v_hub
         || ''' and type = '''
         || v_type
         || ''' and subtype= '''
         || v_subtype
         || '''
          GROUP BY hub,
                 TYPE,
                 subtype,
        GROUP BY hub,
                 TYPE,
                 subtype,
                 Pass_1st,
                 Pass_2nd,
                 Pass_3rd,
                 Total,
                 DNM,
                 Incomplete';
   END IF;
   OPEN retval FOR report_query;
   RETURN retval;
END;
Edited by: user10821012 on May 13, 2010 9:56 AM

Answer 1

What you are seeing is pretty common. When I work with dynamic SQL I usually include some logic to put the dyanmic SQL into a string and a means to see what was generated, something like (untested here)
  v_sql_c := 'select * from dual';
  open refcur for v_sql_c;
exception
  when others then
     insert into work_table (clob_column) values (v_sql_c);so I can later query the table to get to the generated SQL for debugging, something like
  select * from work_table;I also try to write dynamic SQL so I can paste it from the work table right into query execution without editing.