Please help me to identify unnecessary code in these two procedures

Question

Hi,
Please help me to tune these two procedures.
I think some unnecessary code is existed in these two procedures.
Please help me to identify those lines.
  PROCEDURE InsertIntoScoreTables(pBUID       IN ORDER_SCORE_REASON.BUID%TYPE,
                                  OrderNum    IN ORDER_SCORE_REASON.ORDER_NUM%TYPE,
                                  ReasonCode  IN MASTER_REASON.REASON_CODE%TYPE,
                                  MatchResult IN ORDER_SCORE_REASON.MATCH_RESULT%TYPE,
                                  ScoreType   IN MASTER_REASON.REASON_TYPE%TYPE,
                                  AddressType IN MASTER_REASON.ADDRESS_TYPE%TYPE) IS
    tCount       NUMBER := 0;
    tScoreID     MASTER_REASON.REASON_ID%TYPE := 0;
    tReasonSeq   MASTER_REASON.REASON_SEQ%TYPE := 0;
    tAddressType MASTER_REASON.ADDRESS_TYPE%TYPE := AddressType;
    tExists NUMBER :=0;
  BEGIN
    if AddressType is NULL then
       tAddressType:='';
    end if;
    IF LENGTH(tAddressType) > 0 THEN
      SELECT COUNT(mstr.reason_code)
        INTO tCount
        FROM MASTER_REASON mstr
       WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
             mstr.ADDRESS_TYPE = tAddressType AND
             mstr.REASON_TYPE = ScoreType;
    ELSE
      SELECT COUNT(mstr.reason_code)
        INTO tCount
        FROM MASTER_REASON mstr
       WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
             mstr.REASON_TYPE = ScoreType;
    END IF;
    IF tCount > 0 THEN
      IF LENGTH(tAddressType) > 0 THEN
        SELECT mstr.REASON_ID, mstr.REASON_SEQ
          INTO tScoreID, tReasonSeq
          FROM MASTER_REASON mstr
         WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
               mstr.ADDRESS_TYPE = tAddressType AND
               mstr.REASON_TYPE = ScoreType AND ROWNUM = 1;
      ELSE
        SELECT mstr.REASON_ID, mstr.REASON_SEQ
          INTO tScoreID, tReasonSeq
          FROM MASTER_REASON mstr
         WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
               mstr.REASON_TYPE = ScoreType AND ROWNUM = 1;
      END IF;
      /*INSERT INTO SCORE_REASON_CODES (ORDER_NUM, BUID, ADDRESS_TYPE, REASON_CODE, REASON_SEQ, VENDOR_CODE, MATCH_RESULT)
      VALUES (OrderNum, BUID, tAddressType, ReasonCode, tReasonSeq, VendorCode, MatchResult);*/
      SELECT COUNT(*) INTO tExists FROM ORDER_SCORE_REASON WHERE ORDER_NUM = OrderNum AND BUID = pBUID AND REASON_ID = tScoreID;
      IF tExists > 0 THEN
         DELETE FROM ORDER_SCORE_REASON WHERE ORDER_NUM = OrderNum AND BUID = pBUID AND REASON_ID = tScoreID;
      END IF;
      INSERT INTO ORDER_SCORE_REASON
        (ORDER_NUM,
         BUID,
         REASON_ID,
         REASON_SEQ,
         MATCH_RESULT,
         CREATED_BY,
         CREATED_DATE)
      VALUES
        (OrderNum,
         pBUID,
         tScoreID,
         tReasonSeq,
         MatchResult,
         'ISR',
         SYSDATE);
      --todo: comment below line when done
      --COMMIT;
    END IF;
  END InsertIntoScoreTables;
  PROCEDURE InsertNegScoringtoTable(pBUID         IN ORDER_SCORE_REASON.BUID%TYPE,
                                    OrderNum      IN ORDER_SCORE_REASON.ORDER_NUM%TYPE,
                                    ReasonCode    IN MASTER_REASON.REASON_CODE%TYPE,
                                    MatchResult   IN ORDER_SCORE_REASON.MATCH_RESULT%TYPE,
                                    ScoreType     IN MASTER_REASON.REASON_TYPE%TYPE,
                                    AddressType   IN MASTER_REASON.ADDRESS_TYPE%TYPE,
                                    MatchingBUIDs IN Varchar2) IS
    tCount            NUMBER := 0;
    tScoreReasonCount NUMBER := 0;
    tScoreID          MASTER_REASON.REASON_ID%TYPE := 0;
    tReasonSeq        MASTER_REASON.REASON_SEQ%TYPE := 0;
    tAddressType      MASTER_REASON.ADDRESS_TYPE%TYPE := AddressType;
  BEGIN
    if AddressType is NULL then
       tAddressType:='';
    end if;
    IF LENGTH(tAddressType) > 0 THEN
      SELECT COUNT(mstr.reason_code)
        INTO tCount
        FROM MASTER_REASON mstr
       WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
             trim(mstr.ADDRESS_TYPE) = tAddressType AND
             mstr.REASON_TYPE = ScoreType;
    ELSE
      SELECT COUNT(mstr.reason_code)
        INTO tCount
        FROM MASTER_REASON mstr
       WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
             mstr.REASON_TYPE = ScoreType;
    END IF;
    IF tCount > 0 THEN
      IF LENGTH(tAddressType) > 0 THEN
        SELECT mstr.REASON_ID, mstr.REASON_SEQ
          INTO tScoreID, tReasonSeq
          FROM MASTER_REASON mstr
         WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
               mstr.ADDRESS_TYPE = tAddressType AND
               mstr.REASON_TYPE = ScoreType AND ROWNUM = 1;
      ELSE
        SELECT mstr.REASON_ID, mstr.REASON_SEQ
          INTO tScoreID, tReasonSeq
          FROM MASTER_REASON mstr
         WHERE mstr.REASON_CODE = ReasonCode AND mstr.ENABLED_FLAG = 'Y' AND
               mstr.REASON_TYPE = ScoreType AND ROWNUM = 1;
      END IF;
      /*INSERT INTO SCORE_REASON_CODES (ORDER_NUM, BUID, ADDRESS_TYPE, REASON_CODE, REASON_SEQ, VENDOR_CODE, MATCH_RESULT)
      VALUES (OrderNum, BUID, tAddressType, ReasonCode, tReasonSeq, VendorCode, MatchResult);*/
      If tScoreID is not Null Then
        SELECT COUNT(REASON_ID)
          INTO tScoreReasonCount
          FROM ORDER_SCORE_REASON
         WHERE BUID = pBUID AND ORDER_NUM = OrderNum AND
               REASON_ID = tScoreID;
        If tScoreReasonCount = 0 Then
          INSERT INTO ORDER_SCORE_REASON
            (ORDER_NUM,
             BUID,
             REASON_ID,
             REASON_SEQ,
             MATCH_RESULT,
             CREATED_BY,
             CREATED_DATE,
             MATCH_BUIDS)
          VALUES
            (OrderNum,
             pBUID,
             tScoreID,
             tReasonSeq,
             MatchResult,
             'ISR',
             SYSDATE,
             MatchingBUIDs);
        End If;
      End If;
      --todo: comment below line when done
      --COMMIT;
    END IF;
  END InsertNegScoringtoTable;Thanks in advance.

Answer 1

PROCEDURE insertintoscoretables (
   pbuid         IN   order_score_reason.buid%TYPE,
   ordernum      IN   order_score_reason.order_num%TYPE,
   reasoncode    IN   master_reason.reason_code%TYPE,
   matchresult   IN   order_score_reason.match_result%TYPE,
   scoretype     IN   master_reason.reason_type%TYPE,
   addresstype   IN   master_reason.address_type%TYPE
IS
   tcount         NUMBER                            := 0;
   tscoreid       master_reason.reason_id%TYPE      := 0;
   treasonseq     master_reason.reason_seq%TYPE     := 0;
   taddresstype   master_reason.address_type%TYPE   := addresstype;
   texists        NUMBER                            := 0;
BEGIN
   IF addresstype IS NULL
   THEN
      taddresstype := NULL;
   END IF;
--   IF LENGTH (taddresstype) > 0
--   THEN
   BEGIN
      SELECT COUNT (mstr.reason_code)
        INTO tcount
        FROM master_reason mstr
       WHERE mstr.reason_code = reasoncode
         AND   mstr.enabled_flag = 'Y'
              AND (  LENGTH (taddresstype) > 0
              AND mstr.address_type = taddresstype
         AND mstr.reason_type = scoretype;
   EXCEPTION
      WHEN NO_DATA_FOUND
      THEN
         tscoreid := NULL;
         treasonseq := NULL;
      WHEN OTHERS
      THEN
         raise_application_error (-20223, 'others');
   END;
--   ELSE
--      SELECT COUNT (mstr.reason_code)
--        INTO tcount
--        FROM master_reason mstr
--       WHERE mstr.reason_code = reasoncode
--         AND mstr.enabled_flag = 'Y'
--         AND mstr.reason_type = scoretype;
--   END IF;
   IF tcount > 0
   THEN
      BEGIN
         SELECT mstr.reason_id, mstr.reason_seq
           INTO tscoreid, treasonseq
           FROM master_reason mstr
          WHERE mstr.reason_code = reasoncode
            AND mstr.enabled_flag = 'Y'
            AND (LENGTH (taddresstype) > 0
                 AND mstr.address_type = taddresstype
            AND mstr.reason_type = scoretype
            AND ROWNUM = 1;
      EXCEPTION
         WHEN NO_DATA_FOUND
         THEN
            tscoreid := NULL;
            treasonseq := NULL;
         WHEN OTHERS
         THEN
            raise_application_error (-20223, 'others');
      END;
      /*INSERT INTO SCORE_REASON_CODES (ORDER_NUM, BUID, ADDRESS_TYPE, REASON_CODE, REASON_SEQ, VENDOR_CODE, MATCH_RESULT)
      VALUES (OrderNum, BUID, tAddressType, ReasonCode, tReasonSeq, VendorCode, MatchResult);*/
      BEGIN
         SELECT 'Y'
           INTO texists
           FROM order_score_reason
          WHERE order_num = ordernum AND buid = pbuid AND reason_id = tscoreid;
         IF SQL%ROWCOUNT = 0
         THEN
            BEGIN
               INSERT INTO order_score_reason
                           (order_num, buid, reason_id, reason_seq,
                            match_result, created_by, created_date
                    VALUES (ordernum, pbuid, tscoreid, treasonseq,
                            matchresult, 'ISR', SYSDATE
            EXCEPTION
               WHEN OTHERS
               THEN
                  raise_application_error (-20223, 'others');
            END;
         ELSE
            BEGIN
               DELETE FROM order_score_reason
                     WHERE order_num = ordernum
                       AND buid = pbuid
                       AND reason_id = tscoreid;
            EXCEPTION
               WHEN OTHERS
               THEN
                  raise_application_error (-20223, 'others');
            END;
         END IF;
      END;
--      IF texists > 0
--      THEN
--         DELETE FROM order_score_reason
--               WHERE order_num = ordernum
--                 AND buid = pbuid
--                 AND reason_id = tscoreid;
--      END IF;
   -- INSERT INTO order_score_reason
--                  (order_num, buid, reason_id, reason_seq, match_result,
--                   created_by, created_date
--           VALUES (ordernum, pbuid, tscoreid, treasonseq, matchresult,
--                   'ISR', SYSDATE
   --todo: comment below line when done
   --COMMIT;
   END IF;
END insertintoscoretables;
PROCEDURE insertnegscoringtotable (
   pbuid           IN   order_score_reason.buid%TYPE,
   ordernum        IN   order_score_reason.order_num%TYPE,
   reasoncode      IN   master_reason.reason_code%TYPE,
   matchresult     IN   order_score_reason.match_result%TYPE,
   scoretype       IN   master_reason.reason_type%TYPE,
   addresstype     IN   master_reason.address_type%TYPE,
   matchingbuids   IN   VARCHAR2
IS
   tcount              NUMBER                            := 0;
   tscorereasoncount   NUMBER                            := 0;
   tscoreid            master_reason.reason_id%TYPE      := 0;
   treasonseq          master_reason.reason_seq%TYPE     := 0;
   taddresstype        master_reason.address_type%TYPE   := addresstype;
BEGIN
   IF addresstype IS NULL
   THEN
      taddresstype := '';
   END IF;
   BEGIN
      SELECT COUNT (mstr.reason_code)
        INTO tcount
        FROM master_reason mstr
       WHERE mstr.reason_code = reasoncode
         AND mstr.enabled_flag = 'Y'
              AND  (   LENGTH (taddresstype) > 0
              AND mstr.address_type = taddresstype
         AND mstr.reason_type = scoretype;
   EXCEPTION
      WHEN NO_DATA_FOUND
      THEN
         tscoreid := NULL;
         treasonseq := NULL;
      WHEN OTHERS
      THEN
         raise_application_error (-20223, 'others');
   END;
   IF tcount > 0
   THEN
      BEGIN
         SELECT mstr.reason_id, mstr.reason_seq
           INTO tscoreid, treasonseq
           FROM master_reason mstr
          WHERE mstr.reason_code = reasoncode
            AND mstr.enabled_flag = 'Y'
            AND (LENGTH (taddresstype) > 0
                 AND mstr.address_type = taddresstype
            AND mstr.reason_type = scoretype
            AND ROWNUM = 1;
      EXCEPTION
         WHEN NO_DATA_FOUND
         THEN
            tscoreid := NULL;
            treasonseq := NULL;
         WHEN OTHERS
         THEN
            raise_application_error (-20223, 'others');
      END;
      /*INSERT INTO SCORE_REASON_CODES (ORDER_NUM, BUID, ADDRESS_TYPE, REASON_CODE, REASON_SEQ, VENDOR_CODE, MATCH_RESULT)
      VALUES (OrderNum, BUID, tAddressType, ReasonCode, tReasonSeq, VendorCode, MatchResult);*/
      IF tscoreid IS NOT NULL
      THEN
         SELECT 'Y'
           INTO tscorereasoncount
           FROM order_score_reason
          WHERE buid = pbuid AND order_num = ordernum AND reason_id = tscoreid;
         IF SQL%ROWCOUNT = 0                           --tscorereasoncount = 0
         THEN
            BEGIN
               INSERT INTO order_score_reason
                           (order_num, buid, reason_id, reason_seq,
                            match_result, created_by, created_date,
                            match_buids
                    VALUES (ordernum, pbuid, tscoreid, treasonseq,
                            matchresult, 'ISR', SYSDATE,
                            matchingbuids
            EXCEPTION
               WHEN OTHERS
               THEN
                  raise_application_error (-20223, 'others');
            END;
         END IF;
      END IF;
   --todo: comment below line when done
   --COMMIT;
   END IF;
END insertnegscoringtotable;regards,
friend
Edited by: most wanted!!!! on Apr 22, 2013 3:49 AM