Please help me: what is the wrong in my code?

Question

Hi all ,
I wrote a script in unix to send a mail, i am executing the script using java code, when i test the script separately in unix it is working properly , when i am executing it in java it is not working properly it is not showing any errors.
UNIX script: Send_mail.ksh
#!/bin/ksh
. ./set_mail_details.ksh
echo 'In script'
subject=$1
echo '\nsubject'
echo $1
echo "$subject" | sed 's/~/ /g' | read sub
body_of_email=$2
echo '\nBody'
echo $2
echo '\nMail List'
to_list=$3
echo $3
echo "$body_of_email" | sed 's/~/ /g' | read body
(echo "$body";echo '\n';cat U.CUE_CPM )| mailx -s "$sub" -r [email protected] "$to_list"
if [ $? -eq 0 ]
then
  echo "Mail is Sent"
else
  echo "Mail is not sent(In script)"
fijava code: sendMail.java
import java.lang.*;
import java.util.*;
import java.io.*;
public class sendMail
  public static void main(String argv[])
      /* This function will send a mail.*/
          String mailIds = "[email protected],[email protected]";
          try{
               String subject="Test mail";
                   String body = "This is to test the code";
                   String exec_command = "send_mail.ksh "+subject+" "+body+" "+mailIds;
                   Process p = Runtime.getRuntime().exec(exec_command);
                        int exitVal=p.waitFor();
                        if (exitVal == 0)
                                System.out.println("Mail Is Sent Successfully");
                        else
                                System.out.println("Mail Is Not Sent ");
                 catch(Exception e)
                    System.out.println("Mail Delivary Failure due to following reasons.");
                        System.out.println("error in email:"+e.getMessage());
                        System.out.println("Cause:"+e.getCause());
                        System.out.println("to string:"+e.toString());
}when i execute the sendMail i am getting the output as
$ java sendMail
Mail Is Sent Successfully
but i didn't receive any mail.can any one please help in resolving my prob :((

Answer 1

When using Runtime.exec(String) method, the parameter is split by whitespaces. The first token being the program to run, and each other being considerred as an argument to this program.
In your test, the body contains whitespaces. Therefore, "This" is considered as one argument, and "is" as another one (mail list in this case...), etc.
You should consider using the Runtime.exec(String[]) method instead, whith which you have control on the parameters (the first element of the array being the command and every subsequent element being an argument.)String[] exec_command = {"send_mail.ksh", subject, body, mailIds};
Process p = Runtime.getRuntime().exec(exec_command);http://java.sun.com/j2se/1.5.0/docs/api/java/lang/Runtime.html
Tim - What about JavaMail ?