PLS-00394 - Using collections

Question

Oracle 9i
I get the following error when I run the below stored procedure.
PLS-00394: wrong number of values in the INTO list of FETCH statement.
CREATE OR REPLACE procedure TEST_PROC
is
cnt number := 1;
type my_record is record
a varchar2(20),
b number(10),
c varchar2(50),
d varchar2(10),
e number(2),
l char(2) :='ll',
m varchar2(2) :='mm',
n varchar2(2) :='nn',
s varchar2(2) :='ss'
type tab_my_rec is table of my_record;
tab_rec tab_my_rec;
cursor cur is
select a,b,c,d,e from table2;
begin
open cur;
loop
fetch cur bulk collect into tab_rec limit 100;
forall t in 1.. tab_rec.count
insert into (select a,b,c,d,e,l,m,n....s from table1) values tab_rec(t);
-- Commit every 100 records
cnt := cnt+1;
if mod(cnt, 100) = 0 THEN
     COMMIT;
end if;
EXIT WHEN tab_rec.COUNT = 0;
end loop;
commit;
close cur;
end;
If I specify a default value in the select clause then it works
cursor cur
is
select a,b,c,d,e,'ll','mm',.,.,.,.,'ss' from table2;
Question:
1) I need to insert default values to the last columns(column 7 .....column 10) of a table1. Should i specify it in the cursor or can i do only by defining it at the record level? I do not want to define it in the select statement.
Should the number of columns selected in the SELECT query match the number of variables used in the fetch statement?
2) I am using records to group related data items from table2 & load it into table1 with some additional constant fields. Using RECORDS an ideal approach?
Thanks in advance.

Answer 1

Thanks for the reply.
Yes you are right I do have a workaround. But it goes back to my original question were i didn't want to define the constant values in the cursor declaration section but wanted to specify it while inserting the values. I don't think its possible to do it directly in oracle 9i or 10g becuase of the restriction stated above.
This works
forall t in 1.. tab_rec.count
insert into (select a,b,c,d,e,l,m,n....s from table1) values tab_rec(t);
This doesn't
forall t in 1.. tab_rec.count
insert into (select a,b,c,d,e,l,m,n....s from table1) values (tab_rec(t).a,tab_rec(t).b,tab_rec(t).c,tab_rec(t).d,tab_rec(t).e,'ll','mm','nn',....,'ss');
Can not reference individual attributes of records with FORALL in (oracle 9i or 10g).
I think the only solution is to define the constant values in the cursor select statement & in the record declartion to hold these values and insert them all. Like this
forall t in 1.. tab_rec.count
insert into (select a,b,c,d,e,l,m,n....s from table1) values tab_rec(t);
Committing once at the end of all the inserts might not works as I have 1 million records to insert.
Solomon is right my code for commit is not efficient. If I have 1 million records to commit then is it good to commit for every 1000 or 10000 records? How do I code it more efficiently?
Thanks in advance. Appreciate your input.