PROBLEM INSERTING DATE

Question

Hi all
I am writing procedure to take some of the work out of adding new data and I am so close to finishing it but one problem, I keep getting a wrong data type error on the date insert parameter 'p_todate' the procedure compiles fine but i still get the error. any idea why this is happening. here is the procedure(sorry if the format is alittle hard to read)...
CREATE OR REPLACE PROCEDURE joe_versioning (
p_portal VARCHAR2,
p_zone VARCHAR2,
p_desc VARCHAR2,
p_todate date,
p_createdby VARCHAR2
IS
-- CURSOR c_ongen
-- IS
-- SELECT outlet_code
-- FROM spread_buyers_range_number@genesis
-- WHERE outlet_code = SUBSTR (p_desc, LENGTH (p_desc) - 3)
-- GROUP BY outlet_code;
CURSOR c_nextid
IS
SELECT MAX (ID) + 1 AS idval
FROM st_versions
WHERE ID < 9000;
CURSOR c_vertype
IS
SELECT ID
FROM st_version_types
WHERE version_type = p_zone;
--declarations
-- l_ongen c_ongen%ROWTYPE;
l_nextid c_nextid%ROWTYPE;
l_vertype c_vertype%ROWTYPE;
BEGIN
-- OPEN c_ongen;
-- FETCH c_ongen INTO l_ongen;
-- IF c_ongen%FOUND THEN
IF p_portal = 'INDEXEXTRA'
THEN
OPEN c_nextid;
FETCH c_nextid INTO l_nextid;
OPEN c_vertype;
FETCH c_vertype INTO l_vertype;
INSERT INTO joe_st_versions_inserted
VALUES (l_nextid.idval,
                         p_portal, p_zone,
                         'PC',
                         p_desc,
'LIVE_EXTRA',
                         'LOCAL',
                         'url',
                         SYSDATE,
                         to_date(p_todate,'dd-mm-yy'),
SUBSTR (p_desc, LENGTH (p_desc) - 3),
                         SYSDATE,
                         p_createdby,
                         NULL,
                         NULL,
'PENDING',
                         999, 'N',
                         'LOCAL',
                         'EXTRA_WIP_PENDING',
                         'P',
NULL,
                         NULL,
                         l_vertype.ID,
SUBSTR (p_desc, 1, LENGTH (p_desc) - 4),
                         NULL,
                         NULL,
                         SUBSTR (p_desc, 1, 4));
ELSE
INSERT INTO joe_st_versions_inserted
VALUES (l_nextid.idval,
               p_portal,
                         p_zone,
                         'PC',
                         p_desc,
'LIVE_LCC',
                         'LOCAL',
                         'url',
                         SYSDATE,
                         to_date(p_todate,'dd-mm-yy'),
SUBSTR (p_desc, LENGTH (p_desc) - 3),
                         SYSDATE,
                         p_createdby,
                         NULL,
                         NULL,
'LCC_PENDING',
                         999,
                         'N',
                         'LOCAL',
                         'LCC_WIP_PENDING',
'P',
                         NULL,
                         NULL,
                         l_vertype.ID,
SUBSTR (p_desc, 1, LENGTH (p_desc) - 4),
                         NULL,
                         NULL,
                         SUBSTR (p_desc, 1, 4));
END IF; --p_portal = 'INDEXEXTRA'
CLOSE c_nextid;
CLOSE c_vertype;
-- -- END IF; --c_ongen%found
-- CLOSE c_ongen;
END joe_versioning;
/

Answer 1

Some suggestions;
You may be able to do this insert with SQL using CASE and SEQUENCES.
Here is an untested version of your code that may assist???
CREATE OR REPLACE PROCEDURE joe_versioning (
   p_portal      VARCHAR2,
   p_zone        VARCHAR2,
   p_desc        VARCHAR2,
   p_todate      DATE,
   p_createdby   VARCHAR2
IS
  -- **** not sure of column names  ****  
   n_nextid       joe_st_versions_inserted.col1%ROWTYPE;
   v_vertype      joe_st_versions_inserted.col24%ROWTYPE;
   v_live_type    joe_st_versions_inserted.col6%ROWTYPE;
   v_pending_type joe_st_versions_inserted.col16%ROWTYPE;
   v_wip_pending  joe_st_versions_inserted.col20%ROWTYPE;
BEGIN
   -- Cursor not required as it only return one row 
   -- You may want to look at sequences for this 
   SELECT MAX (ID) + 1
   INTO n_nextid
   FROM st_versions
   WHERE ID < 9000;
   -- Assuming that this query return only one row  
   SELECT ID
   INTO v_vertype
   FROM st_version_types
   WHERE version_type = p_zone;
   -- You can change the conditional values here instead of multiple inserts 
   IF p_portal = 'INDEXEXTRA'
      v_live_type := 'LIVE_EXTRA'
      v_pending_type := 'PENDING'
      v_wip_pending := 'EXTRA_WIP_PENDING'
   ELSE
      v_live_type := 'LIVE_LCC'
      v_pending_type := 'LCC_PENDING'
      v_wip_pending := 'LCC_WIP_PENDING'
   END IF;    
   -- You may want to name your columns for clarification and stronger code 
   -- ie, If the table columns are reordered, this insert will still work 
   INSERT INTO joe_st_versions_inserted (
      col1,
      col2,
      col3,
      col4,
      col5,
      col6,
      col7,
      col8,
      col9,
      col10,
      col11,
      col12,
      col13,
      col14,
      col15,
      col16,
      col17,
      col18,
      col19,
      col20,
      col21,
      col22,
      col23,
      col24,
      col25,
      col26,
      col27,
      col28)  
      VALUES (
         n_nextid,
         p_portal,
         p_zone,
         'PC',
         p_desc,
         v_live_type,
         'LOCAL',
         'url',
         SYSDATE,
         p_todate,
         SUBSTR (p_desc, LENGTH (p_desc) - 3),
         SYSDATE,
         p_createdby,
         NULL,
         NULL,
         v_pending_type,
         999,
         'N',
         'LOCAL',
         v_wip_pending,
         'P',
         NULL,
         NULL,
         v_vertype,
         SUBSTR (p_desc, 1, LENGTH (p_desc) - 4),
         NULL,
         NULL,
         SUBSTR (p_desc, 1, 4));
END joe_versioning;
/