Problem with collecting several classes in a Vector.

Question

Hi,
sorry if I'm asking about a thing which was discussed earlier, but with the search tool I found nothing :-((
I have a following problem: I got some data from the DB. First, it will be packed in a class (say, it's called myClass) which has set-methods for that. Then this class is packed into a vector and the same thing repeats as long as the ResultSet has more data. It looks like this:
ResultSet rs = myPreparedStatement.executeQuery();
while(rs.next()){
myClass = new MyClass();
myClass.setVar1(rs.getInt("Column1"));
myClass.setVar1(rs.getString("Column2"));
myClass.setVarX(rs.getInt("ColumnX"));
vector.add(myClass);
myClass = null;
The problem is that after all I have a vector full with the elements, which all have the values of the last data-set.
What am I doing wrong? Please help.
Many thanks in advance
Emil

Answer 1

variable in the myClass are static?Ooh. Good call. I didn't think of that.
No, they are not static, otherwise I wouldn't lose my time writting get- and set-methods.
Thank you, jverd, for the advise about "code"-tag and sorry... I didn't believe my eyes as I see the behavior I described, but the program do behave like this :-( That's why I've written, that it must be something very stupid.
2) myClass = null is pointless and does nothing useful there. I have noticed it already and this line is deleted.
public Properties getDataList(Properties props){
    MyClass myClass = (MyClass)props.get("myclass");
    /*Here I fill my PreparedStatement with the data from myClass
       and execute it */
    ResultSet rs = myPreparedStatement.execute();
    while(rs.next()){
         myClass = new MyClass();
         myClass.setVar1(rs.getInt("Column1"));
         myClass.setVar1(rs.getString("Column2"));
         myClass.setVarX(rs.getInt("ColumnX"));
         vector.add(myClass);
    props.put("vector", vector);
    return props;
}And as I've said - while debugging I could see all the values the ResultSet deliveres (and they are not the same) and all elements of the vector being overwritten with those new values.