Procedure Overloading on 10g

Question

Hi. We migrated from Oracle 9.2.0.7 and currently using Oracle 10.2.0.3.0 (development server). We have the following existing package:
PACKAGE PKG_ADMIN
FUNCTION A (p_emp_id IN NUMBER,
p_emp_type IN NUMBER)
BEGIN
RETURN ('ABC');
END;
FUNCTION A (p_emp_id IN NUMBER,
p_address_id IN NUMBER,
p_country_id IN NUMBER)
BEGIN
RETURN ('XYZ');
END;
The first function A is the only one declared in the package spec since it's set to public while the 2nd one is private. With 10g, what happens is when I run
PKG_ADMIN.A (vemp.emp_id, vemp.address_id, vemp.couontry_id) --assuming part of a pl/sql block
it gives me 'ABC' and not 'XYZ'. Is this a bug in 10g or does 10g modified the rules for procedure overloading or is there a problem with my code? This code is returning the right value under the 9i db (production server).
If there's anyone who can help, I'd appreciate it. Thanks!

Answer 1

This is the only part of the code that calls the function (which calls the overloaded function). Even if I paste the entire script, this will only be the part that would make sense. I modified "fnc_is_decoder_valid" with "fnc_is_valid" because that was what I mentioned earlier where I used representations. I apologize for the mix ups.
Please allow me to start all over again...I am pasting the actual codes
-- package spec
CREATE OR REPLACE PACKAGE dbpk_signal_admin AS
FUNCTION fnc_is_decoder_valid (
p_ad_rec IN affiliate_decoders%ROWTYPE
RETURN BOOLEAN;
FUNCTION fnc_right_length_for_decoder (
p_unit_address IN affiliate_decoder_uas.unit_address%TYPE
, p_decoder_id IN affiliate_decoder_uas.decoder_id%TYPE
, p_log_number IN affiliate_decoder_uas.log_number%TYPE
, p_feed_code IN affiliate_decoder_uas.feed_code%TYPE
RETURN BOOLEAN;
END dbpk_signal_admin;
-- package body
CREATE OR REPLACE PACKAGE BODY dbpk_signal_admin AS
FUNCTION fnc_right_length_for_decoder (
p_unit_address IN affiliate_decoder_uas.unit_address%TYPE
, p_decoder_id IN affiliate_decoder_uas.decoder_id%TYPE
, p_log_number IN affiliate_decoder_uas.log_number%TYPE
, p_feed_code IN affiliate_decoder_uas.feed_code%TYPE
RETURN BOOLEAN IS
l_retval BOOLEAN := FALSE;
l_max_len PLS_INTEGER;
BEGIN
SELECT DISTINCT adcr.ua_length
INTO l_max_len
FROM affiliate_decoder_check_refs adcr
, affiliate_decoders ade
WHERE adcr.decoder_type_id = ade.decoder_type_id
AND ade.decoder_id = p_decoder_id
AND adcr.log_number = p_log_number
AND adcr.feed_code = p_feed_code
AND adcr.active_ind = 'Y'
AND adcr.ua_length = LENGTH ( p_unit_address );
l_retval := ( LENGTH ( p_unit_address ) = l_max_len );
RETURN l_retval;
EXCEPTION
WHEN NO_DATA_FOUND
THEN
dbpk_common.prc_raise_validation_error
( 'The network feed is not valid with this decoder type.' );
WHEN OTHERS
THEN
RETURN FALSE;
END fnc_right_length_for_decoder;
FUNCTION fnc_right_length_for_decoder (
p_unit_address IN affiliate_decoders.base_unit_address%TYPE
, p_decoder_type_id IN affiliate_decoders.decoder_type_id%TYPE
RETURN BOOLEAN IS
l_retval BOOLEAN := FALSE;
l_max_len PLS_INTEGER;
CURSOR l_adcr_cur IS
SELECT adcr.ua_length
FROM affiliate_decoder_check_refs adcr
WHERE adcr.decoder_type_id = p_decoder_type_id
AND adcr.ua_length = LENGTH ( p_unit_address );
BEGIN
OPEN l_adcr_cur;
FETCH l_adcr_cur
INTO l_max_len;
l_retVal := l_adcr_cur%FOUND;
CLOSE l_adcr_cur;
RETURN l_retval;
END fnc_right_length_for_decoder;
FUNCTION fnc_is_decoder_valid (
p_ad_rec IN affiliate_decoders%ROWTYPE
RETURN BOOLEAN IS
l_retval BOOLEAN := TRUE;
BEGIN
IF NOT fnc_is_decoder_internal ( p_ad_rec.decoder_id )
THEN
IF NOT fnc_has_valid_ua_characters ( p_ad_rec.base_unit_address )
THEN
dbpk_common.prc_raise_validation_error
( 'Invalid format for base unit address' );
ELSIF NOT fnc_right_length_for_decoder ( p_ad_rec.base_unit_address
, p_ad_rec.decoder_type_id )
THEN
dbpk_common.prc_raise_validation_error
( 'Invalid Base Unit Address length for Decoder Type' );
END IF;
prc_check_mixed_signals ( p_ad_rec.decoder_id );
prc_check_missing_dem_groups ( p_ad_rec.decoder_id );
prc_check_max_ua_rules ( p_ad_rec.decoder_id
, p_ad_rec.decoder_type_id );
prc_check_dupe_ua_in_core ( p_ad_rec.decoder_id
, p_ad_rec.base_unit_address );
prc_check_dupe_ua_in_spcl ( p_ad_rec.base_unit_address );
END IF;
RETURN l_retval;
EXCEPTION
WHEN dbpk_constants.e_ams_validation_failure
THEN
RAISE;
WHEN OTHERS
THEN
dbpk_common.prc_raise_validation_error
( 'Error in fnc_is_decoder_valid: '
|| SQLERRM );
END fnc_is_decoder_valid;
My concern is, why is it that when it is used this way (sql plus and forms), it gives the correct error message.
1 DECLARE
2 l_decoders_rec affiliate_decoders%ROWTYPE;
3 BEGIN
4 SELECT 92438 AS decoder_id
5 ,5429 AS headend_id
6 ,14 AS transponder
7 ,1 AS satellite_id
8 ,3 AS decoder_type_id
9 ,null AS base_unit_address
10 ,null AS who_updated
11 ,null AS when_updated
12 INTO l_decoders_rec
13 FROM dual;
14 IF dbpk_signal_admin.fnc_is_decoder_valid (l_decoders_rec) THEN
15 DBMS_OUTPUT.PUT_LINE ('No error');
16 ELSE
17 DBMS_OUTPUT.PUT_LINE ('Error');
18 END IF;
19* END;
SQL> /
DECLARE
ERROR at line 1:
ORA-20101: Invalid Base Unit Address length for Decoder Type
ORA-06512: at "AFFMKTG.DBPK_SIGNAL_ADMIN", line 1128
ORA-06512: at line 14
Using the same records, the conversion script gives a different message
407 IF l_hd_log_rec.decoder_id > 0 AND
408 l_hd_rec.decoder_type_id IS NOT NULL AND
409 l_hd_rec.base_unit_address IS NOT NULL -- past runs > 0
410 THEN -- grid data has already been inserted into affiliate_decoders
411 l_marker_str := 'MARK 90 : ';
412 /*SELECT l_hd_log_rec.decoder_id AS decoder_id
413 ,l_hd_rec.headend_id AS headend_id
414 ,l_transponder_str AS transponder
415 ,l_satellite_id_num AS satellite_id
416 ,l_hd_rec.decoder_type_id AS decoder_type_id
417 ,l_hd_rec.base_unit_address AS base_unit_address
418 ,null AS who_updated
419 ,null AS when_updated
420 INTO l_decoders_rec
421 FROM dual; */
422 SELECT 92438 AS decoder_id
423 ,5429 AS headend_id
424 ,14 AS transponder
425 ,1 AS satellite_id
426 ,3 AS decoder_type_id
427 ,'0000314556567' AS base_unit_address
428 ,null AS who_updated
429 ,null AS when_updated
430 INTO l_decoders_rec
431 FROM dual;
432 --DBMS_OUTPUT.PUT_LINE(l_hd_rec.hd_simulcast_launch_id||'*'||l_hd_rec.unit_address||'*'||
433 -- validate decoder
434 IF dbpk_signal_admin.fnc_is_decoder_valid (l_decoders_rec) AND
435 l_hd_rec.base_unit_address IS NOT NULL THEN
436 UPDATE affiliate_decoders afd
437 SET headend_id = l_hd_rec.headend_id
438 ,transponder = l_transponder_str
439 ,satellite_id = l_satellite_id_num
440 ,decoder_type_id = l_hd_rec.decoder_type_id
441 ,base_unit_address = l_hd_rec.base_unit_address
442 WHERE afd.decoder_id = l_hd_log_rec.decoder_id;
443 l_add_decoder_ind := 'U';
444 ELSE
445 l_add_decoder_ind := 'E';
446 END IF;
447 ELSIF l_hd_log_rec.decoder_id IS NULL AND -- first run
448 l_hd_rec.decoder_type_id > 0 AND
449 l_hd_rec.base_unit_address IS NOT NULL
450 THEN
451 l_marker_str := 'MARK 95 : ';
452 -- decoder_id
453 SELECT affiliate_decoders_seq.NEXTVAL
454 INTO l_decoder_id_num
455 FROM dual;
456 SELECT l_decoder_id_num AS decoder_id
457 ,l_hd_rec.headend_id AS headend_id
458 ,l_transponder_str AS transponder
459 ,l_satellite_id_num AS satellite_id
460 ,l_hd_rec.decoder_type_id AS decoder_type_id
461 ,l_hd_rec.base_unit_address AS base_unit_address
462 ,user AS who_updated
463 ,sysdate AS when_updated
464 INTO l_decoders_rec
465 FROM dual;
466 -- create decoders when valid - AFFILIATE_DECODERS
467 IF dbpk_signal_admin.fnc_is_decoder_valid (l_decoders_rec) THEN
468 INSERT INTO affiliate_decoders (DECODER_ID, HEADEND_ID, TRANSPONDER
469 ,SATELLITE_ID, DECODER_TYPE_ID, BASE_UNIT_ADDRESS)
470 VALUES (l_decoder_id_num, l_hd_rec.headend_id, l_transponder_str
471 ,l_satellite_id_num, l_hd_rec.decoder_type_id, l_hd_rec.base_unit_address);
472 l_add_decoder_ind := 'I';
473 ELSE
474 l_add_decoder_ind := 'E';
475 END IF;
476 ELSE -- decoder_type_id is null
477 l_marker_str := 'MARK 96 : ';
478 l_add_decoder_ind := 'E';
479 END IF; -- l_hd_log_rec.decoder_id > 0
759 EXCEPTION
760 WHEN dbpk_constants.e_ams_validation_failure
761 THEN
762 ROLLBACK;
763 RAISE;
764 WHEN OTHERS
765 THEN
766 ROLLBACK;
767 dbpk_common.prc_raise_validation_error
768 ( 'Error in hd grid: ' ||l_marker_str|| SQLERRM );
769* END;
770 /
ERROR at line 1:
ORA-20101: The network feed is not valid with this decoder type.
ORA-06512: at line 763
I hope this makes more sense...Thanks!