Query- Alternative way

Question

Hi All,
Below is the query used to retrieve records based on organization and responsibility parameters
select * from WIP_DISCRETE_JOBS where ORGANIZATION_ID = :ORG_ID
and :ORG_ID !=-1
union all
select * from WIP_DISCRETE_JOBS where ORGANIZATION_ID in
select ORGANIZATION_ID from HR_ALL_ORGANIZATION_UNITS
where ORGANIZATION_ID in (select ORGANIZATION_ID
from MTL_PARAMETERS
and not exists (
select 1
from ORG_ACCESS AB,
HR_ALL_ORGANIZATION_UNITS B
where AB.ORGANIZATION_ID = B.ORGANIZATION_ID
and AB.RESPONSIBILITY_ID = :P_RESP_ID
union
select AB.ORGANIZATION_ID
from ORG_ACCESS AB, HR_ALL_ORGANIZATION_UNITS B
where AB.ORGANIZATION_ID = B.ORGANIZATION_ID
and AB.RESPONSIBILITY_ID = :P_RESP_ID
AND :ORG_ID = -1
Here user can enter specific ORG_ID to get the results. Also user has provision to get all the organization belonging to particular P_RESP_ID parameter. When user pass ORG_ID = -1 then it mean, he wants all organization for the entered parameter P_RESP_ID.
Note: If user enters -1, only last part of ' union all' returns results, otherwise first part of 'union all' returns results. Also tables will have 0 records for parameter ORG_ID = -1 . So I have selected -1 as decision parameter.
Now my question is, Is there any other way of writing this query? I want to have query with good performance and more optimized. As per my knowledge this is the optimized query. Can anyone suggest if there is good optimized way of writing the same query?
Regards,
SK

Answer 1

Hi,
Maybe:
WITH     good_organization_ids     AS
     SELECT     oa.oraganiztion_id
     FROM     org_access             oa
     JOIN     hr_all_organization_units  haou      ON  oa.organization_id = haou.organization_id
     WHERE     oa.responsibility_id     = :p_resp_id
SELECT     *
FROM     wip_discrete_jobs
WHERE     (     :org_id     != 1
     AND     :org_id     = organizatiOn_id
OR     (     :org_id     = 1
     AND      (     organization_id IN (
                              SELECT  organization_id
                              FROM     good_organization_ids
          OR     NOT EXISTS        (
                              SELECT     1
                              FROM     good_organization_ids
;If you'd care to post a little sample data (CREATE TABLE and INSERT statements) for all tables, a couple of sets of parameters (:org_id and :p_resp_id), and the results you want from the same sample data for each set or parameters, then I could test it.
See the forum FAQ
SQL and PL/SQL FAQ
for how to ask questions in general, and how to ask about performance problems in particular.