Save Xml rows in table

Question

I am having Stored procedure where i am inserting category and subcategory from xml rows.
I already have three tables i.e category,subcategory and combination of both i.e  catsubcatCombination.
I would like to insert records in catsubcatCombination where columns are  pksubcatcomb, fkCatid,fksubcatId
My sp looks like
INSERT INTO [catsubcatCombination]
( [fkCategoryId] ,
[fkSubCategoryId],
[createdDate] )
SELECT [Table].[Column].value(' Value0 [1]', 'varchar(50)') AS ' Value0' ,
[Table].[Column].value(' Value1 [1]', 'varchar(50)') AS ' Value1',
GETDATE()
FROM @xmlData.nodes('/ SubCategorySkuData/SubCategorySku') AS [Table] ( [Column] )
WHERE NOT EXISTS ( SELECT distinct fkCategoryId
FROM [tblSubcategoryCombination]
WHERE fkCategoryId =(select pkCategoryId from category where categoryName= [Table].[Column].value(' Value0 [1]', 'varchar(50)'))
and fkSubCategoryId=(select pkSubCategoryId from subcategory where subCategoryName= [Table].[Column].value(' Value1 [1]', 'varchar(50)')))
I am getting error 'Error converting data type varchar to bigint'
I know the error is here
SELECT  [Table].[Column].value(' Value0 [1]', 'varchar(50)') AS ' Value0' ,
[Table].[Column].value(' Value1 [1]', 'varchar(50)') AS ' Value1',
As fkCatid,fksubcatId are bigint, so i need to fetch the pkCategoryid from category and pkSubCategoryid fom subcategory, so i was trying int this way
INSERT INTO [catsubcatCombination]
( [fkCategoryId] ,
[fkSubCategoryId],
[createdDate] )
select pkCategoryId from category where categoryName= [Table].[Column].value(' Value0 [1]', 'varchar(50)') ,
select pkSubCategoryId from subcategory, where subCategoryName= [Table].[Column].value(' Value1 [1]', 'varchar(50)'),
GETDATE()
but its not working means some syntax error.
Can anyone tell that how do i write this correctly.
Thanks in advance..
Niki

Answer 1

Hi my whole sp is below after merging the changes given by you
USE [DTestDb]
GO
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
Alter PROCEDURE [dbo].[usp_SaveCsvSubCategory11] (
@xmlData XML ,
@retValue int OUTPUT
AS
BEGIN
SET @retValue=0;
INSERT INTO [tblSubcategoryCombination]
( [fkCategoryId] ,
[fkSubCategoryId],
[createdDate] )
SELECT *
FROM
SELECT [Table].[Column].value(' Value0 [1]', 'varchar(50)') AS 'Value0' ,
[Table].[Column].value(' Value1 [1]', 'varchar(50)') AS 'Value1',
GETDATE()
FROM @xmlData.nodes('/ SubCategorySkuData/SubCategorySku') AS [Table] ( [Column] )
WHERE NOT EXISTS ( SELECT distinct fkCategoryId
FROM [tblSubcategoryCombination]
WHERE fkCategoryId =(select pkCategoryId from tblCategory where categoryName= [Table].[Column].value(' Value0 [1]', 'varchar(50)'))
and fkSubCategoryId=(select pkSubCategoryId from tblSubCategory where subCategoryName= [Table].[Column].value(' Value1 [1]', 'varchar(50)')))
)t
WHERE [Value0] LIKE '%[^0-9]%'
OR [Value1] LIKE '%[^0-9]%'
IF(@@ROWCOUNT > 0)
SET @retValue=1;
END
Altering database  i am getting error
 No column name was specified for column 3 of 't'.
Niki
I didnt ask you to change ths SP
I asked you to check if there's some nonnumeric data first
that script has to be seperate
ie just this
DECLARE @XmlData XML
SET @XmlData = '<Your xml value here>'SELECT *
FROM
SELECT [Table].[Column].value(' Value0 [1]', 'varchar(50)') AS 'Value0' ,
[Table].[Column].value(' Value1 [1]', 'varchar(50)') AS 'Value1',
GETDATE()
FROM @xmlData.nodes('/ SubCategorySkuData/SubCategorySku') AS [Table] ( [Column] )
WHERE NOT EXISTS ( SELECT distinct fkCategoryId
FROM [tblSubcategoryCombination]
WHERE fkCategoryId =(select pkCategoryId from tblCategory where categoryName= [Table].[Column].value(' Value0 [1]', 'varchar(50)'))
and fkSubCategoryId=(select pkSubCategoryId from tblSubCategory where subCategoryName= [Table].[Column].value(' Value1 [1]', 'varchar(50)')))
)t
WHERE [Value0] LIKE '%[^0-9]%'
OR [Value1] LIKE '%[^0-9]%'
and see if it returns anything
If yes then your sp code will break as it cant convert them to bigint
Please Mark This As Answer if it solved your issue
Please Vote This As Helpful if it helps to solve your issue
Visakh
My Wiki User Page
My MSDN Page
My Personal Blog
My Facebook Page