Simple IP Ban System Doesn't Seem To Work.

Question

Alright i have this;
import java.io.*;
public class security {
public static final String[] ip_bans = {"82.25.128.xxx", "127.0.0.1"};
public static boolean is_ip_banned(String a) {
     for (int i = 0; i < ip_bans.length; i++) {
          if (ip_bans[i] == a) {
               return true;
     return false;
}(xxx is actually numbers, blocked it out for security reasons).
Which i put together to hopefully check for ip bans, now i have this:
public void run() {
     try {
     shutdown_client_handler = false;
     client_listener = new java.net.ServerSocket(server_port, 1, null);
     misc.cmd_message("Server was succesfully started.");
     misc.cmd_message("Server is operating on port: "+client_listener.getLocalPort()+"");
     while (true) {
          java.net.Socket s = client_listener.accept();
          String connecting_host = s.getInetAddress().getHostAddress();
          s.setTcpNoDelay(true);
          if(true && !security.is_ip_banned(connecting_host)) {
                    misc.cmd_message("A connection from "+connecting_host+" was accepted.");
                    player_handler.new_player_client(s, connecting_host);
          } else {
               misc.cmd_message("A connection from "+connecting_host+" was declined.");
               s.close();
     } catch (Exception e) {
          Exception!
          if(!shutdown_client_handler) {
               misc.cmd_message("There was an error opening the port.");
               misc.cmd_message("The port "+server_port+" may already be in use.");
          } else {
               misc.cmd_message("The client handler was shut down.");
}However, it still accepts the connect even though my ip is in the ip ban string.
Help please :).

Answer 1

Ryan_Stanyer wrote:
I changed it to
if (ip_bans.equals("a")) {
however it still allows me to connect as if my ip wasn't in the string[].
No, it is saying the String literal "a" was not found in the Strings array ip_bans.
It never checks the value you pass in.