Someone help me,rewrite the SP using PL/SQL

Question

the following SP is written in T-SQL,now I want to rewrite it with PL/SQL,who can help me ? tks
CREATE PROCEDURE dbo.TEST_Proc_Jerry_OB @CountDay Char(8)
AS
Declare @UserID varchar(50)
Declare @Count int
Declare @SuccCount int
Declare @UnSuccCount int
create table tbTEST_Proc_Jerry_OB (
agentalias varchar(255),
count1 int,
count2 int,
count3 int
Set @UserID = 'kokuyo6'
select @Count = count(*),
@SuccCount = sum(case when DialFlag='0' then 1 else 0 end),
@UnSuccCount = sum(case when DialFlag='0' then 0 else 1 end)
from tbobcdrmast where
left(starttime,8)=@CountDay
and agentalias='kokuyo6'
group by agentalias
Order By AgentAlias
Insert Into tbTEST_Proc_Jerry_OB Values(@UserID, @Count, @SuccCount ,@UnSuccCount)
Select * From tbTEST_Proc_Jerry_OB
drop table tbTEST_Proc_Jerry_OB
GO

Answer 1

Here you ara your answer. Take good care.Indeed, I would take extreme care. I don't even have to try and test this code to know it won't work.
CREATE PROCEDURE PR_PROCEDIMIENTO(
p_exit out SYS_REFCURSOR) So we've lost the input parameter, which has now gone down to be declared as a local variable, we're passing back a pointer to a ref cursor (which I didn't see in the original requirement) and we're missing the "AS" or "IS" keyword.
>
CountDay Char(8);
UserID varchar(50);
Contador integer;Good to see you changed the reserved "Count" variable name to something else.
SuccCount integer;
UnSuccCount integer;
BEGIN
EXECUTE IMMEDIATE('create goblal temporary table
tbTEST_Proc_Jerry_OB (
agentalias varchar(255),
count1 integer,
count2 integer,
count3 integer) on commit delete rows');So you've opted for a global temporary table. Okay.
UserID := 'kokuyo6';
select count(*), sum(case when DialFlag='0' then 1
else 0 end),
sum(case when DialFlag='0' then 0 else 1 end)
into Count, SuccCount, UnSuccCountWhoops there's that reserved "Count" variable. Forgot to rename it here I see.
from tbobcdrmast where
left(starttime,8)=CountDay
and agentalias='kokuyo6'
group by agentalias
Order By AgentAlias;There's no need for the Order By on the query as the where clause has already restricted it to a single value of this anyway.
>
Insert Into tbTEST_Proc_Jerry_OB
Values(UserID, @Count, @SuccCount ,@UnSuccCount)And this is valid syntax is it?
How is it going to compile on a table that hasn't even been created yet because it gets created at run time?
>
open p_exit for Select * From
tbTEST_Proc_Jerry_OB;So you open up the ref cursor to pass back out (not part of the original requirement)
>
EXECUTE IMMEDIATE('drop table
tbTEST_Proc_Jerry_OB');And before you finish, you go and drop the global temporary table that you have a ref cursor open on. Duh!
>
END;