[svn] 3127: Updating asdoc to replace the avmplus call with new set of java files.

Question

Revision: 3127
Author: [email protected]
Date: 2008-09-05 14:16:53 -0700 (Fri, 05 Sep 2008)
Log Message:
Updating asdoc to replace the avmplus call with new set of java files.
Removing all files related to asdochelper.
QA: Yes, also please test on non windows platform.
Doc:
Tests: checkintests, asdoc
Reviewed by: Pete Farland
Modified Paths:
flex/sdk/trunk/asdoc/templates/ASDoc_Config_Base.xml
flex/sdk/trunk/asdoc/templates/asdoc-util.xslt
flex/sdk/trunk/modules/compiler/build.xml
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/AsDocAPI.java
Added Paths:
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/AsClass.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/AsDocHelper.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/AsDocUtil.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/QualifiedNameInfo.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/SortComparator.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/TopLevelClassesGenerator.ja va
Removed Paths:
flex/sdk/trunk/asdoc/templates/asDocHelper
flex/sdk/trunk/asdoc/templates/asDocHelper.linux
flex/sdk/trunk/modules/compiler/asdoc/

Answer 1

I had a generic record class that has a HashMap to hold the data fields (...)
method called createRecord() for each record type which would populate the HashMap with the correct data fieldsI'm not sure I understand: are the contents of this field map the same between two records of the same type? Then yes, you don't need to clone the map per record instance.
one thing that needs fixing is the fact that each time the createRecord() method is called I'm creating a new fieldMap to define the dataFields in the record class.Probably, but that will only get you a little bigger files; you won't gain an order of magnitude on the size of files. The problem for huge files is that as soon as their content is bigger than the available memory, you'll run into problems. A more radical approach if you need to address huge files is to process the records on the fly, and not load all records in memory. Of course not all algorithms or business logic can afford that...
I know I could rewrite the code and create a class for each record type and declare the fieldMap static but I was wondering if anyone had any better suggestions The Record instance could receive and keep a reference to its RecordType instance, and ask the RecordType instance the DataType for a field's name. That way the RecordType encapsulates the map, and there's less risk that a clumsy other class modifies the static map.
before I go rewriting a load of code.A load of code?!? Even with the idea of the static map, you only have to edit the enum type (well more accurately, each RecordType enumerated constant's createRecord() method).